Pu Lehui da5161ba94 bpftool: Fix NULL pointer dereference when pin {PROG, MAP, LINK} without FILE ...

[ Upstream commit 34de8e6e0e ]

When using bpftool to pin {PROG, MAP, LINK} without FILE,
segmentation fault will occur. The reson is that the lack
of FILE will cause strlen to trigger NULL pointer dereference.
The corresponding stacktrace is shown below:

do_pin
  do_pin_any
    do_pin_fd
      mount_bpffs_for_pin
        strlen(name) <- NULL pointer dereference

Fix it by adding validation to the common process.

Fixes: 75a1e792c3 ("tools: bpftool: Allow all prog/map handles for pinning objects")
Signed-off-by: Pu Lehui <pulehui@huawei.com>
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
Reviewed-by: Quentin Monnet <quentin@isovalent.com>
Link: https://lore.kernel.org/bpf/20221102084034.3342995-1-pulehui@huaweicloud.com
Signed-off-by: Sasha Levin <sashal@kernel.org>

2022-11-16 10:03:51 +01:00

..

bash-completion

bpftool: Rename "bpftool feature list" into "... feature list_builtins"

2022-07-05 11:53:54 +02:00

Documentation

bpftool: Rename "bpftool feature list" into "... feature list_builtins"

2022-07-05 11:53:54 +02:00

skeleton

bpftool: Add bpf_cookie to link output

2022-03-15 15:07:27 -07:00

.gitignore

bpftool: Fix SPDX tag for Makefiles and .gitignore

2021-11-10 09:00:52 -08:00

btf_dumper.c

bpftool: Fix a wrong type cast in btf_dumper_int

2022-10-21 12:38:04 +02:00

btf.c

bpftool: Add btf enum64 support

2022-06-07 10:20:43 -07:00

cfg.c

tools, bpftool: Poison and replace kernel integer typedefs

2020-05-11 21:20:46 +02:00

cfg.h

tools: bpftool: replace Netronome boilerplate with SPDX license headers

2018-12-13 12:08:44 +01:00

cgroup.c

bpftool: Fix wrong cgroup attach flags being assigned to effective progs

2022-10-21 12:38:12 +02:00

common.c

bpftool: Fix NULL pointer dereference when pin {PROG, MAP, LINK} without FILE

2022-11-16 10:03:51 +01:00

feature.c

bpftool: Rename "bpftool feature list" into "... feature list_builtins"

2022-07-05 11:53:54 +02:00

gen.c

bpftool: Don't try to return value from void function in skeleton

2022-07-29 10:43:14 -07:00

iter.c

bpftool: Use libbpf_get_error() to check error

2021-11-14 18:38:13 -08:00

jit_disasm.c

tools bpftool: Fix compilation error with new binutils

2022-08-01 15:32:46 -03:00

json_writer.c

bpftool: Support dumping metadata

2020-09-15 18:28:27 -07:00

json_writer.h

bpftool: Support dumping metadata

2020-09-15 18:28:27 -07:00

link.c

bpftool: Use libbpf_bpf_link_type_str

2022-06-02 16:26:38 -07:00

main.c

bpftool: Clear errno after libcap's checks

2022-10-21 12:39:05 +02:00

main.h

bpftool: Remove attach_type_name forward declaration

2022-06-30 16:11:20 +02:00

Makefile

bpftool: Complete libbfd feature detection

2022-08-10 10:44:01 -03:00

map_perf_ring.c

bpftool: Update btf_dump__new() and perf_buffer__new_raw() calls

2021-11-11 16:54:06 -08:00

map.c

Revert "bpftool: Use libbpf 1.0 API mode instead of RLIMIT_MEMLOCK"

2022-06-14 22:18:06 +02:00

net.c

bpftool: use new API for attaching XDP program

2022-01-20 21:22:02 -08:00

netlink_dumper.c

bpftool: Use consistent include paths for libbpf

2020-01-20 16:37:45 -08:00

netlink_dumper.h

tools: bpftool: dual license all files

2018-12-13 12:08:44 +01:00

perf.c

bpftool, musl compat: Replace nftw with FTW_ACTIONRETVAL

2022-04-25 23:24:16 +02:00

pids.c

Revert "bpftool: Use libbpf 1.0 API mode instead of RLIMIT_MEMLOCK"

2022-06-14 22:18:06 +02:00

prog.c

bpftool: Replace sizeof(arr)/sizeof(arr[0]) with ARRAY_SIZE macro

2022-07-29 10:40:51 -07:00

struct_ops.c

Revert "bpftool: Use libbpf 1.0 API mode instead of RLIMIT_MEMLOCK"

2022-06-14 22:18:06 +02:00

tracelog.c

bpftool, musl compat: Replace sys/fcntl.h by fcntl.h

2022-04-25 23:24:28 +02:00

xlated_dumper.c

bpftool: Remove usage of reallocarray()

2022-02-23 13:55:01 -08:00

xlated_dumper.h

tools: bpftool: replace Netronome boilerplate with SPDX license headers

2018-12-13 12:08:44 +01:00