mirror of
https://github.com/raspberrypi/linux.git
synced 2025-12-10 03:49:50 +00:00
39190ac7cf
The 'ld' and 'std' instructions require a 4-byte aligned displacement because they are DS-form instructions. But the "m" asm constraint doesn't enforce that. That can lead to build errors if the compiler chooses a non-aligned displacement, as seen with GCC 14: /tmp/ccuSzwiR.s: Assembler messages: /tmp/ccuSzwiR.s:2579: Error: operand out of domain (39 is not a multiple of 4) make[5]: *** [scripts/Makefile.build:229: net/core/page_pool.o] Error 1 Dumping the generated assembler shows: ld 8,39(8) # MEM[(const struct atomic64_t *)_29].counter, t Use the YZ constraints to tell the compiler either to generate a DS-form displacement, or use an X-form instruction, either of which prevents the build error. See commit2d43cc701b("powerpc/uaccess: Fix build errors seen with GCC 13/14") for more details on the constraint letters. Fixes:9f0cbea0d8("[POWERPC] Implement atomic{, 64}_{read, write}() without volatile") Cc: stable@vger.kernel.org # v2.6.24+ Reported-by: Stephen Rothwell <sfr@canb.auug.org.au> Closes: https://lore.kernel.org/all/20240913125302.0a06b4c7@canb.auug.org.au Tested-by: Mina Almasry <almasrymina@google.com> Reviewed-by: Segher Boessenkool <segher@kernel.crashing.org> Signed-off-by: Michael Ellerman <mpe@ellerman.id.au> Link: https://msgid.link/20240916120510.2017749-1-mpe@ellerman.id.au
69 lines
1.9 KiB
C
69 lines
1.9 KiB
C
#ifndef _ASM_POWERPC_ASM_COMPAT_H
|
|
#define _ASM_POWERPC_ASM_COMPAT_H
|
|
|
|
#include <asm/asm-const.h>
|
|
#include <asm/types.h>
|
|
#include <asm/ppc-opcode.h>
|
|
|
|
#ifdef __powerpc64__
|
|
|
|
/* operations for longs and pointers */
|
|
#define PPC_LL stringify_in_c(ld)
|
|
#define PPC_STL stringify_in_c(std)
|
|
#define PPC_STLU stringify_in_c(stdu)
|
|
#define PPC_LCMPI stringify_in_c(cmpdi)
|
|
#define PPC_LCMPLI stringify_in_c(cmpldi)
|
|
#define PPC_LCMP stringify_in_c(cmpd)
|
|
#define PPC_LONG stringify_in_c(.8byte)
|
|
#define PPC_LONG_ALIGN stringify_in_c(.balign 8)
|
|
#define PPC_TLNEI stringify_in_c(tdnei)
|
|
#define PPC_LLARX stringify_in_c(ldarx)
|
|
#define PPC_STLCX stringify_in_c(stdcx.)
|
|
#define PPC_CNTLZL stringify_in_c(cntlzd)
|
|
#define PPC_MTOCRF(FXM, RS) MTOCRF((FXM), RS)
|
|
#define PPC_SRL stringify_in_c(srd)
|
|
#define PPC_LR_STKOFF 16
|
|
#define PPC_MIN_STKFRM 112
|
|
|
|
#ifdef __BIG_ENDIAN__
|
|
#define LWZX_BE stringify_in_c(lwzx)
|
|
#define LDX_BE stringify_in_c(ldx)
|
|
#define STWX_BE stringify_in_c(stwx)
|
|
#define STDX_BE stringify_in_c(stdx)
|
|
#else
|
|
#define LWZX_BE stringify_in_c(lwbrx)
|
|
#define LDX_BE stringify_in_c(ldbrx)
|
|
#define STWX_BE stringify_in_c(stwbrx)
|
|
#define STDX_BE stringify_in_c(stdbrx)
|
|
#endif
|
|
|
|
#ifdef CONFIG_CC_IS_CLANG
|
|
#define DS_FORM_CONSTRAINT "Z<>"
|
|
#else
|
|
#define DS_FORM_CONSTRAINT "YZ<>"
|
|
#endif
|
|
|
|
#else /* 32-bit */
|
|
|
|
/* operations for longs and pointers */
|
|
#define PPC_LL stringify_in_c(lwz)
|
|
#define PPC_STL stringify_in_c(stw)
|
|
#define PPC_STLU stringify_in_c(stwu)
|
|
#define PPC_LCMPI stringify_in_c(cmpwi)
|
|
#define PPC_LCMPLI stringify_in_c(cmplwi)
|
|
#define PPC_LCMP stringify_in_c(cmpw)
|
|
#define PPC_LONG stringify_in_c(.long)
|
|
#define PPC_LONG_ALIGN stringify_in_c(.balign 4)
|
|
#define PPC_TLNEI stringify_in_c(twnei)
|
|
#define PPC_LLARX stringify_in_c(lwarx)
|
|
#define PPC_STLCX stringify_in_c(stwcx.)
|
|
#define PPC_CNTLZL stringify_in_c(cntlzw)
|
|
#define PPC_MTOCRF stringify_in_c(mtcrf)
|
|
#define PPC_SRL stringify_in_c(srw)
|
|
#define PPC_LR_STKOFF 4
|
|
#define PPC_MIN_STKFRM 16
|
|
|
|
#endif
|
|
|
|
#endif /* _ASM_POWERPC_ASM_COMPAT_H */
|