John Fastabend 733dcb4149 bpf, sockmap: Remove skb_orphan and let normal skb_kfree do cleanup ...

[ Upstream commit 10d58d0063 ]

Calling skb_orphan() is unnecessary in the strp rcv handler because the skb
is from a skb_clone() in __strp_recv. So it never has a destructor or a
sk assigned. Plus its confusing to read because it might hint to the reader
that the skb could have an sk assigned which is not true. Even if we did
have an sk assigned it would be cleaner to simply wait for the upcoming
kfree_skb().

Additionally, move the comment about strparser clone up so its closer to
the logic it is describing and add to it so that it is more complete.

Fixes: 604326b41a ("bpf, sockmap: convert to generic sk_msg interface")
Signed-off-by: John Fastabend <john.fastabend@gmail.com>
Signed-off-by: Alexei Starovoitov <ast@kernel.org>
Link: https://lore.kernel.org/bpf/160226865548.5692.9098315689984599579.stgit@john-Precision-5820-Tower
Signed-off-by: Sasha Levin <sashal@kernel.org>

2020-10-29 10:07:49 +01:00

..

bpf_sk_storage.c

bpf: Implement CAP_BPF

2020-05-15 17:29:41 +02:00

datagram.c

net: use indirect call wrappers for skb_copy_datagram_iter()

2020-03-25 11:30:40 -07:00

datagram.h

net/core: Allow the compiler to verify declaration and definition consistency

2019-03-27 13:49:44 -07:00

dev_addr_lists.c

net: explain the lockdep annotations for dev_uc_unsync()

2020-06-28 21:38:27 -07:00

dev_ioctl.c

ethtool: add timestamping related string sets

2020-03-29 22:32:36 -07:00

dev.c

net: Fix bridge enslavement failure

2020-09-26 18:05:23 +02:00

devlink.c

devlink: ignore -EOPNOTSUPP errors on dumpit

2020-07-30 16:51:53 -07:00

drop_monitor.c

net: Add MODULE_DESCRIPTION entries to network modules

2020-06-20 21:33:57 -07:00

dst_cache.c

treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152

2019-05-30 11:26:32 -07:00

dst.c

net/dst: use a smaller percpu_counter batch for dst entries accounting

2020-05-08 21:33:33 -07:00

failover.c

failover: allow name change on IFF_UP slave interfaces

2019-04-10 22:12:26 -07:00

fib_notifier.c

net: fib_notifier: propagate extack down to the notifier block callback

2019-10-04 11:10:56 -07:00

fib_rules.c

net: fib_rules: Correctly set table field when table number exceeds 8 bits

2020-02-16 18:38:24 -08:00

filter.c

net: Properly typecast int values to set sk_max_pacing_rate

2020-10-29 10:07:06 +01:00

flow_dissector.c

bpf, netns: Keep attached programs in bpf_prog_array

2020-06-30 10:45:08 -07:00

flow_offload.c

flow_offload: Move rhashtable inclusion to the source file

2020-07-24 15:17:22 -07:00

gen_estimator.c

net_sched: gen_estimator: extend packet counter to 64bit

2019-11-06 21:51:36 -08:00

gen_stats.c

docs: networking: convert gen_stats.txt to ReST

2020-04-28 14:39:46 -07:00

gro_cells.c

…

hwbm.c

net: hwbm: Make the hwbm_pool lock a mutex

2019-06-09 19:40:10 -07:00

link_watch.c

net: Add IF_OPER_TESTING

2020-04-20 12:43:24 -07:00

lwt_bpf.c

net: add net available in build_state

2020-03-29 22:30:57 -07:00

lwtunnel.c

net: ipv6: add rpl sr tunnel

2020-03-29 22:30:57 -07:00

Makefile

ethtool: move to its own directory

2019-12-12 17:07:05 -08:00

neighbour.c

Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net

2020-05-31 17:48:46 -07:00

net_namespace.c

Revert "netns: don't disable BHs when locking "nsid_lock""

2020-09-26 18:05:28 +02:00

net-procfs.c

net: procfs: use index hashlist instead of name hashlist

2019-10-01 14:47:19 -07:00

net-sysfs.c

net-sysfs: add a newline when printing 'tx_timeout' by sysfs

2020-07-21 15:35:58 -07:00

net-sysfs.h

net-sysfs: add netdev_change_owner()

2020-02-26 20:07:25 -08:00

net-traces.c

page_pool: add tracepoints for page_pool with details need by XDP

2019-06-19 11:23:13 -04:00

netclassid_cgroup.c

cgroup, netclassid: remove double cond_resched

2020-04-21 15:44:30 -07:00

netevent.c

treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152

2019-05-30 11:26:32 -07:00

netpoll.c

net: disable netpoll on fresh napis

2020-09-12 14:22:14 +02:00

netprio_cgroup.c

netprio_cgroup: Fix unlimited memory leak of v2 cgroups

2020-05-09 20:59:21 -07:00

page_pool.c

net: page pool: allow to pass zero flags to page_pool_init()

2020-03-29 21:49:20 -07:00

pktgen.c

docs: networking: convert pktgen.txt to ReST

2020-04-30 12:56:37 -07:00

ptp_classifier.c

treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 295

2019-06-05 17:36:38 +02:00

request_sock.c

tcp: add rcu protection around tp->fastopen_rsk

2019-10-13 10:13:08 -07:00

rtnetlink.c

rtnetlink: Fix memory(net_device) leak when ->newlink fails

2020-07-17 12:33:18 -07:00

scm.c

net: ignore sock_from_file errors in __scm_install_fd

2020-05-13 12:30:54 -07:00

secure_seq.c

crypto: lib/sha1 - remove unnecessary includes of linux/cryptohash.h

2020-05-08 15:32:17 +10:00

skbuff.c

net/core: check length before updating Ethertype in skb_mpls_{push,pop}

2020-10-14 11:55:59 +02:00

skmsg.c

bpf, sockmap: Remove skb_orphan and let normal skb_kfree do cleanup

2020-10-29 10:07:49 +01:00

sock_diag.c

sock: make cookie generation global instead of per netns

2019-08-09 13:14:46 -07:00

sock_map.c

bpf: sockmap: Require attach_bpf_fd when detaching a program

2020-06-30 10:46:39 -07:00

sock_reuseport.c

udp: Copy has_conns in reuseport_grow().

2020-07-21 15:31:02 -07:00

sock.c

net: Properly typecast int values to set sk_max_pacing_rate

2020-10-29 10:07:06 +01:00

stream.c

tcp: make sure EPOLLOUT wont be missed

2019-08-19 13:07:43 -07:00

sysctl_net_core.c

bpf: Check correct cred for CAP_SYSLOG in bpf_dump_raw_ok()

2020-07-08 16:01:21 -07:00

timestamping.c

net: Introduce a new MII time stamping interface.

2019-12-25 19:51:33 -08:00

tso.c

net: Use skb accessors in network core

2019-07-22 20:47:56 -07:00

utils.c

net: Fix skb->csum update in inet_proto_csum_replace16().

2020-01-24 20:54:30 +01:00

xdp.c

xdp: Handle frame_sz in xdp_convert_zc_to_xdp_frame()

2020-06-17 09:58:15 -07:00