linux

mirror of https://github.com/raspberrypi/linux.git synced 2025-12-09 03:20:05 +00:00

Files

Harini Katakam dfd919285f net: macb: Change interrupt and napi enable order in open

[ Upstream commit 0504453139 ]

Current order in open:
-> Enable interrupts (macb_init_hw)
-> Enable NAPI
-> Start PHY

Sequence of RX handling:
-> RX interrupt occurs
-> Interrupt is cleared and interrupt bits disabled in handler
-> NAPI is scheduled
-> In NAPI, RX budget is processed and RX interrupts are re-enabled

With the above, on QEMU or fixed link setups (where PHY state doesn't
matter), there's a chance macb RX interrupt occurs before NAPI is
enabled. This will result in NAPI being scheduled before it is enabled.
Fix this macb open by changing the order.

Fixes: ae1f2a56d2 ("net: macb: Added support for many RX queues")
Signed-off-by: Harini Katakam <harini.katakam@xilinx.com>
Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

2019-05-16 19:41:29 +02:00

Kconfig

net: ethernet: Add missing VENDOR to Cadence and Packet Engines symbols

2018-07-05 20:05:54 +09:00

macb_main.c

net: macb: Change interrupt and napi enable order in open

2019-05-16 19:41:29 +02:00

macb_pci.c

net: cadence: macb: constify pci_device_id.

2017-07-17 13:37:15 -07:00

macb_ptp.c

net: macb: add missing barriers when reading descriptors