linux

mirror of https://github.com/raspberrypi/linux.git synced 2025-12-25 19:42:19 +00:00

Files

Zeng Heng 721b75ea2d ntfs: Fix panic about slab-out-of-bounds caused by ntfs_listxattr()

[ Upstream commit 3c675ddffb ]

Here is a BUG report from syzbot:

BUG: KASAN: slab-out-of-bounds in ntfs_list_ea fs/ntfs3/xattr.c:191 [inline]
BUG: KASAN: slab-out-of-bounds in ntfs_listxattr+0x401/0x570 fs/ntfs3/xattr.c:710
Read of size 1 at addr ffff888021acaf3d by task syz-executor128/3632

Call Trace:
 ntfs_list_ea fs/ntfs3/xattr.c:191 [inline]
 ntfs_listxattr+0x401/0x570 fs/ntfs3/xattr.c:710
 vfs_listxattr fs/xattr.c:457 [inline]
 listxattr+0x293/0x2d0 fs/xattr.c:804

Fix the logic of ea_all iteration. When the ea->name_len is 0,
return immediately, or Add2Ptr() would visit invalid memory
in the next loop.

Fixes: be71b5cba2 ("fs/ntfs3: Add attrib operations")
Reported-by: syzbot+9fcea5ef6dc4dc72d334@syzkaller.appspotmail.com
Signed-off-by: Zeng Heng <zengheng4@huawei.com>
[almaz.alexandrovich@paragon-software.com: lines of the patch have changed]
Signed-off-by: Konstantin Komarov <almaz.alexandrovich@paragon-software.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>

2023-07-19 16:36:46 +02:00

lib

fs/ntfs3: Add missing header and guards to lib/ headers

2021-09-13 19:41:44 +03:00

attrib.c

fs/ntfs3: Code formatting and refactoring

2023-03-27 17:44:35 +04:00

attrlist.c

fs/ntfs3: Validate data run offset

2022-09-30 17:39:49 +03:00

bitfunc.c

fs/ntfs3: Add ntfs_bitmap_weight_le function and refactoring