Yonghong Song ad32766990 bpf: Fix a buffer out-of-bound access when filling raw_tp link_info ...

[ Upstream commit b474959d5a ]

Commit f2e10bff16 ("bpf: Add support for BPF_OBJ_GET_INFO_BY_FD for bpf_link")
added link query for raw_tp. One of fields in link_info is to
fill a user buffer with tp_name. The Scurrent checking only
declares "ulen && !ubuf" as invalid. So "!ulen && ubuf" will be
valid. Later on, we do "copy_to_user(ubuf, tp_name, ulen - 1)" which
may overwrite user memory incorrectly.

This patch fixed the problem by disallowing "!ulen && ubuf" case as well.

Fixes: f2e10bff16 ("bpf: Add support for BPF_OBJ_GET_INFO_BY_FD for bpf_link")
Signed-off-by: Yonghong Song <yhs@fb.com>
Signed-off-by: Alexei Starovoitov <ast@kernel.org>
Acked-by: Andrii Nakryiko <andriin@fb.com>
Link: https://lore.kernel.org/bpf/20200821191054.714731-1-yhs@fb.com
Signed-off-by: Sasha Levin <sashal@kernel.org>

2020-09-09 19:14:16 +02:00

..

arraymap.c

Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net

2020-05-15 13:48:59 -07:00

bpf_iter.c

bpf: Fix a rcu_sched stall issue with bpf task/task_file iterator

2020-09-03 11:29:37 +02:00

bpf_lru_list.c

treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 206

2019-05-30 11:29:53 -07:00

bpf_lru_list.h

bpf: Fix a typo "inacitve" -> "inactive"

2020-04-06 21:54:10 +02:00

bpf_lsm.c

bpf: Use tracing helpers for lsm programs

2020-06-01 15:08:04 -07:00

bpf_struct_ops_types.h

bpf: tcp: Support tcp_congestion_ops in bpf

2020-01-09 08:46:18 -08:00

bpf_struct_ops.c

bpf: Implement CAP_BPF

2020-05-15 17:29:41 +02:00

btf.c

bpf: Fix NULL pointer dereference in __btf_resolve_helper_id()

2020-07-15 22:53:39 +02:00

cgroup.c

bpf: Don't return EINVAL from {get,set}sockopt when optlen > PAGE_SIZE

2020-06-17 10:54:05 -07:00

core.c

Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next

2020-06-03 16:27:18 -07:00

cpumap.c

xdp: Rename convert_to_xdp_frame in xdp_convert_buff_to_frame

2020-06-01 15:02:53 -07:00

devmap.c

devmap: Use bpf_map_area_alloc() for allocating hash buckets

2020-06-17 10:01:19 -07:00

disasm.c

treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 295

2019-06-05 17:36:38 +02:00

disasm.h

treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 295

2019-06-05 17:36:38 +02:00

dispatcher.c

bpf: Remove bpf_image tree

2020-03-13 12:49:52 -07:00

hashtab.c

bpf: Fix map leak in HASH_OF_MAPS map

2020-07-30 01:30:22 +02:00

helpers.c

bpf: Implement BPF ring buffer and verifier support for it

2020-06-01 14:38:22 -07:00

inode.c

bpf: Create file bpf iterator

2020-05-09 17:05:26 -07:00

local_storage.c

Merge git://git.kernel.org/pub/scm/linux/kernel/git/netdev/net

2019-12-22 09:54:33 -08:00

lpm_trie.c

bpf: Implement CAP_BPF

2020-05-15 17:29:41 +02:00

Makefile

flow_dissector: Move out netns_bpf prog callbacks

2020-06-01 15:21:02 -07:00

map_in_map.c

bpf: Implement CAP_BPF

2020-05-15 17:29:41 +02:00

map_in_map.h

treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 206

2019-05-30 11:29:53 -07:00

map_iter.c

bpf: Fix pos computation for bpf_iter seq_ops->start()

2020-08-19 08:26:44 +02:00

net_namespace.c

bpf, netns: Fix use-after-free in pernet pre_exit callback

2020-06-30 10:53:42 -07:00

offload.c

bpf, offload: Replace bitwise AND by logical AND in bpf_prog_offload_info_fill

2020-02-17 16:53:49 +01:00

percpu_freelist.c

bpf: Dont iterate over possible CPUs with interrupts disabled

2020-02-24 16:18:20 -08:00

percpu_freelist.h

treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 206

2019-05-30 11:29:53 -07:00

queue_stack_maps.c

bpf: Implement CAP_BPF

2020-05-15 17:29:41 +02:00

reuseport_array.c

bpf: net: Avoid incorrect bpf_sk_reuseport_detach call

2020-07-09 22:03:31 +02:00

ringbuf.c

bpf: Enforce BPF ringbuf size to be the power of 2

2020-06-30 16:31:55 +02:00

stackmap.c

mmap locking API: add mmap_read_trylock_non_owner()

2020-06-09 09:39:14 -07:00

syscall.c

bpf: Fix a buffer out-of-bound access when filling raw_tp link_info

2020-09-09 19:14:16 +02:00

sysfs_btf.c

bpf: Support llvm-objcopy for vmlinux BTF

2020-03-19 12:32:38 +01:00

task_iter.c

bpf: Avoid visit same object multiple times

2020-09-03 11:29:37 +02:00

tnum.c

bpf: Verifier, do explicit ALU32 bounds tracking

2020-03-30 14:59:53 -07:00

trampoline.c

bpf: lsm: Implement attach, detach and execution

2020-03-30 01:34:00 +02:00

verifier.c

bpf: Fix an incorrect branch elimination by verifier

2020-06-30 22:21:05 +02:00