mirror of
https://github.com/raspberrypi/linux.git
synced 2025-12-15 22:41:38 +00:00
8d7d7a93d5
The current codebase makes use of the zero-length array language
extension to the C90 standard, but the preferred mechanism to declare
variable-length types such as these ones is a flexible array member[1][2],
introduced in C99:
struct foo {
int stuff;
struct boo array[];
};
By making use of the mechanism above, we will get a compiler warning
in case the flexible array does not occur last in the structure, which
will help us prevent some kind of undefined behavior bugs from being
inadvertently introduced[3] to the codebase from now on.
Also, notice that, dynamic memory allocations won't be affected by
this change:
"Flexible array members have incomplete type, and so the sizeof operator
may not be applied. As a quirk of the original implementation of
zero-length arrays, sizeof evaluates to zero."[1]
sizeof(flexible-array-member) triggers a warning because flexible array
members have incomplete type[1]. There are some instances of code in
which the sizeof operator is being incorrectly/erroneously applied to
zero-length arrays and the result is zero. Such instances may be hiding
some bugs. So, this work (flexible-array member conversions) will also
help to get completely rid of those sorts of issues.
This issue was found with the help of Coccinelle.
[1] https://gcc.gnu.org/onlinedocs/gcc/Zero-Length.html
[2] https://github.com/KSPP/linux/issues/21
[3] commit 7649773293 ("cxgb3/l2t: Fix undefined behaviour")
Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
Link: https://lore.kernel.org/r/20200507190210.GA15375@embeddedor
127 lines
4.2 KiB
C
127 lines
4.2 KiB
C
/* SPDX-License-Identifier: GPL-2.0-only */
|
|
/*
|
|
* Copyright (C) 2002 Intersil Americas Inc.
|
|
* Copyright (C) 2003 Luis R. Rodriguez <mcgrof@ruslug.rutgers.edu>
|
|
*/
|
|
|
|
#ifndef _ISLPCI_MGT_H
|
|
#define _ISLPCI_MGT_H
|
|
|
|
#include <linux/wireless.h>
|
|
#include <linux/skbuff.h>
|
|
#include <linux/slab.h>
|
|
|
|
/*
|
|
* Function definitions
|
|
*/
|
|
|
|
#define K_DEBUG(f, m, args...) do { if(f & m) printk(KERN_DEBUG args); } while(0)
|
|
#define DEBUG(f, args...) K_DEBUG(f, pc_debug, args)
|
|
|
|
extern int pc_debug;
|
|
#define init_wds 0 /* help compiler optimize away dead code */
|
|
|
|
|
|
/* General driver definitions */
|
|
#define PCIDEVICE_LATENCY_TIMER_MIN 0x40
|
|
#define PCIDEVICE_LATENCY_TIMER_VAL 0x50
|
|
|
|
/* Debugging verbose definitions */
|
|
#define SHOW_NOTHING 0x00 /* overrules everything */
|
|
#define SHOW_ANYTHING 0xFF
|
|
#define SHOW_ERROR_MESSAGES 0x01
|
|
#define SHOW_TRAPS 0x02
|
|
#define SHOW_FUNCTION_CALLS 0x04
|
|
#define SHOW_TRACING 0x08
|
|
#define SHOW_QUEUE_INDEXES 0x10
|
|
#define SHOW_PIMFOR_FRAMES 0x20
|
|
#define SHOW_BUFFER_CONTENTS 0x40
|
|
#define VERBOSE 0x01
|
|
|
|
/* Default card definitions */
|
|
#define CARD_DEFAULT_CHANNEL 6
|
|
#define CARD_DEFAULT_MODE INL_MODE_CLIENT
|
|
#define CARD_DEFAULT_IW_MODE IW_MODE_INFRA
|
|
#define CARD_DEFAULT_BSSTYPE DOT11_BSSTYPE_INFRA
|
|
#define CARD_DEFAULT_CLIENT_SSID ""
|
|
#define CARD_DEFAULT_AP_SSID "default"
|
|
#define CARD_DEFAULT_KEY1 "default_key_1"
|
|
#define CARD_DEFAULT_KEY2 "default_key_2"
|
|
#define CARD_DEFAULT_KEY3 "default_key_3"
|
|
#define CARD_DEFAULT_KEY4 "default_key_4"
|
|
#define CARD_DEFAULT_WEP 0
|
|
#define CARD_DEFAULT_FILTER 0
|
|
#define CARD_DEFAULT_WDS 0
|
|
#define CARD_DEFAULT_AUTHEN DOT11_AUTH_OS
|
|
#define CARD_DEFAULT_DOT1X 0
|
|
#define CARD_DEFAULT_MLME_MODE DOT11_MLME_AUTO
|
|
#define CARD_DEFAULT_CONFORMANCE OID_INL_CONFORMANCE_NONE
|
|
#define CARD_DEFAULT_PROFILE DOT11_PROFILE_MIXED_G_WIFI
|
|
#define CARD_DEFAULT_MAXFRAMEBURST DOT11_MAXFRAMEBURST_MIXED_SAFE
|
|
|
|
/* PIMFOR package definitions */
|
|
#define PIMFOR_ETHERTYPE 0x8828
|
|
#define PIMFOR_HEADER_SIZE 12
|
|
#define PIMFOR_VERSION 1
|
|
#define PIMFOR_OP_GET 0
|
|
#define PIMFOR_OP_SET 1
|
|
#define PIMFOR_OP_RESPONSE 2
|
|
#define PIMFOR_OP_ERROR 3
|
|
#define PIMFOR_OP_TRAP 4
|
|
#define PIMFOR_OP_RESERVED 5 /* till 255 */
|
|
#define PIMFOR_DEV_ID_MHLI_MIB 0
|
|
#define PIMFOR_FLAG_APPLIC_ORIGIN 0x01
|
|
#define PIMFOR_FLAG_LITTLE_ENDIAN 0x02
|
|
|
|
void display_buffer(char *, int);
|
|
|
|
/*
|
|
* Type definition section
|
|
*
|
|
* the structure defines only the header allowing copyless
|
|
* frame handling
|
|
*/
|
|
typedef struct {
|
|
u8 version;
|
|
u8 operation;
|
|
u32 oid;
|
|
u8 device_id;
|
|
u8 flags;
|
|
u32 length;
|
|
} __packed
|
|
pimfor_header_t;
|
|
|
|
/* A received and interrupt-processed management frame, either for
|
|
* schedule_work(prism54_process_trap) or for priv->mgmt_received,
|
|
* processed by islpci_mgt_transaction(). */
|
|
struct islpci_mgmtframe {
|
|
struct net_device *ndev; /* pointer to network device */
|
|
pimfor_header_t *header; /* payload header, points into buf */
|
|
void *data; /* payload ex header, points into buf */
|
|
struct work_struct ws; /* argument for schedule_work() */
|
|
char buf[]; /* fragment buffer */
|
|
};
|
|
|
|
int
|
|
islpci_mgt_receive(struct net_device *ndev);
|
|
|
|
int
|
|
islpci_mgmt_rx_fill(struct net_device *ndev);
|
|
|
|
void
|
|
islpci_mgt_cleanup_transmit(struct net_device *ndev);
|
|
|
|
int
|
|
islpci_mgt_transaction(struct net_device *ndev,
|
|
int operation, unsigned long oid,
|
|
void *senddata, int sendlen,
|
|
struct islpci_mgmtframe **recvframe);
|
|
|
|
static inline void
|
|
islpci_mgt_release(struct islpci_mgmtframe *frame)
|
|
{
|
|
kfree(frame);
|
|
}
|
|
|
|
#endif /* _ISLPCI_MGT_H */
|