Vlad Tsyrklevich 4190c5fd8a omap2fb: Fix stack memory disclosure ...

commit a01421e448 upstream.

Using [1] for static analysis I found that the OMAPFB_QUERY_PLANE,
OMAPFB_GET_COLOR_KEY, OMAPFB_GET_DISPLAY_INFO, and OMAPFB_GET_VRAM_INFO
cases could all leak uninitialized stack memory--either due to
uninitialized padding or 'reserved' fields.

Fix them by clearing the shared union used to store copied out data.

[1] https://github.com/vlad902/kernel-uninitialized-memory-checker

Signed-off-by: Vlad Tsyrklevich <vlad@tsyrklevich.net>
Reviewed-by: Kees Cook <keescook@chromium.org>
Fixes: b39a982dde ("OMAP: DSS2: omapfb driver")
Cc: security@kernel.org
[b.zolnierkie: prefix patch subject with "omap2fb: "]
Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

2019-01-22 21:40:34 +01:00

..

displays

Merge tag 'fbdev-v4.19' of https://github.com/bzolnier/linux

2018-08-23 15:44:58 -07:00

dss

media: omap2: omapfb: fix bugon.cocci warnings

2018-08-02 19:01:38 -04:00

Kconfig

fb_omap2: add gpiolib dependency

2018-06-08 18:08:12 +02:00

Makefile

omapfb: rename omap2 module to omap2fb.ko

2018-07-24 19:11:27 +02:00

omapfb-ioctl.c

omap2fb: Fix stack memory disclosure

2019-01-22 21:40:34 +01:00

omapfb-main.c

media: omap2: omapfb: fix boolreturn.cocci warnings

2018-08-02 19:01:05 -04:00

omapfb-sysfs.c

omapfb: Create new header file for omapfb DSS implementation

2016-06-03 16:06:38 +03:00

omapfb.h

dma-mapping: use unsigned long for dma_attrs

2016-08-04 08:50:07 -04:00

vrfb.c

treewide: devm_kzalloc() -> devm_kcalloc()

2018-06-12 16:19:22 -07:00