Florian Westphal
5f66dd1745
netfilter: log: work around missing softdep backend module
...
[ Upstream commit b53deef054 ]
iptables/nftables has two types of log modules:
1. backend, e.g. nf_log_syslog, which implement the functionality
2. frontend, e.g. xt_LOG or nft_log, which call the functionality
provided by backend based on nf_tables or xtables rule set.
Problem is that the request_module() call to load the backed in
nf_logger_find_get() might happen with nftables transaction mutex held
in case the call path is via nf_tables/nft_compat.
This can cause deadlocks (see 'Fixes' tags for details).
The chosen solution as to let modprobe deal with this by adding 'pre: '
soft dep tag to xt_LOG (to load the syslog backend) and xt_NFLOG (to
load nflog backend).
Eric reports that this breaks on systems with older modprobe that
doesn't support softdeps.
Another, similar issue occurs when someone either insmods xt_(NF)LOG
directly or unloads the backend module (possible if no log frontend
is in use): because the frontend module is already loaded, modprobe is
not invoked again so the softdep isn't evaluated.
Add a workaround: If nf_logger_find_get() returns -ENOENT and call
is not via nft_compat, load the backend explicitly and try again.
Else, let nft_compat ask for deferred request_module via nf_tables
infra.
Softdeps are kept in-place, so with newer modprobe the dependencies
are resolved from userspace.
Fixes: cefa31a9d4 ("netfilter: nft_log: perform module load from nf_tables")
Fixes: a38b5b56d6 ("netfilter: nf_log: add module softdeps")
Reported-and-tested-by: Eric Dumazet <edumazet@google.com >
Signed-off-by: Florian Westphal <fw@strlen.de >
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org >
Signed-off-by: Sasha Levin <sashal@kernel.org >
2021-10-07 07:53:11 +02:00
..
2021-08-04 10:41:03 +02:00
2021-10-07 07:53:09 +02:00
2020-10-12 01:57:34 +02:00
2021-06-09 21:29:12 +02:00
2021-06-17 03:23:00 +02:00
2019-05-21 10:50:45 +02:00
2021-03-28 17:31:14 -07:00
2019-07-16 13:16:59 +02:00
2019-07-16 13:16:59 +02:00
2021-08-06 17:07:35 +02:00
2021-06-07 12:23:37 +02:00
2021-06-07 12:23:37 +02:00
2019-12-17 22:59:31 +01:00
2021-05-05 23:45:48 +02:00
2020-07-22 01:18:05 +02:00
2021-06-01 23:53:51 +02:00
2019-06-19 17:09:52 +02:00
2021-06-07 12:23:37 +02:00
2021-05-05 23:45:48 +02:00
2019-08-27 18:07:03 +02:00
2019-05-30 11:26:32 -07:00
2021-07-02 02:29:20 +02:00
2021-05-05 23:45:48 +02:00
2021-06-18 14:47:43 +02:00
2019-06-19 17:09:55 +02:00
2021-07-02 02:07:01 +02:00
2021-06-18 14:47:43 +02:00
2021-06-18 14:47:43 +02:00
2021-06-18 14:47:43 +02:00
2021-08-06 17:07:41 +02:00
2021-08-06 17:07:41 +02:00
2021-07-02 02:07:01 +02:00
2021-05-05 23:45:48 +02:00
2019-05-31 18:02:45 +02:00
2019-07-16 13:16:59 +02:00
2019-05-30 11:26:32 -07:00
2021-08-06 17:07:41 +02:00
2019-07-16 13:16:59 +02:00
2019-09-13 12:33:06 +02:00
2019-05-24 17:37:51 +02:00
2020-10-22 14:49:36 +02:00
2021-08-06 17:07:41 +02:00
2020-06-25 00:50:31 +02:00
2021-03-31 22:34:11 +02:00
2021-09-18 13:43:53 +02:00
2020-05-27 22:20:34 +02:00
2021-04-26 03:20:47 +02:00
2021-03-31 22:34:11 +02:00
2019-07-16 13:16:59 +02:00
2021-04-26 03:20:07 +02:00
2019-07-16 13:16:59 +02:00
2019-06-22 08:59:24 -04:00
2019-07-16 13:16:59 +02:00
2019-04-11 20:59:34 +02:00
2021-04-26 03:20:07 +02:00
2019-06-22 08:59:24 -04:00
2019-07-16 13:16:59 +02:00
2019-07-16 13:16:59 +02:00
2020-03-29 16:28:29 +02:00
2020-07-24 15:41:54 -07:00
2021-06-10 14:26:18 -07:00
2021-10-07 07:53:10 +02:00
2021-06-17 03:23:00 +02:00
2021-09-18 13:43:53 +02:00
2021-05-29 01:04:54 +02:00
2021-05-29 01:04:53 +02:00
2021-06-07 13:01:52 -07:00
2021-05-29 01:04:53 +02:00
2021-08-06 17:07:41 +02:00
2021-06-07 12:23:36 +02:00
2021-05-05 22:26:09 +02:00
2021-06-07 12:23:36 +02:00
2021-06-07 12:41:10 +02:00
2021-01-27 23:16:02 +01:00
2021-01-27 23:16:02 +01:00
2021-05-29 01:04:54 +02:00
2021-05-29 01:04:54 +02:00
2021-05-29 01:04:54 +02:00
2021-04-18 22:02:21 +02:00
2021-10-07 07:53:11 +02:00
2020-06-25 00:50:31 +02:00
2021-04-18 22:04:49 +02:00
2021-09-22 12:39:28 +02:00
2021-01-27 22:53:29 +01:00
2021-04-26 03:58:17 +02:00
2021-06-29 15:45:27 -07:00
2020-06-25 00:50:31 +02:00
2020-06-25 00:50:31 +02:00
2021-01-27 23:16:02 +01:00
2021-05-29 01:04:54 +02:00
2021-01-27 22:53:29 +01:00
2021-01-27 23:16:02 +01:00
2021-01-27 23:16:02 +01:00
2021-07-23 14:18:02 +02:00
2021-04-10 21:15:35 +02:00
2021-03-31 22:34:11 +02:00
2021-05-29 01:04:27 +02:00
2021-01-27 22:53:29 +01:00
2021-01-27 23:16:02 +01:00
2021-07-23 14:18:03 +02:00
2021-01-27 23:16:02 +01:00
2021-05-28 21:11:41 +02:00
2021-06-16 20:51:50 +02:00
2021-05-29 01:04:54 +02:00
2021-01-27 22:53:29 +01:00
2020-06-25 00:50:31 +02:00
2021-01-27 22:53:29 +01:00
2021-01-27 22:53:29 +01:00
2021-05-29 01:04:53 +02:00
2020-10-31 10:41:00 +01:00
2020-10-31 10:40:42 +01:00
2021-01-27 23:16:02 +01:00
2021-05-29 01:04:27 +02:00
2021-05-29 01:04:27 +02:00
2021-06-01 23:53:51 +02:00
2021-05-29 01:04:27 +02:00
2021-05-14 01:42:52 +02:00
2021-05-29 01:04:27 +02:00
2021-05-29 01:04:27 +02:00
2021-04-27 22:34:05 +02:00
2021-05-29 01:04:54 +02:00
2021-06-29 15:45:27 -07:00
2021-01-27 23:16:02 +01:00
2021-01-27 23:16:02 +01:00
2020-10-30 12:57:39 +01:00
2021-04-26 18:16:56 +02:00
2019-06-19 17:09:55 +02:00
2021-06-01 23:53:51 +02:00
2019-06-19 17:09:55 +02:00
2019-06-19 17:09:55 +02:00
2019-06-19 17:09:55 +02:00
2019-06-19 17:09:55 +02:00
2019-06-19 17:09:55 +02:00
2019-05-21 10:50:45 +02:00
2018-02-14 21:05:38 +01:00
2019-06-19 17:09:55 +02:00
2019-09-13 12:33:06 +02:00
2020-07-29 20:09:18 +02:00
2020-07-29 20:09:18 +02:00
2019-06-19 17:09:55 +02:00
2019-06-19 17:09:55 +02:00
2021-05-29 01:04:53 +02:00
2019-06-19 17:09:55 +02:00
2019-06-19 17:09:55 +02:00
2019-06-19 17:09:55 +02:00
2019-06-22 08:59:24 -04:00
2019-06-19 17:09:55 +02:00
2019-06-19 17:09:55 +02:00
2020-03-15 15:20:16 +01:00
2019-06-19 17:09:55 +02:00
2019-06-19 17:09:55 +02:00
2019-06-22 08:59:24 -04:00
2020-08-28 19:55:51 +02:00
2020-04-05 23:26:37 +02:00
2019-05-30 11:26:32 -07:00
2019-06-25 01:32:59 +02:00
2019-05-21 10:50:45 +02:00
2019-06-19 17:09:55 +02:00
2019-05-30 11:26:38 -07:00
2019-06-19 17:09:55 +02:00
2021-05-29 01:04:52 +02:00
2021-10-07 07:53:11 +02:00
2019-06-19 17:09:55 +02:00
2019-06-19 17:09:55 +02:00
2019-06-19 17:09:55 +02:00
2019-06-19 17:09:55 +02:00
2020-06-25 00:50:31 +02:00
2019-06-19 17:09:55 +02:00
2020-12-01 09:45:29 +01:00
2021-10-07 07:53:11 +02:00
2019-06-19 17:09:55 +02:00
2019-05-21 11:28:45 +02:00
2019-06-25 01:32:59 +02:00
2019-09-13 12:32:48 +02:00
2019-06-19 17:09:55 +02:00
2019-06-19 17:09:55 +02:00
2019-05-21 10:50:45 +02:00
2019-06-19 17:09:55 +02:00
2020-12-27 11:52:26 +01:00
2019-06-19 17:09:55 +02:00
2021-02-04 00:33:08 +01:00
2019-06-19 17:09:55 +02:00
2017-11-02 11:10:55 +01:00
2019-05-21 10:50:45 +02:00
2021-05-03 23:02:44 +02:00
2019-08-13 12:14:26 +02:00
2021-04-26 03:20:07 +02:00
2019-06-19 17:09:55 +02:00
2019-06-19 17:09:55 +02:00
2019-06-19 17:09:55 +02:00
2019-06-19 17:09:55 +02:00
2019-06-22 08:59:24 -04:00
2019-06-22 08:59:24 -04:00
2019-05-21 10:50:45 +02:00
2019-05-21 11:28:40 +02:00
2020-07-29 20:09:18 +02:00
2021-04-26 03:20:07 +02:00
2021-03-31 22:34:10 +02:00
2019-05-21 10:50:45 +02:00