mirror of
https://github.com/raspberrypi/linux.git
synced 2025-12-27 12:32:50 +00:00
4406b12214
The PowerPC vDSO uses $(CC) to link, which differs from the rest of the
kernel, which uses $(LD) directly. As a result, the default linker of
the compiler is used, which may differ from the linker requested by the
builder. For example:
$ make ARCH=powerpc LLVM=1 mrproper defconfig arch/powerpc/kernel/vdso/
...
$ llvm-readelf -p .comment arch/powerpc/kernel/vdso/vdso{32,64}.so.dbg
File: arch/powerpc/kernel/vdso/vdso32.so.dbg
String dump of section '.comment':
[ 0] clang version 14.0.0 (Fedora 14.0.0-1.fc37)
File: arch/powerpc/kernel/vdso/vdso64.so.dbg
String dump of section '.comment':
[ 0] clang version 14.0.0 (Fedora 14.0.0-1.fc37)
LLVM=1 sets LD=ld.lld but ld.lld is not used to link the vDSO; GNU ld is
because "ld" is the default linker for clang on most Linux platforms.
This is a problem for Clang's Link Time Optimization as implemented in
the kernel because use of GNU ld with LTO requires the LLVMgold plugin,
which is not technically supported for ld.bfd per
https://llvm.org/docs/GoldPlugin.html. Furthermore, if LLVMgold.so is
missing from a user's system, the build will fail, even though LTO as it
is implemented in the kernel requires ld.lld to avoid this dependency in
the first place.
Ultimately, the PowerPC vDSO should be converted to compiling and
linking with $(CC) and $(LD) respectively but there were issues last
time this was tried, potentially due to older but supported tool
versions. To avoid regressing GCC + binutils, use the compiler option
'-fuse-ld', which tells the compiler which linker to use when it is
invoked as both the compiler and linker. Use '-fuse-ld=lld' when
LD=ld.lld has been specified (CONFIG_LD_IS_LLD) so that the vDSO is
linked with the same linker as the rest of the kernel.
$ llvm-readelf -p .comment arch/powerpc/kernel/vdso/vdso{32,64}.so.dbg
File: arch/powerpc/kernel/vdso/vdso32.so.dbg
String dump of section '.comment':
[ 0] Linker: LLD 14.0.0
[ 14] clang version 14.0.0 (Fedora 14.0.0-1.fc37)
File: arch/powerpc/kernel/vdso/vdso64.so.dbg
String dump of section '.comment':
[ 0] Linker: LLD 14.0.0
[ 14] clang version 14.0.0 (Fedora 14.0.0-1.fc37)
LD can be a full path to ld.lld, which will not be handled properly by
'-fuse-ld=lld' if the full path to ld.lld is outside of the compiler's
search path. '-fuse-ld' can take a path to the linker but it is
deprecated in clang 12.0.0; '--ld-path' is preferred for this scenario.
Use '--ld-path' if it is supported, as it will handle a full path or
just 'ld.lld' properly. See the LLVM commit below for the full details
of '--ld-path'.
Signed-off-by: Nathan Chancellor <nathan@kernel.org>
Tested-by: Alexey Kardashevskiy <aik@ozlabs.ru>
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
Reviewed-by: Alexey Kardashevskiy <aik@ozlabs.ru>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Link: https://github.com/ClangBuiltLinux/linux/issues/774
Link: 1bc5c84710
Link: https://lore.kernel.org/r/20220511185001.3269404-3-nathan@kernel.org
105 lines
4.4 KiB
Makefile
105 lines
4.4 KiB
Makefile
# SPDX-License-Identifier: GPL-2.0
|
|
|
|
# List of files in the vdso, has to be asm only for now
|
|
|
|
ARCH_REL_TYPE_ABS := R_PPC_JUMP_SLOT|R_PPC_GLOB_DAT|R_PPC_ADDR32|R_PPC_ADDR24|R_PPC_ADDR16|R_PPC_ADDR16_LO|R_PPC_ADDR16_HI|R_PPC_ADDR16_HA|R_PPC_ADDR14|R_PPC_ADDR14_BRTAKEN|R_PPC_ADDR14_BRNTAKEN|R_PPC_REL24
|
|
include $(srctree)/lib/vdso/Makefile
|
|
|
|
obj-vdso32 = sigtramp32-32.o gettimeofday-32.o datapage-32.o cacheflush-32.o note-32.o getcpu-32.o
|
|
obj-vdso64 = sigtramp64-64.o gettimeofday-64.o datapage-64.o cacheflush-64.o note-64.o getcpu-64.o
|
|
|
|
ifneq ($(c-gettimeofday-y),)
|
|
CFLAGS_vgettimeofday-32.o += -include $(c-gettimeofday-y)
|
|
CFLAGS_vgettimeofday-32.o += $(DISABLE_LATENT_ENTROPY_PLUGIN)
|
|
CFLAGS_vgettimeofday-32.o += $(call cc-option, -fno-stack-protector)
|
|
CFLAGS_vgettimeofday-32.o += -DDISABLE_BRANCH_PROFILING
|
|
CFLAGS_vgettimeofday-32.o += -ffreestanding -fasynchronous-unwind-tables
|
|
CFLAGS_REMOVE_vgettimeofday-32.o = $(CC_FLAGS_FTRACE)
|
|
CFLAGS_REMOVE_vgettimeofday-32.o += -mcmodel=medium -mabi=elfv1 -mabi=elfv2 -mcall-aixdesc
|
|
CFLAGS_vgettimeofday-64.o += -include $(c-gettimeofday-y)
|
|
CFLAGS_vgettimeofday-64.o += $(DISABLE_LATENT_ENTROPY_PLUGIN)
|
|
CFLAGS_vgettimeofday-64.o += $(call cc-option, -fno-stack-protector)
|
|
CFLAGS_vgettimeofday-64.o += -DDISABLE_BRANCH_PROFILING
|
|
CFLAGS_vgettimeofday-64.o += -ffreestanding -fasynchronous-unwind-tables
|
|
CFLAGS_REMOVE_vgettimeofday-64.o = $(CC_FLAGS_FTRACE)
|
|
# Go prior to 1.16.x assumes r30 is not clobbered by any VDSO code. That used to be true
|
|
# by accident when the VDSO was hand-written asm code, but may not be now that the VDSO is
|
|
# compiler generated. To avoid breaking Go tell GCC not to use r30. Impact on code
|
|
# generation is minimal, it will just use r29 instead.
|
|
CFLAGS_vgettimeofday-64.o += $(call cc-option, -ffixed-r30)
|
|
endif
|
|
|
|
# Build rules
|
|
|
|
ifdef CROSS32_COMPILE
|
|
VDSOCC := $(CROSS32_COMPILE)gcc
|
|
else
|
|
VDSOCC := $(CC)
|
|
endif
|
|
|
|
targets := $(obj-vdso32) vdso32.so.dbg vgettimeofday-32.o
|
|
obj-vdso32 := $(addprefix $(obj)/, $(obj-vdso32))
|
|
targets += $(obj-vdso64) vdso64.so.dbg vgettimeofday-64.o
|
|
obj-vdso64 := $(addprefix $(obj)/, $(obj-vdso64))
|
|
|
|
GCOV_PROFILE := n
|
|
KCOV_INSTRUMENT := n
|
|
UBSAN_SANITIZE := n
|
|
KASAN_SANITIZE := n
|
|
|
|
ccflags-y := -shared -fno-common -fno-builtin -nostdlib -Wl,--hash-style=both
|
|
ccflags-$(CONFIG_LD_IS_LLD) += $(call cc-option,--ld-path=$(LD),-fuse-ld=lld)
|
|
|
|
CC32FLAGS := -Wl,-soname=linux-vdso32.so.1 -m32
|
|
AS32FLAGS := -D__VDSO32__ -s
|
|
|
|
CC64FLAGS := -Wl,-soname=linux-vdso64.so.1
|
|
AS64FLAGS := -D__VDSO64__ -s
|
|
|
|
targets += vdso32.lds
|
|
CPPFLAGS_vdso32.lds += -P -C -Upowerpc
|
|
targets += vdso64.lds
|
|
CPPFLAGS_vdso64.lds += -P -C -U$(ARCH)
|
|
|
|
# link rule for the .so file, .lds has to be first
|
|
$(obj)/vdso32.so.dbg: $(src)/vdso32.lds $(obj-vdso32) $(obj)/vgettimeofday-32.o FORCE
|
|
$(call if_changed,vdso32ld_and_check)
|
|
$(obj)/vdso64.so.dbg: $(src)/vdso64.lds $(obj-vdso64) $(obj)/vgettimeofday-64.o FORCE
|
|
$(call if_changed,vdso64ld_and_check)
|
|
|
|
# assembly rules for the .S files
|
|
$(obj-vdso32): %-32.o: %.S FORCE
|
|
$(call if_changed_dep,vdso32as)
|
|
$(obj)/vgettimeofday-32.o: %-32.o: %.c FORCE
|
|
$(call if_changed_dep,vdso32cc)
|
|
$(obj-vdso64): %-64.o: %.S FORCE
|
|
$(call if_changed_dep,vdso64as)
|
|
$(obj)/vgettimeofday-64.o: %-64.o: %.c FORCE
|
|
$(call if_changed_dep,cc_o_c)
|
|
|
|
# Generate VDSO offsets using helper script
|
|
gen-vdso32sym := $(srctree)/$(src)/gen_vdso32_offsets.sh
|
|
quiet_cmd_vdso32sym = VDSO32SYM $@
|
|
cmd_vdso32sym = $(NM) $< | $(gen-vdso32sym) | LC_ALL=C sort > $@
|
|
gen-vdso64sym := $(srctree)/$(src)/gen_vdso64_offsets.sh
|
|
quiet_cmd_vdso64sym = VDSO64SYM $@
|
|
cmd_vdso64sym = $(NM) $< | $(gen-vdso64sym) | LC_ALL=C sort > $@
|
|
|
|
include/generated/vdso32-offsets.h: $(obj)/vdso32.so.dbg FORCE
|
|
$(call if_changed,vdso32sym)
|
|
include/generated/vdso64-offsets.h: $(obj)/vdso64.so.dbg FORCE
|
|
$(call if_changed,vdso64sym)
|
|
|
|
# actual build commands
|
|
quiet_cmd_vdso32ld_and_check = VDSO32L $@
|
|
cmd_vdso32ld_and_check = $(VDSOCC) $(c_flags) $(CC32FLAGS) -o $@ -Wl,-T$(filter %.lds,$^) $(filter %.o,$^) ; $(cmd_vdso_check)
|
|
quiet_cmd_vdso32as = VDSO32A $@
|
|
cmd_vdso32as = $(VDSOCC) $(a_flags) $(CC32FLAGS) $(AS32FLAGS) -c -o $@ $<
|
|
quiet_cmd_vdso32cc = VDSO32C $@
|
|
cmd_vdso32cc = $(VDSOCC) $(c_flags) $(CC32FLAGS) -c -o $@ $<
|
|
|
|
quiet_cmd_vdso64ld_and_check = VDSO64L $@
|
|
cmd_vdso64ld_and_check = $(VDSOCC) $(c_flags) $(CC64FLAGS) -o $@ -Wl,-T$(filter %.lds,$^) $(filter %.o,$^) ; $(cmd_vdso_check)
|
|
quiet_cmd_vdso64as = VDSO64A $@
|
|
cmd_vdso64as = $(VDSOCC) $(a_flags) $(CC64FLAGS) $(AS64FLAGS) -c -o $@ $<
|