linux

mirror of https://github.com/raspberrypi/linux.git synced 2025-12-15 22:41:38 +00:00

Files

Junhao He 75bab28ffd perf: hisi: Fix use-after-free when register pmu fails

[ Upstream commit b805cafc60 ]

When we fail to register the uncore pmu, the pmu context may not been
allocated. The error handing will call cpuhp_state_remove_instance()
to call uncore pmu offline callback, which migrate the pmu context.
Since that's liable to lead to some kind of use-after-free.

Use cpuhp_state_remove_instance_nocalls() instead of
cpuhp_state_remove_instance() so that the notifiers don't execute after
the PMU device has been failed to register.

Fixes: a0ab25cd82 ("drivers/perf: hisi: Add support for HiSilicon PA PMU driver")
FIxes: 3bf30882c3 ("drivers/perf: hisi: Add support for HiSilicon SLLC PMU driver")
Signed-off-by: Junhao He <hejunhao3@huawei.com>
Link: https://lore.kernel.org/r/20231024113630.13472-1-hejunhao3@huawei.com
Signed-off-by: Will Deacon <will@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>

2023-11-20 11:59:13 +01:00

hisi_pcie_pmu.c

drivers/perf: hisi_pcie: Check the type first in pmu::event_init()

2023-11-20 11:59:13 +01:00

hisi_uncore_cpa_pmu.c

drivers/perf: hisi: Remove redundant initialized of pmu->name

2023-04-17 13:14:10 +01:00

hisi_uncore_ddrc_pmu.c

drivers/perf: hisi: add NULL check for name

2023-04-17 13:14:10 +01:00

hisi_uncore_hha_pmu.c

drivers/perf: hisi: add NULL check for name