Hangbin Liu 58e0be1ef6
net: use struct_group to copy ip/ipv6 header addresses ...
kernel test robot reported warnings when build bonding module with
make W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash drivers/net/bonding/:
from ../drivers/net/bonding/bond_main.c:35:
In function ‘fortify_memcpy_chk’,
inlined from ‘iph_to_flow_copy_v4addrs’ at ../include/net/ip.h:566:2,
inlined from ‘bond_flow_ip’ at ../drivers/net/bonding/bond_main.c:3984:3:
../include/linux/fortify-string.h:413:25: warning: call to ‘__read_overflow2_field’ declared with attribute warning: detected read beyond size of f
ield (2nd parameter); maybe use struct_group()? [-Wattribute-warning]
413 | __read_overflow2_field(q_size_field, size);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In function ‘fortify_memcpy_chk’,
inlined from ‘iph_to_flow_copy_v6addrs’ at ../include/net/ipv6.h:900:2,
inlined from ‘bond_flow_ip’ at ../drivers/net/bonding/bond_main.c:3994:3:
../include/linux/fortify-string.h:413:25: warning: call to ‘__read_overflow2_field’ declared with attribute warning: detected read beyond size of f
ield (2nd parameter); maybe use struct_group()? [-Wattribute-warning]
413 | __read_overflow2_field(q_size_field, size);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
This is because we try to copy the whole ip/ip6 address to the flow_key,
while we only point the to ip/ip6 saddr. Note that since these are UAPI
headers, __struct_group() is used to avoid the compiler warnings.
Reported-by: kernel test robot <lkp@intel.com >
Fixes: c3f8324188liuhangbin@gmail.com >
Link: https://lore.kernel.org/r/20221115142400.1204786-1-liuhangbin@gmail.com
Signed-off-by: Paolo Abeni <pabeni@redhat.com >
2022-11-17 10:42:45 +01:00
2022-10-05 07:05:41 +09:00
2022-09-09 12:25:18 -07:00
2021-07-01 13:19:48 -07:00
2021-11-19 11:52:25 +00:00
2022-10-11 17:42:58 -06:00
2022-09-28 18:51:47 -07:00
2021-11-17 20:17:05 -08:00
2022-07-22 12:53:22 +01:00
2022-04-12 15:00:25 +02:00
2022-05-12 16:15:30 -07:00
2020-02-28 14:51:30 +01:00
2022-09-09 08:24:41 +01:00
2022-07-28 10:42:44 -07:00
2022-09-01 11:44:13 +01:00
2022-06-22 12:59:43 +01:00
2022-08-23 10:43:11 +02:00
2022-07-22 12:53:22 +01:00
2022-02-21 11:44:30 +00:00
2022-07-28 22:06:15 -07:00
2022-08-09 22:14:02 -07:00
2021-12-13 12:34:09 +00:00
2022-09-16 14:34:01 +01:00
2021-12-03 14:16:48 +00:00
2022-07-22 12:53:22 +01:00
2022-09-16 14:34:01 +01:00
2021-03-26 17:43:55 +01:00
2022-08-24 13:46:58 +01:00
2022-08-25 11:07:26 +02:00
2022-05-22 21:51:54 +01:00
2022-03-11 10:57:22 +00:00
2020-07-15 07:45:24 -07:00
2020-03-27 19:40:38 -07:00
2021-12-22 15:03:47 -08:00
2022-07-22 12:53:22 +01:00
2021-12-22 15:03:51 -08:00
2022-07-24 18:39:17 -06:00
2022-07-22 12:53:22 +01:00
2022-07-22 12:53:22 +01:00
2022-07-22 12:53:22 +01:00
2022-09-30 18:17:16 -07:00
2022-09-07 15:28:08 +01:00
2022-09-30 18:17:17 -07:00
2019-12-16 16:09:44 -08:00
2021-11-29 19:50:45 -08:00
2022-10-03 07:52:13 +01:00
2020-05-08 21:33:33 -07:00
2022-09-26 11:48:14 -07:00
2022-07-22 12:53:22 +01:00
2022-07-22 12:53:22 +01:00
2020-04-20 07:34:16 +02:00
2022-07-22 12:53:22 +01:00
2021-12-06 16:06:02 -08:00
2019-12-24 22:37:30 -08:00
2021-12-16 07:18:35 -08:00
2022-07-28 22:21:54 -07:00
2022-09-20 09:13:38 +02:00
2022-09-20 09:13:38 +02:00
2022-10-03 12:41:59 +01:00
2022-07-11 19:49:38 -07:00
2022-07-22 12:53:22 +01:00
2022-07-22 12:53:22 +01:00
2021-10-18 12:54:41 +01:00
2022-10-24 19:08:46 -07:00
2021-01-29 20:39:14 -08:00
2022-08-25 16:07:42 -07:00
2022-07-22 12:53:22 +01:00
2022-07-22 12:53:22 +01:00
2022-07-22 12:53:22 +01:00
2021-06-28 14:29:45 -07:00
2022-02-04 16:25:21 +01:00
2022-10-07 08:42:00 +01:00
2022-04-06 22:09:39 -07:00
2022-07-22 12:53:22 +01:00
2022-07-22 12:53:22 +01:00
2022-07-29 11:58:54 +01:00
2022-07-22 12:53:22 +01:00
2022-08-24 19:30:07 -07:00
2022-02-07 20:12:45 -08:00
2021-10-15 11:33:08 +01:00
2022-07-22 12:53:22 +01:00
2022-09-28 18:52:17 -07:00
2022-07-29 11:58:54 +01:00
2022-05-13 12:24:12 +01:00
2022-02-17 07:00:39 -06:00
2021-11-16 13:16:54 +00:00
2022-02-17 11:44:20 -08:00
2022-07-22 12:53:22 +01:00
2022-04-25 11:40:45 +01:00
2022-04-11 17:37:50 -07:00
2022-10-03 07:59:06 +01:00
2021-10-07 19:52:58 +02:00
2022-11-17 10:42:45 +01:00
2022-09-29 07:18:00 +02:00
2022-07-22 12:53:22 +01:00
2022-02-04 14:15:11 -08:00
2022-09-02 20:34:32 -07:00
2022-11-17 10:42:45 +01:00
2020-06-20 17:22:22 -07:00
2021-03-23 14:14:50 -07:00
2022-07-22 12:53:22 +01:00
2022-07-22 12:53:22 +01:00
2021-12-07 20:44:59 -08:00
2021-10-13 09:40:46 -07:00
2021-07-27 13:05:56 +01:00
2022-07-22 12:53:22 +01:00
2022-07-22 12:53:22 +01:00
2022-07-28 11:29:36 +02:00
2021-11-07 19:25:29 +00:00
2021-08-30 01:51:36 +02:00
2022-09-06 10:17:20 +02:00
2022-04-25 20:51:12 +02:00
2022-09-23 06:56:08 -07:00
2022-04-01 12:04:15 +01:00
2021-10-29 13:23:51 +01:00
2020-03-02 11:16:27 -08:00
2021-03-26 15:14:56 -07:00
2022-07-22 12:53:22 +01:00
2020-05-29 21:20:20 -07:00
2022-08-08 15:30:45 +02:00
2022-07-22 12:53:22 +01:00
2022-07-22 12:53:22 +01:00
2022-03-03 11:55:12 -08:00
2022-09-26 11:48:14 -07:00
2022-05-11 12:43:10 +01:00
2022-07-11 16:25:14 +02:00
2021-12-10 06:38:26 -08:00
2022-07-22 12:53:22 +01:00
2022-11-01 21:29:06 -07:00
2019-11-12 08:18:03 -08:00
2022-07-22 12:53:22 +01:00
2021-09-24 14:07:10 +01:00
2022-09-02 19:59:08 -07:00
2022-07-22 12:53:22 +01:00
2022-04-15 10:43:47 +01:00
2020-03-04 13:25:55 -08:00
2022-04-12 15:00:25 +02:00
2022-10-02 16:07:17 +01:00
2022-09-29 18:52:05 -07:00
2022-07-22 12:53:22 +01:00
2022-07-15 18:50:35 -07:00
2021-08-09 15:34:21 -07:00
2022-07-22 12:53:22 +01:00
2022-07-14 15:27:35 -07:00
2022-06-19 10:00:02 +01:00
2022-10-11 17:42:58 -06:00
2022-07-22 12:53:22 +01:00
2022-02-02 14:45:18 +00:00
2022-08-01 11:59:23 -07:00
2022-07-25 13:25:39 +01:00
2020-06-23 20:27:09 -07:00
2022-04-13 12:46:26 +01:00
2022-09-29 18:52:01 -07:00
2020-07-13 11:03:44 -07:00
2022-07-22 12:53:22 +01:00
2022-01-04 12:17:35 +00:00
2021-04-28 14:06:45 -07:00
2022-07-27 13:24:42 +01:00
2019-10-05 16:29:00 -07:00
2022-10-18 10:17:18 +02:00
2022-11-16 12:52:19 +00:00
2021-08-03 13:05:26 +01:00
2022-07-22 12:53:22 +01:00
2022-07-18 11:24:10 +01:00
2022-06-29 20:37:36 -07:00
2022-10-03 17:44:18 -07:00
2019-10-04 14:07:07 -07:00
2022-09-22 17:27:41 -07:00
2022-07-22 12:53:22 +01:00
2020-06-18 20:46:23 -07:00
2022-07-22 12:53:22 +01:00
2022-09-01 11:42:12 +01:00
2022-10-12 17:50:37 -07:00
2022-10-12 17:50:37 -07:00
2019-11-14 18:12:17 -08:00
2022-03-01 08:38:02 +00:00
2019-12-09 10:28:43 -08:00
2022-07-22 12:53:22 +01:00
2022-09-30 07:55:46 -07:00
2021-12-29 08:48:14 -08:00
2022-09-26 13:28:19 -07:00
2022-09-29 07:17:58 +02:00
2022-09-22 17:16:22 +02:00
58e0be1ef6