linux

mirror of https://github.com/raspberrypi/linux.git synced 2025-12-28 13:02:59 +00:00

Files

Keith Busch 8f8ad122ff nvme-tcp: fix io_work priority inversion

commit 70f437fb43 upstream.

Dispatching requests inline with the .queue_rq() call may block while
holding the send_mutex. If the tcp io_work also happens to schedule, it
may see the req_list is non-empty, leaving "pending" true and remaining
in TASK_RUNNING. Since io_work is of higher scheduling priority, the
.queue_rq task may not get a chance to run, blocking forward progress
and leading to io timeouts.

Instead of checking for pending requests within io_work, let the queueing
restart io_work outside the send_mutex lock if there is more work to be
done.

Fixes: a0fdd14180 ("nvme-tcp: rerun io_work if req_list is not empty")
Reported-by: Samuel Jones <sjones@kalrayinc.com>
Signed-off-by: Keith Busch <kbusch@kernel.org>
Reviewed-by: Sagi Grimberg <sagi@grimberg.me>
Signed-off-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

2021-09-22 12:27:57 +02:00

core.c

nvme: code command_id with a genctr for use-after-free validation

2021-09-18 13:40:29 +02:00

fabrics.c

nvme-fabrics: decode host pathing error for connect

2021-06-16 12:01:37 +02:00

fabrics.h

nvme: fix deadlock in disconnect during scan_work and/or ana_work

2020-07-29 07:45:19 +02:00

fault_inject.c

nvme: enable to inject errors into admin commands