mirror of
https://github.com/raspberrypi/linux.git
synced 2025-12-25 19:42:19 +00:00
2794449576
When CROS_EC_LPC is set to =m, we get a link failure for a
builtin wilco-ec module:
drivers/platform/chrome/wilco_ec/core.o: In function `wilco_ec_remove':
core.c:(.text+0x26): undefined reference to `cros_ec_lpc_mec_destroy'
drivers/platform/chrome/wilco_ec/core.o: In function `wilco_ec_probe':
core.c:(.text+0x18c): undefined reference to `cros_ec_lpc_mec_init'
core.c:(.text+0x224): undefined reference to `cros_ec_lpc_mec_destroy'
drivers/platform/chrome/wilco_ec/mailbox.o: In function `wilco_ec_mailbox':
mailbox.c:(.text+0x104): undefined reference to `cros_ec_lpc_io_bytes_mec'
The problem with the existing CROS_EC_LPC_MEC dependency is that this
is only for a 'bool' symbol, so the information about the exported
functions being in a module is lost on the way, and we actually have
to depend on both CROS_EC_LPC and CROS_EC_LPC_MEC.
Fixes: 7b3d4f44ab ("platform/chrome: Add new driver for Wilco EC")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
21 lines
760 B
Plaintext
21 lines
760 B
Plaintext
config WILCO_EC
|
|
tristate "ChromeOS Wilco Embedded Controller"
|
|
depends on ACPI && X86 && CROS_EC_LPC && CROS_EC_LPC_MEC
|
|
help
|
|
If you say Y here, you get support for talking to the ChromeOS
|
|
Wilco EC over an eSPI bus. This uses a simple byte-level protocol
|
|
with a checksum.
|
|
|
|
To compile this driver as a module, choose M here: the
|
|
module will be called wilco_ec.
|
|
|
|
config WILCO_EC_DEBUGFS
|
|
tristate "Enable raw access to EC via debugfs"
|
|
depends on WILCO_EC
|
|
help
|
|
If you say Y here, you get support for sending raw commands to
|
|
the Wilco EC via debugfs. These commands do not do any byte
|
|
manipulation and allow for testing arbitrary commands. This
|
|
interface is intended for debug only and will not be present
|
|
on production devices.
|