raspi/linux
1
0
Fork 1
mirror of https://github.com/raspberrypi/linux.git synced 2026-01-03 00:03:44 +00:00
Code Issues Projects Releases Wiki Activity
Files
8659186e72d0770720d052d39e4bee4a47366fd3
linux/drivers/pci/controller
History
Jon Hunter e22051e7c9 PCI: tegra194: Fix tegra_pcie_ep_raise_msi_irq() ill-defined shift 
[ Upstream commit f67092eff2 ]

tegra_pcie_ep_raise_msi_irq() shifted a signed 32-bit value left by 31
bits.  The behavior of this is implementation-defined.

Replace the shift by BIT(), which is well-defined.

Found by cppcheck:

  $ cppcheck --enable=all drivers/pci/controller/dwc/pcie-tegra194.c
  Checking drivers/pci/controller/dwc/pcie-tegra194.c ...

  drivers/pci/controller/dwc/pcie-tegra194.c:1829:23: portability: Shifting signed 32-bit value by 31 bits is implementation-defined behaviour. See condition at line 1826.  [shiftTooManyBitsSigned]

  appl_writel(pcie, (1 << irq), APPL_MSI_CTRL_1);
                     ^

[bhelgaas: commit log]
Link: https://lore.kernel.org/r/20210618160219.303092-1-jonathanh@nvidia.com
Fixes: c57247f940 ("PCI: tegra: Add support for PCIe endpoint mode in Tegra194")
Signed-off-by: Jon Hunter <jonathanh@nvidia.com>
Signed-off-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
2021-07-20 16:05:52 +02:00
..
cadence
PCI: cadence: Retrain Link to work around Gen2 training defect
2021-03-11 14:17:29 +01:00
dwc
PCI: tegra194: Fix tegra_pcie_ep_raise_msi_irq() ill-defined shift
2021-07-20 16:05:52 +02:00
mobiveil
PCI: mobiveil: Simplify mobiveil_pcie_init_irq_domain() return expression
2020-10-02 12:48:08 +01:00
Kconfig
Merge tag 'pci-v5.10-changes' of git://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci
2020-10-22 12:41:00 -07:00
Makefile
PCI: hip: Add handling of HiSilicon HIP PCIe controller errors
2020-09-16 10:30:42 +01:00
pci-aardvark.c
PCI: aardvark: Implement workaround for the readback value of VEND_ID
2021-07-19 09:45:01 +02:00
pci-ftpci100.c
PCI: ftpci100: Rename macro name collision
2021-07-20 16:05:46 +02:00
pci-host-common.c
PCI: Set bridge map_irq and swizzle_irq to default functions
2020-08-04 16:36:30 +01:00
pci-host-generic.c
PCI: host-generic: Eliminate pci_host_common_probe wrappers
2020-05-07 09:29:43 +01:00
pci-hyperv-intf.c
PCI: hv: Add a Hyper-V PCI interface driver for software backchannel interface
2019-08-22 00:25:12 -07:00
pci-hyperv.c
PCI: hv: Fix a race condition when removing the device
2021-07-20 16:05:47 +02:00
pci-loongson.c
PCI: loongson: Simplify loongson_pci_probe() return expression
2020-10-02 12:56:31 +01:00
pci-mvebu.c
PCI: mvebu: Fix duplicate resource requests
2020-11-04 13:55:30 -06:00
pci-rcar-gen2.c
PCI: rcar-gen2: Use fallthrough pseudo-keyword
2020-09-07 15:17:20 +01:00
pci-tegra.c
PCI: tegra: Add missing MODULE_DEVICE_TABLE
2021-07-20 16:05:48 +02:00
pci-thunder-ecam.c
PCI: thunder: Fix compile testing
2021-05-22 11:40:52 +02:00
pci-thunder-pem.c
PCI: thunder: Fix compile testing
2021-05-22 11:40:52 +02:00
pci-v3-semi.c
PCI: v3-semi: Remove unneeded break
2020-10-20 10:59:55 -05:00
pci-versatile.c
PCI: Set bridge map_irq and swizzle_irq to default functions
2020-08-04 16:36:30 +01:00
pci-xgene-msi.c
PCI: xgene-msi: Fix race in installing chained irq handler
2021-03-17 17:06:24 +01:00
pci-xgene.c
PCI: xgene: Fix cfg resource mapping
2021-05-14 09:49:57 +02:00
pcie-altera-msi.c
Merge branch 'pci/irq-error'
2020-08-05 18:24:22 -05:00
pcie-altera.c
Merge branch 'pci/irq-error'
2020-08-05 18:24:22 -05:00
pcie-brcmstb.c
PCI: brcmstb: Initialize "tmp" before use
2020-12-30 11:53:18 +01:00
pcie-hisi-error.c
PCI: hip: Add handling of HiSilicon HIP PCIe controller errors
2020-09-16 10:30:42 +01:00
pcie-iproc-bcma.c
PCI: iproc: Use module_bcma_driver to simplify the code
2020-10-02 12:45:26 +01:00
pcie-iproc-msi.c
PCI: iproc: Support multi-MSI only on uniprocessor kernel
2021-07-20 16:05:52 +02:00
pcie-iproc-platform.c
PCI: iproc: Fix using plain integer as NULL pointer in iproc_pcie_pltfm_probe
2020-10-09 13:37:57 +01:00
pcie-iproc.c
PCI: iproc: Invalidate correct PAXB inbound windows
2020-12-30 11:53:27 +01:00
pcie-iproc.h
PCI: iproc: Use pci_host_probe() to register host
2020-07-10 11:50:23 +01:00
pcie-mediatek.c
PCI: mediatek: Add missing of_node_put() to fix reference leak
2021-03-17 17:06:24 +01:00
pcie-rcar-ep.c
PCI: rcar: Add endpoint mode support
2020-05-22 12:35:32 +01:00
pcie-rcar-host.c
PCI: rcar: Always allocate MSI addresses in 32bit space
2021-03-04 11:38:11 +01:00
pcie-rcar.c
PCI: rcar: Fix calculating mask for PCIEPAMR register
2020-05-11 11:29:48 +01:00
pcie-rcar.h
PCI: rcar: Add endpoint mode support
2020-05-22 12:35:32 +01:00
pcie-rockchip-ep.c
PCI: Fix kerneldoc warnings
2020-08-05 18:23:14 -05:00
pcie-rockchip-host.c
PCI: rockchip: Register IRQ handlers after device and data are ready
2021-07-20 16:05:49 +02:00
pcie-rockchip.c
PCI: rockchip: Make 'ep-gpios' DT property optional
2021-03-04 11:38:18 +01:00
pcie-rockchip.h
PCI: rockchip: Use pci_is_root_bus() to check if bus is root bus
2020-07-23 11:20:50 +01:00
pcie-tango.c
PCI: Remove dev_err() when handing an error from platform_get_irq()
2020-08-03 09:26:03 -05:00
pcie-xilinx-cpm.c
PCI: xilinx-cpm: Fix reference count leak on error path
2021-03-04 11:38:11 +01:00
pcie-xilinx-nwl.c
Merge branch 'pci/irq-error'
2020-08-05 18:24:22 -05:00
pcie-xilinx.c
PCI: Set bridge map_irq and swizzle_irq to default functions
2020-08-04 16:36:30 +01:00
vmd.c
Merge tag 'pci-v5.10-changes' of git://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci
2020-10-22 12:41:00 -07:00