Namhyung Kim
2b70702917
perf tools: Remove evsel__handle_error_quirks()
...
The evsel__handle_error_quirks() is to fixup invalid event attributes on
some architecture based on the error code. Currently it's only used for
AMD to disable precise_ip not to use IBS which has more restrictions.
But the commit c33aea446b changed call evsel__precise_ip_fallback
for any errors so there's no difference with the above function. To
make matter worse, it caused a problem with branch stack on Zen3.
The IBS doesn't support branch stack so it should use a regular core
PMU event. The default event is set precise_max and it starts with 3.
And evsel__precise_ip_fallback() tries with it and reduces the level one
by one. At last it tries with 0 but it also failed on Zen3 since the
branch stack is not supported for the cycles event.
At this point, evsel__precise_ip_fallback() restores the original
precise_ip value (3) in the hope that it can succeed with other modifier
(like exclude_kernel). Then evsel__handle_error_quirks() see it has
precise_ip != 0 and make it retry with 0. This created an infinite
loop.
Before:
$ perf record -b -vv |& grep removing
removing precise_ip on AMD
removing precise_ip on AMD
removing precise_ip on AMD
removing precise_ip on AMD
removing precise_ip on AMD
removing precise_ip on AMD
removing precise_ip on AMD
removing precise_ip on AMD
removing precise_ip on AMD
removing precise_ip on AMD
removing precise_ip on AMD
removing precise_ip on AMD
...
After:
$ perf record -b true
Error:
Failure to open event 'cycles:P' on PMU 'cpu' which will be removed.
Invalid event (cycles:P) in per-thread mode, enable system wide with '-a'.
Error:
Failure to open any events for recording.
Fixes: c33aea446b ("perf tools: Fix precise_ip fallback logic")
Tested-by: Chun-Tse Shao <ctshao@google.com >
Cc: Ravi Bangoria <ravi.bangoria@amd.com >
Link: https://lore.kernel.org/r/20250410010252.402221-1-namhyung@kernel.org
Signed-off-by: Namhyung Kim <namhyung@kernel.org >
2025-04-11 09:22:49 -07:00
..
2025-03-05 09:13:20 -08:00
2025-03-18 16:55:30 -07:00
2024-09-24 11:46:46 -07:00
2024-06-26 11:07:42 -07:00
2024-11-09 08:39:14 -08:00
2024-12-18 16:24:33 -03:00
2023-08-16 08:48:06 -03:00
2024-06-26 11:07:42 -07:00
2025-02-12 20:06:11 -08:00
2025-02-17 22:00:50 -08:00
2025-02-18 14:04:32 -08:00
2022-12-05 09:29:06 -03:00
2023-08-23 08:41:52 -03:00
2025-03-13 00:19:51 -07:00
2025-03-13 00:19:51 -07:00
2025-03-13 00:19:51 -07:00
2025-03-13 00:19:51 -07:00
2025-02-12 20:06:11 -08:00
2022-10-27 16:37:26 -03:00
2025-03-05 09:13:20 -08:00
2024-10-03 15:23:09 -07:00
2025-02-12 20:06:11 -08:00
2024-12-18 16:24:32 -03:00
2024-08-14 10:20:40 -03:00
2024-08-14 10:20:40 -03:00
2023-11-09 13:49:33 -03:00
2024-09-03 11:43:16 -03:00
2024-11-01 23:31:08 -07:00
2023-01-10 10:51:39 -03:00
2025-03-13 00:18:10 -07:00
2024-12-18 16:24:33 -03:00
2024-12-18 16:24:33 -03:00
2025-02-28 10:09:02 -08:00
2024-08-21 11:39:51 -03:00
2022-10-27 16:37:26 -03:00
2025-01-14 14:57:19 -03:00
2024-12-10 16:59:32 -03:00
2024-01-03 17:54:54 -03:00
2024-11-22 13:36:00 -08:00
2024-08-01 12:11:33 -03:00
2025-03-24 17:29:58 -07:00
2024-08-28 18:21:49 -03:00
2022-06-28 12:05:25 -03:00
2021-11-01 18:16:40 -03:00
2023-10-25 13:38:50 -07:00
2025-03-05 09:13:19 -08:00
2024-12-09 17:52:41 -03:00
2024-12-09 17:52:41 -03:00
2025-03-24 09:38:20 -07:00
2024-12-02 12:36:20 -08:00
2024-08-12 18:07:10 -03:00
2023-05-28 10:24:14 -03:00
2023-02-16 09:33:45 -03:00
2021-03-23 17:13:43 -03:00
2025-03-07 14:06:56 -08:00
2024-09-10 17:32:47 -03:00
2024-10-28 13:04:52 -03:00
2024-08-20 17:53:12 -03:00
2024-12-18 16:24:33 -03:00
2023-09-12 17:32:00 -03:00
2020-08-06 09:33:57 -03:00
2020-08-06 09:33:57 -03:00
2023-03-14 08:29:46 -03:00
2025-03-10 11:31:24 -07:00
2024-10-10 23:38:33 -07:00
2025-03-10 11:31:24 -07:00
2025-01-31 14:45:19 -08:00
2025-03-10 14:37:02 -07:00
2025-03-10 11:31:24 -07:00
2025-03-10 11:31:24 -07:00
2022-10-27 16:37:25 -03:00
2022-10-27 16:37:25 -03:00
2025-03-19 16:56:33 -07:00
2024-05-07 18:06:44 -03:00
2023-12-12 14:55:13 -03:00
2023-02-19 08:03:12 -03:00
2023-04-04 09:39:56 -03:00
2025-02-12 20:06:11 -08:00
2024-08-29 15:55:24 -03:00
2024-12-09 17:52:42 -03:00
2024-12-09 17:52:42 -03:00
2021-04-29 10:30:58 -03:00
2025-03-10 11:31:24 -07:00
2025-03-10 11:31:24 -07:00
2024-05-06 15:28:49 -03:00
2021-05-25 10:07:17 -03:00
2025-03-11 18:55:37 -07:00
2024-03-21 10:41:28 -03:00
2025-02-12 19:44:16 -08:00
2024-10-18 10:17:40 -07:00
2023-03-20 12:49:58 -03:00
2023-03-14 08:29:46 -03:00
2021-03-23 17:13:43 -03:00
2021-03-30 12:45:59 -03:00
2021-02-17 15:15:06 -03:00
2024-08-01 18:54:19 -03:00
2024-08-01 18:54:19 -03:00
2025-03-06 16:52:24 -08:00
2024-11-09 08:39:13 -08:00
2024-12-18 16:24:32 -03:00
2021-08-11 09:35:44 -03:00
2025-03-20 22:58:02 -07:00
2025-03-20 22:58:02 -07:00
2024-08-19 14:52:13 -03:00
2024-08-19 14:52:13 -03:00
2024-09-03 12:22:01 -03:00
2024-09-03 12:22:01 -03:00
2024-10-18 10:17:40 -07:00
2024-10-18 10:17:40 -07:00
2024-11-09 08:39:13 -08:00
2024-11-09 08:39:13 -08:00
2024-11-09 08:39:13 -08:00
2024-11-09 08:39:14 -08:00
2025-02-27 08:47:25 -08:00
2024-12-18 16:24:33 -03:00
2025-02-18 14:04:32 -08:00
2025-03-13 13:19:27 -07:00
2025-02-18 14:04:32 -08:00
2025-03-19 16:56:33 -07:00
2025-03-02 09:47:24 -08:00
2024-12-18 16:24:32 -03:00
2024-12-09 17:52:42 -03:00
2023-05-12 15:21:49 -03:00
2025-04-11 09:22:49 -07:00
2025-02-04 21:29:13 -08:00
2020-11-30 09:48:07 -03:00
2023-01-23 10:00:47 -03:00
2025-02-10 11:46:30 -08:00
2023-08-17 14:12:14 -03:00
2024-02-13 13:47:08 -08:00
2023-09-12 17:46:50 -03:00
2025-02-26 13:48:02 -08:00
2023-06-20 22:18:58 -07:00
2024-10-18 10:17:40 -07:00
2024-10-18 10:17:40 -07:00
2025-01-10 10:59:42 -03:00
2021-08-30 10:06:16 -03:00
2022-11-09 20:45:14 -08:00
2024-10-14 12:04:31 -07:00
2025-03-24 16:22:06 -07:00
2024-11-16 16:40:30 -03:00
2024-03-21 13:54:40 -03:00
2024-08-12 18:05:14 -03:00
2022-10-15 10:13:16 -03:00
2025-03-07 14:07:07 -08:00
2025-02-18 14:04:32 -08:00
2025-02-24 15:46:33 -08:00
2025-02-04 17:22:40 -08:00
2025-02-12 20:06:11 -08:00
2025-02-12 20:06:11 -08:00
2023-10-17 12:40:50 -07:00
2025-03-19 16:56:56 -07:00
2024-08-13 15:24:48 -03:00
2021-02-08 17:02:00 -03:00
2021-02-08 17:02:00 -03:00
2022-11-24 09:40:37 -03:00
2022-11-24 09:40:37 -03:00
2024-08-19 14:51:46 -03:00
2025-02-12 20:06:11 -08:00
2024-12-18 16:24:32 -03:00
2024-12-18 16:24:32 -03:00
2024-12-18 16:24:33 -03:00
2021-03-23 17:13:43 -03:00
2025-01-08 17:38:32 -03:00
2024-09-03 10:39:20 -03:00
2024-12-18 16:24:33 -03:00
2025-02-28 10:09:02 -08:00
2025-03-10 14:37:02 -07:00
2025-03-06 16:00:25 -08:00
2025-02-17 22:00:50 -08:00
2024-08-01 18:55:55 -03:00
2024-08-01 18:55:55 -03:00
2024-09-10 17:32:47 -03:00
2024-09-10 17:32:47 -03:00
2025-03-05 23:03:43 -08:00
2024-02-12 12:35:41 -08:00
2020-11-04 09:42:40 -03:00
2025-03-19 16:56:33 -07:00
2025-03-10 14:26:45 -07:00
2024-08-01 18:55:55 -03:00
2024-08-01 18:55:55 -03:00
2024-10-10 23:40:32 -07:00
2024-04-18 22:22:51 -03:00
2025-03-19 16:56:33 -07:00
2025-02-10 11:46:02 -08:00
2022-10-04 08:55:20 -03:00
2025-03-17 22:07:18 -07:00
2025-01-08 17:31:06 -03:00
2025-01-08 17:31:06 -03:00
2022-06-28 11:45:45 -03:00
2023-04-06 21:41:00 -03:00
2022-07-20 11:07:30 -03:00
2023-11-09 13:47:50 -03:00
2025-03-11 19:00:50 -07:00
2024-12-18 16:24:32 -03:00
2025-02-20 22:35:10 -08:00
2024-10-10 23:40:32 -07:00
2024-02-15 13:48:36 -08:00
2020-08-14 09:15:47 -03:00
2021-08-24 15:01:31 -03:00
2024-12-23 13:53:08 -03:00
2024-12-23 13:53:08 -03:00
2023-12-12 14:55:13 -03:00
2021-06-01 10:32:00 -03:00
2025-03-11 19:00:50 -07:00
2024-02-15 13:48:36 -08:00
2024-02-15 13:48:36 -08:00
2023-01-02 12:34:06 -03:00
2024-11-13 16:27:35 -03:00
2022-11-24 10:04:52 -03:00
2025-03-19 16:56:33 -07:00
2025-02-26 16:23:47 -08:00
2023-04-06 21:40:28 -03:00
2023-09-12 17:47:00 -03:00
2025-03-19 17:00:16 -07:00
2025-03-10 11:31:24 -07:00
2020-10-01 12:10:56 -03:00
2024-07-31 16:12:59 -03:00
2024-07-31 16:12:59 -03:00
2024-10-10 23:40:32 -07:00
2024-10-10 23:40:32 -07:00
2025-01-14 14:57:19 -03:00
2024-12-10 15:41:10 -03:00
2024-11-16 17:07:31 -03:00
2024-11-16 17:07:31 -03:00
2025-02-26 14:25:14 -08:00
2025-02-26 14:25:14 -08:00
2025-03-10 11:31:24 -07:00
2025-03-10 11:31:24 -07:00
2025-03-18 16:08:45 -07:00
2024-03-21 10:41:28 -03:00
2023-03-13 14:52:14 -03:00
2023-10-25 10:02:11 -07:00
2023-10-25 10:02:11 -07:00
2023-10-25 13:35:35 -07:00
2023-10-25 13:35:35 -07:00
2023-11-15 12:51:53 -05:00
2025-02-12 20:06:11 -08:00
2024-10-17 12:44:26 -07:00
2021-09-10 18:15:21 -03:00
2021-09-10 18:15:21 -03:00
2025-02-12 20:06:11 -08:00
2025-02-18 14:04:32 -08:00
2025-02-17 22:00:50 -08:00
2025-02-17 22:00:50 -08:00
2025-03-24 09:38:20 -07:00
2023-06-20 17:03:43 -07:00
2023-06-20 17:03:43 -07:00
2022-04-01 16:19:35 -03:00
2023-02-19 08:03:12 -03:00
2023-02-19 08:03:12 -03:00
2025-03-20 09:17:56 -07:00
2025-02-18 14:04:32 -08:00
2021-06-08 09:36:36 -03:00
2024-09-03 10:15:16 -03:00
2023-06-14 18:19:06 -03:00
2025-03-03 12:48:17 -08:00
2025-01-29 14:06:25 -08:00
2025-02-04 21:29:05 -08:00
2024-12-18 16:24:32 -03:00
2021-03-23 17:13:43 -03:00
2024-12-23 13:53:08 -03:00
2024-12-23 13:53:08 -03:00
2023-04-06 21:41:00 -03:00
2021-03-23 17:13:43 -03:00
2024-11-14 16:56:32 -03:00
2024-12-12 15:53:36 -03:00
2024-12-09 17:52:41 -03:00
2025-02-18 14:04:32 -08:00
2024-05-06 15:28:49 -03:00
2025-03-20 22:58:02 -07:00
2024-05-06 15:28:49 -03:00
2025-03-10 14:37:06 -07:00
2024-05-07 18:06:44 -03:00
2023-02-01 21:51:51 -03:00
2025-02-24 15:46:33 -08:00
2024-09-10 17:32:47 -03:00
2025-03-20 22:58:23 -07:00
2025-03-20 22:57:57 -07:00
2021-01-20 14:25:28 -03:00
2024-11-01 23:31:08 -07:00
2024-02-22 09:11:03 -08:00
2022-11-16 12:17:15 -03:00
2023-08-14 11:46:51 +02:00
2021-03-25 08:59:10 -03:00
2025-03-20 22:58:05 -07:00
2025-03-20 22:58:05 -07:00
2024-10-14 12:04:31 -07:00
2024-03-03 22:52:13 -08:00
2024-09-03 11:21:55 -03:00
2025-03-19 17:00:16 -07:00
2025-02-26 16:23:47 -08:00
2024-08-12 18:13:58 -03:00
2024-08-12 18:13:58 -03:00
2023-12-18 21:34:39 -03:00
2023-12-07 16:47:55 -03:00
2023-02-19 08:07:24 -03:00
2023-02-19 08:07:24 -03:00
2024-09-10 09:52:13 -03:00
2023-10-12 10:01:57 -07:00
2024-12-09 17:52:42 -03:00
2024-11-08 22:42:57 -08:00
2025-03-13 13:19:27 -07:00
2024-11-08 22:42:57 -08:00
2025-03-05 09:13:19 -08:00
2024-05-09 18:46:43 -03:00
2024-05-09 18:46:43 -03:00
2024-11-13 16:27:35 -03:00
2024-10-10 23:40:32 -07:00
2025-03-13 00:30:08 -07:00
2021-03-15 11:36:54 -03:00
2025-02-12 20:06:11 -08:00
2022-04-09 12:34:29 -03:00
2025-04-10 17:51:31 -07:00
2024-05-06 15:28:49 -03:00
2023-08-16 08:48:06 -03:00
2023-04-10 19:20:53 -03:00
2024-11-16 16:30:39 -03:00
2024-11-16 16:30:39 -03:00
2024-12-23 13:53:08 -03:00
2024-12-23 13:53:08 -03:00
2024-09-27 15:38:52 -03:00
2023-11-28 14:25:06 -03:00