Daniel Borkmann f2be94d24f bpf, sockmap: fix bpf_tcp_sendmsg sock error handling ...

commit 5121700b34 upstream.

While working on bpf_tcp_sendmsg() code, I noticed that when a
sk->sk_err is set we error out with err = sk->sk_err. However
this is problematic since sk->sk_err is a positive error value
and therefore we will neither go into sk_stream_error() nor will
we report an error back to user space. I had this case with EPIPE
and user space was thinking sendmsg() succeeded since EPIPE is
a positive value, thinking we submitted 32 bytes. Fix it by
negating the sk->sk_err value.

Fixes: 4f738adba3 ("bpf: create tcp_bpf_ulp allowing BPF to monitor socket TX/RX data")
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
Acked-by: John Fastabend <john.fastabend@gmail.com>
Signed-off-by: Alexei Starovoitov <ast@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

2018-08-15 18:10:57 +02:00

..

arraymap.c

bpf: sockmap, map_release does not hold refcnt for pinned maps

2018-04-24 00:49:45 +02:00

bpf_lru_list.c

bpf: lru: Lower the PERCPU_NR_SCANS from 16 to 4

2017-04-17 13:55:52 -04:00

bpf_lru_list.h

bpf: Only set node->ref = 1 if it has not been set

2017-09-01 09:57:39 -07:00

cgroup.c

bpf: Hooks for sys_bind

2018-03-31 02:15:18 +02:00

core.c

bpf: undo prog rejection on read-only lock failure

2018-07-22 15:16:09 +02:00

cpumap.c

bpf: cpumap: use GFP_KERNEL instead of GFP_ATOMIC in __cpu_map_entry_alloc()

2018-02-14 15:34:27 +01:00

devmap.c

bpf: add helper for copying attrs to struct bpf_map

2018-01-14 23:36:29 +01:00

disasm.c

bpf: Remove struct bpf_verifier_env argument from print_bpf_insn

2018-03-23 17:38:57 +01:00

disasm.h

bpf: Remove struct bpf_verifier_env argument from print_bpf_insn

2018-03-23 17:38:57 +01:00

hashtab.c

bpf: add helper for copying attrs to struct bpf_map

2018-01-14 23:36:29 +01:00

helpers.c

bpf: rename ARG_PTR_TO_STACK

2017-01-09 16:56:27 -05:00

inode.c

bpf: comment why dots in filenames under BPF virtual FS are not allowed

2018-03-09 10:30:30 +01:00

lpm_trie.c

bpf: fix rcu lockdep warning for lpm_trie map_free callback

2018-02-22 21:29:12 +01:00

Makefile

bpf: only build sockmap with CONFIG_INET

2018-01-04 19:01:14 +01:00

map_in_map.c

bpf: Add syscall lookup support for fd array and htab

2017-06-29 13:13:25 -04:00

map_in_map.h

bpf: Add syscall lookup support for fd array and htab

2017-06-29 13:13:25 -04:00

offload.c

bpf: offload: report device information about offloaded maps

2018-01-18 22:54:25 +01:00

percpu_freelist.c

bpf: fix lockdep splat

2017-11-15 19:46:32 +09:00

percpu_freelist.h

bpf: introduce percpu_freelist

2016-03-08 15:28:31 -05:00

sockmap.c

bpf, sockmap: fix bpf_tcp_sendmsg sock error handling

2018-08-15 18:10:57 +02:00

stackmap.c

bpf: extend stackmap to save binary_build_id+offset instead of address

2018-03-15 01:09:28 +01:00

syscall.c

bpf: fix multi-function JITed dump obtained via syscall

2018-08-03 07:47:46 +02:00

tnum.c

bpf/verifier: track signed and unsigned min/max values

2017-08-08 17:51:34 -07:00

verifier.c

bpf: fix references to free_bpf_prog_info() in comments

2018-08-03 07:47:55 +02:00