Will Deacon dc492842b7 ARC: atomics: unbork atomic_fetch_##op() ...

[ Upstream commit 3fcbb8260a ]

In 4.19-rc1, Eugeniy reported weird boot and IO errors on ARC HSDK

| INFO: task syslogd:77 blocked for more than 10 seconds.
|       Not tainted 4.19.0-rc1-00007-gf213acea4e88 #40
| "echo 0 > /proc/sys/kernel/hung_task_timeout_secs" disables this
| message.
| syslogd         D    0    77     76 0x00000000
|
| Stack Trace:
|  __switch_to+0x0/0xac
|  __schedule+0x1b2/0x730
|  io_schedule+0x5c/0xc0
|  __lock_page+0x98/0xdc
|  find_lock_entry+0x38/0x100
|  shmem_getpage_gfp.isra.3+0x82/0xbfc
|  shmem_fault+0x46/0x138
|  handle_mm_fault+0x5bc/0x924
|  do_page_fault+0x100/0x2b8
|  ret_from_exception+0x0/0x8

He bisected to 84c6591103 ("locking/atomics,
asm-generic/bitops/lock.h: Rewrite using atomic_fetch_*()")

This commit however only unmasked the real issue introduced by commit
4aef66c8ae ("locking/atomic, arch/arc: Fix build") which missed the
retry-if-scond-failed branch in atomic_fetch_##op() macros.

The bisected commit started using atomic_fetch_##op() macros for building
the rest of atomics.

Fixes: 4aef66c8ae ("locking/atomic, arch/arc: Fix build")
Reported-by: Eugeniy Paltsev <paltsev@synopsys.com>
Acked-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Signed-off-by: Will Deacon <will.deacon@arm.com>
Signed-off-by: Vineet Gupta <vgupta@synopsys.com>
[vgupta: wrote changelog]
Signed-off-by: Sasha Levin <alexander.levin@microsoft.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

2018-10-10 08:54:20 +02:00

..

arcregs.h

ARCv2: boot log: identify HS48 cores (dual issue)

2017-10-03 20:36:49 -07:00

asm-offsets.h

ARC: Generic Headers

2013-01-28 12:34:21 +05:30

atomic.h

ARC: atomics: unbork atomic_fetch_##op()

2018-10-10 08:54:20 +02:00

barrier.h

ARC: [plat-eznps] Use dedicated SMP barriers

2016-05-09 09:32:33 +05:30

bitops.h

ARC: [plat-eznps] Use dedicated atomic/bitops/cmpxchg

2016-05-09 09:32:33 +05:30

bug.h

bug.h: work around GCC PR82365 in BUG()

2018-05-30 07:52:00 +02:00

cache.h

ARC: dma [non-IOC] setup SMP_CACHE_BYTES and cache_line_size

2018-09-05 09:26:30 +02:00

cacheflush.h

ARC: mm: arc700: Don't assume 2 colours for aliasing VIPT dcache

2016-12-19 11:55:17 -08:00

checksum.h

ipv4: Update parameters for csum_tcpudp_magic to their original types

2016-03-13 23:55:13 -04:00

cmpxchg.h

ARC: [plat-eznps] Use dedicated atomic/bitops/cmpxchg

2016-05-09 09:32:33 +05:30

current.h

ARC: remove extraneous __KERNEL__ guards

2014-10-13 14:46:20 +05:30

delay.h

arc: fix build errors in arc/include/asm/delay.h

2018-09-05 09:26:31 +02:00

disasm.h

ARC: disassembly (needed by kprobes/kgdb/unaligned-access-emul)

2013-02-15 23:16:04 +05:30

dma-mapping.h

treewide: Consolidate get_dma_ops() implementations

2017-01-24 12:23:35 -05:00

dma.h

ARC: Add PCI support

2016-03-10 14:44:13 -06:00

dwarf.h

ARC: dw2 unwind: add infrastructure for adding cfi pseudo ops to asm

2016-09-30 14:48:22 -07:00

elf.h

ARC: fix build warning in elf.h

2016-10-19 14:38:53 -07:00

entry-arcv2.h

License cleanup: add SPDX GPL-2.0 license identifier to files with no license

2017-11-02 11:10:55 +01:00

entry-compact.h

ARC: [plat-eznps] handle extra aux regs #2: kernel/entry exit

2017-08-28 15:17:36 -07:00

entry.h

ARC: use correct offset in pt_regs for saving/restoring user mode r25

2016-08-19 10:44:13 -07:00

exec.h

ARC: Fundamental ARCH data-types/defines

2013-02-11 20:00:34 +05:30

fb.h

License cleanup: add SPDX GPL-2.0 license identifier to files with no license

2017-11-02 11:10:55 +01:00

futex.h

futex: Remove duplicated code and fix undefined behaviour

2017-08-25 22:49:59 +02:00

highmem.h

ARC: mm: HIGHMEM: kmap API implementation

2015-10-28 19:49:04 +05:30

hugepage.h

arch, mm: convert all architectures to use 5level-fixup.h

2017-03-09 11:48:47 -08:00

io.h

ARC: Add missing io barriers to io{read,write}{16,32}be()

2016-05-05 16:35:28 +05:30

irq.h

ARCv2: intc: Use runtime value of irq count for setting up intc

2017-02-06 09:37:57 -08:00

irqflags-arcv2.h

ARC: create cpu specific version of arch_cpu_idle()

2017-08-28 15:17:36 -07:00

irqflags-compact.h

ARC: create cpu specific version of arch_cpu_idle()

2017-08-28 15:17:36 -07:00

irqflags.h

ARCv2: Support for ARCv2 ISA and HS38x cores

2015-06-22 14:06:55 +05:30

Kbuild

License cleanup: add SPDX GPL-2.0 license identifier to files with no license

2017-11-02 11:10:55 +01:00

kdebug.h

ARC: Fundamental ARCH data-types/defines

2013-02-11 20:00:34 +05:30

kgdb.h

ARC: Update order of registers in KGDB to match GDB 7.5

2014-10-13 14:46:20 +05:30

kmap_types.h

ARC: mm: HIGHMEM: kmap API implementation

2015-10-28 19:49:04 +05:30

kprobes.h

ARC: fix build warnings with !CONFIG_KPROBES

2017-03-30 17:33:20 -07:00

linkage.h

ARC: dw2 unwind: add infrastructure for adding cfi pseudo ops to asm

2016-09-30 14:48:22 -07:00

mach_desc.h

ARC: Enable machine_desc->init_per_cpu for !CONFIG_SMP

2018-08-24 13:09:03 +02:00

mmu_context.h

sched/headers: Prepare for new header dependencies before moving code to <linux/sched/mm.h>

2017-03-02 08:42:28 +01:00

mmu.h

ARCv2: PAE40: set MSB even if !CONFIG_ARC_HAS_PAE40 but PAE exists in SoC

2017-08-04 13:56:35 +05:30

mmzone.h

ARC: support HIGHMEM even without PAE40

2016-05-05 16:35:46 +05:30

module.h

ARC: module: Fix !CONFIG_ARC_DW2_UNWIND builds

2017-01-18 11:17:44 -08:00

page.h

ARC: mm: allow mprotect to make stack mappings executable

2018-07-25 11:25:08 +02:00

pci.h

ARC: Add PCI support

2016-03-10 14:44:13 -06:00

perf_event.h

arc: perf: Enable generic "cache-references" and "cache-misses" events

2016-09-30 14:48:18 -07:00

pgalloc.h

arc: get rid of superfluous __GFP_REPEAT

2016-06-24 17:23:52 -07:00

pgtable.h

ARC: Fix CONFIG_SWAP

2018-07-25 11:25:07 +02:00

processor.h

arch: remove unused *_segments() macros/functions

2017-09-22 12:59:52 -10:00

ptrace.h

ARC: [plat-eznps] handle extra aux regs #2: kernel/entry exit

2017-08-28 15:17:36 -07:00

sections.h

of/fdt: consolidate built-in dtb section variables

2014-04-30 00:59:13 -05:00

segment.h

ARC: uaccess friends

2013-02-11 20:00:31 +05:30

serial.h

ARC: Dynamically determine BASE_BAUD from DeviceTree

2015-02-02 17:08:37 +05:30

setup.h

ARCv2: IOC: Use actual memory size to setup aperture size

2017-01-18 14:52:43 -08:00

shmparam.h

ARC: [mm] Aliasing VIPT dcache support 4/4

2013-05-09 22:00:57 +05:30

smp.h

ARC: IRQ: Do not use hwirq as virq and vice versa

2016-11-08 12:05:10 -08:00

spinlock_types.h

ARC: LLOCK/SCOND based rwlock

2015-08-04 09:26:33 +05:30

spinlock.h

Merge tag 'arc-4.14-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/vgupta/arc

2017-09-08 16:02:18 -07:00

stacktrace.h

ARC: Make arc_unwind_core accessible externally

2015-02-27 10:15:00 +05:30

string.h

ARC: remove extraneous __KERNEL__ guards

2014-10-13 14:46:20 +05:30

switch_to.h

ARC: [plat-eznps] handle extra aux regs #1: save/restore on context switch

2017-08-28 15:17:36 -07:00

syscall.h

ARC: stop using pt_regs->orig_r8

2013-06-22 19:23:26 +05:30

syscalls.h

ARC: syscall for userspace cmpxchg assist

2016-10-24 09:24:26 -07:00

thread_info.h

Fix typos

2016-05-30 10:07:32 +05:30

timex.h

ARC: Timers/counters/delay management

2013-02-11 20:00:39 +05:30

tlb-mmu1.h

ARC: Disintegrate arcregs.h

2013-06-22 13:46:42 +05:30

tlb.h

ARC: Disintegrate arcregs.h

2013-06-22 13:46:42 +05:30

tlbflush.h

ARC: thp: unbork !CONFIG_TRANSPARENT_HUGEPAGE build

2016-03-17 15:31:45 +05:30

uaccess.h

ARC: uaccess: dont use "l" gcc inline asm constraint modifier

2018-01-10 09:31:21 +01:00

unaligned.h

ARC: rename kconfig option for unaligned emulation

2014-10-13 14:46:15 +05:30

unwind.h

ARC: dw2 unwind: Reinstante unwinding out of modules

2015-12-17 11:10:23 +05:30