Dan Carpenter 634fae934e nfsd: fix double fget() bug in __write_ports_addfd() ...

[ Upstream commit c034203b6a ]

The bug here is that you cannot rely on getting the same socket
from multiple calls to fget() because userspace can influence
that.  This is a kind of double fetch bug.

The fix is to delete the svc_alien_sock() function and instead do
the checking inside the svc_addsock() function.

Fixes: 3064639423 ("nfsd: check passed socket's net matches NFSd superblock's one")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: NeilBrown <neilb@suse.com>
Reviewed-by: Jeff Layton <jlayton@kernel.org>
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>

2023-06-09 10:47:54 +02:00

..

acl.h

NFSD: add posix ACLs to struct nfsd_attrs

2022-08-04 10:28:03 -04:00

auth.c

…

auth.h

…

blocklayout.c

nfsd: call op_release, even when op_func returns an error

2023-03-31 17:29:49 -04:00

blocklayoutxdr.c

nfsd: move nfserrno() to vfs.c

2022-11-28 12:54:44 -05:00

blocklayoutxdr.h

…

cache.h

nfsd: use DEFINE_SHOW_ATTRIBUTE to define nfsd_reply_cache_stats_fops

2022-09-26 14:02:50 -04:00

current_stateid.h

…

export.c

fs: add is_idmapped_mnt() helper

2021-12-03 18:44:06 +01:00

export.h

nfsd: move nfserrno() to vfs.c

2022-11-28 12:54:44 -05:00

filecache.c

nfsd: don't fsync nfsd_files on last close

2023-02-20 09:20:59 -05:00

filecache.h

nfsd: fix handling of cached open files in nfsd4_open codepath

2023-01-06 13:17:06 -05:00

flexfilelayout.c

nfsd: move nfserrno() to vfs.c

2022-11-28 12:54:44 -05:00

flexfilelayoutxdr.c

…

flexfilelayoutxdr.h

…

idmap.h

…

Kconfig

NFS & NFSD: Update GSS dependencies

2023-03-10 09:38:47 -05:00

lockd.c

NFSD: simplify struct nfsfh

2021-10-02 15:51:10 -04:00

Makefile

nfsd: allow disabling NFSv2 at compile time

2022-11-28 12:54:45 -05:00

netns.h

Merge tag 'locks-v6.3' of git://git.kernel.org/pub/scm/linux/kernel/git/jlayton/linux

2023-02-20 11:10:38 -08:00

nfs2acl.c

Merge tag 'nfsd-6.3' of git://git.kernel.org/pub/scm/linux/kernel/git/cel/linux

2023-02-22 14:21:40 -08:00

nfs3acl.c

Merge tag 'nfsd-6.3' of git://git.kernel.org/pub/scm/linux/kernel/git/cel/linux

2023-02-22 14:21:40 -08:00

nfs3proc.c

Merge tag 'nfsd-6.3' of git://git.kernel.org/pub/scm/linux/kernel/git/cel/linux

2023-02-22 14:21:40 -08:00

nfs3xdr.c

NFSD: Clean up WRITE arg decoders

2022-09-26 14:02:47 -04:00

nfs4acl.c

fs: rename current get acl method

2022-10-20 10:13:27 +02:00

nfs4callback.c

NFSD: callback request does not use correct credential for AUTH_SYS

2023-04-04 09:55:27 -04:00

nfs4idmap.c

nfsd: move nfserrno() to vfs.c

2022-11-28 12:54:44 -05:00

nfs4layouts.c

nfsd: fix race to check ls_layouts

2023-02-20 09:20:56 -05:00

nfs4proc.c

NFSD: fix problems with cleanup on errors in nfsd4_copy

2023-02-20 09:20:57 -05:00

nfs4recover.c

fs: port vfs_*() helpers to struct mnt_idmap

2023-01-18 17:51:45 +01:00

nfs4state.c

Merge tag 'nfsd-6.3' of git://git.kernel.org/pub/scm/linux/kernel/git/cel/linux

2023-02-22 14:21:40 -08:00

nfs4xdr.c

Merge tag 'nfsd-6.3-5' of git://git.kernel.org/pub/scm/linux/kernel/git/cel/linux

2023-04-04 11:20:55 -07:00

nfscache.c

SUNRPC: Refactor RPC server dispatch method

2023-02-20 09:20:31 -05:00

nfsctl.c

nfsd: fix double fget() bug in __write_ports_addfd()

2023-06-09 10:47:54 +02:00

nfsd.h

SUNRPC: Refactor RPC server dispatch method

2023-02-20 09:20:31 -05:00

nfsfh.c

Merge tag 'fs.idmapped.v6.3' of git://git.kernel.org/pub/scm/linux/kernel/git/vfs/idmapping

2023-02-20 11:53:11 -08:00

nfsfh.h

nfsd: move nfsd4_change_attribute to nfsfh.c

2023-01-26 07:00:06 -05:00

nfsproc.c

Merge tag 'nfsd-6.3' of git://git.kernel.org/pub/scm/linux/kernel/git/cel/linux

2023-02-22 14:21:40 -08:00

nfssvc.c

NFSD: copy the whole verifier in nfsd_copy_write_verifier

2023-02-20 09:20:59 -05:00

nfsxdr.c

NFSD: Clean up WRITE arg decoders

2022-09-26 14:02:47 -04:00

pnfs.h

…

state.h

nfsd: don't take nfsd4_copy ref for OP_OFFLOAD_STATUS

2023-02-20 09:20:51 -05:00

stats.c

nfsd: use DEFINE_PROC_SHOW_ATTRIBUTE to define nfsd_proc_ops

2022-09-26 14:02:49 -04:00

stats.h

nfsd: make nfsd_stats.th_cnt atomic_t

2021-12-13 13:42:51 -05:00

trace.c

NFSD: Add SPDX header for fs/nfsd/trace.c

2020-11-30 13:00:24 -05:00

trace.h

nfsd: don't fsync nfsd_files on last close

2023-02-20 09:20:59 -05:00

vfs.c

nfsd: make a copy of struct iattr before calling notify_change

2023-06-09 10:47:48 +02:00

vfs.h

nfsd: use the getattr operation to fetch i_version

2023-01-26 07:00:06 -05:00

xdr3.h

SUNRPC: Change return value type of .pc_encode

2021-10-13 11:34:49 -04:00

xdr4.h

NFSD: enhance inter-server copy cleanup

2023-02-20 09:20:21 -05:00

xdr4cb.h

NFSD: add support for sending CB_RECALL_ANY

2022-12-10 11:01:12 -05:00

xdr.h

NFSD: prevent underflow in nfssvc_decode_writeargs()

2022-03-15 09:35:56 -04:00