Parthasarathy Bhuvaragan afa485dc6f tipc: fix hanging clients using poll with EPOLLOUT flag ...

[ Upstream commit ff946833b7 ]

commit 517d7c79bd ("tipc: fix hanging poll() for stream sockets")
introduced a regression for clients using non-blocking sockets.
After the commit, we send EPOLLOUT event to the client even in
TIPC_CONNECTING state. This causes the subsequent send() to fail
with ENOTCONN, as the socket is still not in TIPC_ESTABLISHED state.

In this commit, we:
- improve the fix for hanging poll() by replacing sk_data_ready()
  with sk_state_change() to wake up all clients.
- revert the faulty updates introduced by commit 517d7c79bd
  ("tipc: fix hanging poll() for stream sockets").

Fixes: 517d7c79bd ("tipc: fix hanging poll() for stream sockets")
Signed-off-by: Parthasarathy Bhuvaragan <parthasarathy.bhuvaragan@gmail.com>
Acked-by: Jon Maloy <jon.maloy@ericsson.se>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

2019-05-16 19:41:31 +02:00

..

addr.c

tipc: handle collisions of 32-bit node address hash values

2018-03-23 13:12:18 -04:00

addr.h

tipc: add 128-bit node identifier

2018-03-23 13:12:18 -04:00

bcast.c

tipc: correct spelling errors for struct tipc_bc_base's comment

2018-09-03 22:03:07 -07:00

bcast.h

tipc: make replicast a user selectable option

2017-01-20 12:10:17 -05:00

bearer.c

tipc: fix a double free in tipc_enable_bearer()

2019-01-09 17:38:34 +01:00

bearer.h

tipc: implement configuration of UDP media MTU

2018-04-20 11:04:05 -04:00

core.c

net: Drop pernet_operations::async

2018-03-27 13:18:09 -04:00

core.h

tipc: replace name table service range array with rb tree

2018-03-31 22:19:52 -04:00

diag.c

tipc: switch to rhashtable iterator

2018-08-29 18:04:54 -07:00

discover.c

tipc: fix lockdep warning when reinitilaizing sockets

2018-11-23 08:17:03 +01:00

discover.h

tipc: some cleanups in the file discover.c

2018-03-23 13:12:17 -04:00

eth_media.c

tipc: make media address offset a common define

2015-02-27 18:18:48 -05:00

group.c

tipc: fix info leak from kernel tipc_event

2018-10-18 16:49:53 -07:00

group.h

tipc: extend sock diag for group communication

2018-06-30 21:05:42 +09:00

ib_media.c

tipc: rename media/msg related definitions

2015-02-27 18:18:48 -05:00

Kconfig

tipc: implement socket diagnostics for AF_TIPC

2018-03-22 14:43:35 -04:00

link.c

tipc: fix link re-establish failure

2018-11-23 08:17:04 +01:00

link.h

tipc: fix failover problem

2018-09-29 11:45:14 -07:00

Makefile

tipc: implement socket diagnostics for AF_TIPC

2018-03-22 14:43:35 -04:00

monitor.c

tipc: make some functions static

2018-07-21 16:23:22 -07:00

monitor.h

tipc: dump monitor attributes

2016-07-26 14:26:42 -07:00

msg.c

tipc: eliminate buffer cloning in function tipc_msg_extract()

2018-06-30 20:48:16 +09:00

msg.h

tipc: handle collisions of 32-bit node address hash values

2018-03-23 13:12:18 -04:00

name_distr.c

tipc: fix unsafe rcu locking when accessing publication list

2018-10-15 22:33:27 -07:00

name_distr.h

tipc: permit overlapping service ranges in name table

2018-03-31 22:19:52 -04:00

name_table.c

tipc: missing entries in name table of publications

2019-04-27 09:36:31 +02:00

name_table.h

tipc: fix the big/little endian issue in tipc_dest

2018-08-27 15:23:31 -07:00

net.c

tipc: change to check tipc_own_id to return in tipc_net_stop

2019-04-03 06:26:18 +02:00

net.h

tipc: fix lockdep warning when reinitilaizing sockets

2018-11-23 08:17:03 +01:00

netlink_compat.c

tipc: check link name with right length in tipc_nl_compat_link_set

2019-05-02 09:58:57 +02:00

netlink.c

tipc: switch to rhashtable iterator

2018-08-29 18:04:54 -07:00

netlink.h

tipc: make cluster size threshold for monitoring configurable

2016-07-26 14:26:42 -07:00

node.c

tipc: fix node keep alive interval calculation

2019-02-12 19:47:06 +01:00

node.h

tipc: add sequence number check for link STATE messages

2018-07-11 23:06:14 -07:00

socket.c

tipc: fix hanging clients using poll with EPOLLOUT flag

2019-05-16 19:41:31 +02:00

socket.h

tipc: call start and done ops directly in __tipc_nl_compat_dumpit()

2018-09-06 21:49:18 -07:00

subscr.c

tipc: fix unbalanced reference counter

2018-04-12 21:46:10 -04:00

subscr.h

tipc: replace name table service range array with rb tree

2018-03-31 22:19:52 -04:00

sysctl.c

tipc: add name distributor resiliency queue

2014-09-01 17:51:48 -07:00

topsrv.c

tipc: fix cancellation of topology subscriptions

2019-04-03 06:26:18 +02:00

topsrv.h

tipc: rename tipc_server to tipc_topsrv

2018-02-16 15:26:34 -05:00

udp_media.c

tipc: fix a double kfree_skb()

2019-01-09 17:38:34 +01:00

udp_media.h

tipc: implement configuration of UDP media MTU

2018-04-20 11:04:05 -04:00