Vladimir Oltean 21bdddc964 net: dsa: fix incorrect function pointer check for MRP ring roles ...

[ Upstream commit ff91e1b684 ]

The cross-chip notifier boilerplate code meant to check the presence of
ds->ops->port_mrp_add_ring_role before calling it, but checked
ds->ops->port_mrp_add instead, before calling
ds->ops->port_mrp_add_ring_role.

Therefore, a driver which implements one operation but not the other
would trigger a NULL pointer dereference.

There isn't any such driver in DSA yet, so there is no reason to
backport the change. Issue found through code inspection.

Cc: Horatiu Vultur <horatiu.vultur@microchip.com>
Fixes: c595c4330d ("net: dsa: add MRP support")
Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>

2022-01-27 11:03:50 +01:00

..

dsa2.c

net: dsa: Fix an error handling path in 'dsa_switch_parse_ports_of()'

2021-10-19 15:41:16 -07:00

dsa_priv.h

net: dsa: flush switchdev workqueue before tearing down CPU/DSA ports

2021-09-15 15:09:46 -07:00

dsa.c

net: dsa: flush switchdev workqueue before tearing down CPU/DSA ports

2021-09-15 15:09:46 -07:00

Kconfig

net: dsa: tag_ocelot_8021q: break circular dependency with ocelot switch lib

2021-10-12 17:35:18 -07:00

Makefile

net: dsa: build tag_8021q.c as part of DSA core

2021-07-20 06:36:42 -07:00

master.c

dev_ioctl: split out ndo_eth_ioctl

2021-07-27 20:11:45 +01:00

port.c

net: dsa: don't advertise 'rx-vlan-filter' when not needed

2021-08-24 09:30:58 +01:00

slave.c

net: dsa: destroy the phylink instance on any error in dsa_slave_phy_setup

2021-09-15 15:03:36 -07:00

switch.c

net: dsa: fix incorrect function pointer check for MRP ring roles

2022-01-27 11:03:50 +01:00

tag_8021q.c

net: dsa: tag_8021q: fix notifiers broadcast when they shouldn't, and vice versa

2021-08-16 11:14:18 +01:00

tag_ar9331.c

net: dsa: remove the struct packet_type argument from dsa_device_ops::rcv()

2021-08-02 15:13:15 +01:00

tag_brcm.c

net: dsa: create a helper for locating EtherType DSA headers on RX

2021-08-11 14:44:58 +01:00

tag_dsa.c

net: dsa: mv88e6xxx: isolate the ATU databases of standalone and bridged ports

2021-10-08 15:47:46 -07:00

tag_gswip.c

net: dsa: remove the struct packet_type argument from dsa_device_ops::rcv()

2021-08-02 15:13:15 +01:00

tag_hellcreek.c

net: dsa: remove the struct packet_type argument from dsa_device_ops::rcv()

2021-08-02 15:13:15 +01:00

tag_ksz.c

net: dsa: remove the struct packet_type argument from dsa_device_ops::rcv()

2021-08-02 15:13:15 +01:00

tag_lan9303.c

net: dsa: create a helper for locating EtherType DSA headers on TX

2021-08-11 14:44:58 +01:00

tag_mtk.c

net: dsa: create a helper for locating EtherType DSA headers on TX

2021-08-11 14:44:58 +01:00

tag_ocelot_8021q.c

net: dsa: tag_ocelot_8021q: fix inability to inject STP BPDUs into BLOCKING ports

2021-10-12 17:35:19 -07:00

tag_ocelot.c

net: dsa: felix: fix broken VLAN-tagged PTP under VLAN-aware bridge

2021-11-18 19:17:06 +01:00

tag_qca.c

net: dsa: create a helper for locating EtherType DSA headers on TX

2021-08-11 14:44:58 +01:00

tag_rtl4_a.c

net: dsa: tag_rtl4_a: Fix egress tags

2021-09-01 11:48:05 +01:00

tag_sja1105.c

net: dsa: move sja1110_process_meta_tstamp inside the tagging protocol driver

2021-10-12 17:33:36 -07:00

tag_trailer.c

net: dsa: remove the struct packet_type argument from dsa_device_ops::rcv()

2021-08-02 15:13:15 +01:00

tag_xrs700x.c

net: dsa: remove the struct packet_type argument from dsa_device_ops::rcv()

2021-08-02 15:13:15 +01:00