Marek Szyprowski
2b94f5266c
net: stmmac: Fix channel lock initialization
Commit 0366f7e06a ("net: stmmac: add ethtool support for get/set
channels") refactored channel initialization, but during that operation,
the spinlock initialization got lost. Fix this. This fixes the following
lockdep warning:
meson8b-dwmac ff3f0000.ethernet eth0: Link is Up - 1Gbps/Full - flow control off
INFO: trying to register non-static key.
the code is fine but needs lockdep annotation.
turning off the locking correctness validator.
CPU: 1 PID: 331 Comm: kworker/1:2H Not tainted 5.9.0-rc3+ #1858
Hardware name: Hardkernel ODROID-N2 (DT)
Workqueue: kblockd blk_mq_run_work_fn
Call trace:
dump_backtrace+0x0/0x1d0
show_stack+0x14/0x20
dump_stack+0xe8/0x154
register_lock_class+0x58c/0x590
__lock_acquire+0x7c/0x1790
lock_acquire+0xf4/0x440
_raw_spin_lock_irqsave+0x80/0xb0
stmmac_tx_timer+0x4c/0xb0 [stmmac]
call_timer_fn+0xc4/0x3e8
run_timer_softirq+0x2b8/0x6c0
efi_header_end+0x114/0x5f8
irq_exit+0x104/0x110
__handle_domain_irq+0x60/0xb8
gic_handle_irq+0x58/0xb0
el1_irq+0xbc/0x180
_raw_spin_unlock_irqrestore+0x48/0x90
mmc_blk_rw_wait+0x70/0x160
mmc_blk_mq_issue_rq+0x510/0x830
mmc_mq_queue_rq+0x13c/0x278
blk_mq_dispatch_rq_list+0x2a0/0x698
__blk_mq_do_dispatch_sched+0x254/0x288
__blk_mq_sched_dispatch_requests+0x190/0x1d8
blk_mq_sched_dispatch_requests+0x34/0x70
__blk_mq_run_hw_queue+0xcc/0x148
blk_mq_run_work_fn+0x20/0x28
process_one_work+0x2a8/0x718
worker_thread+0x48/0x460
kthread+0x134/0x160
ret_from_fork+0x10/0x1c
Fixes: 0366f7e06a ("net: stmmac: add ethtool support for get/set channels")
Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
Link: https://lore.kernel.org/r/20201029185011.4749-1-m.szyprowski@samsung.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
2020-10-30 09:51:40 -07:00
..
2020-10-23 16:38:36 -07:00
2020-10-17 15:05:30 -06:00
2020-10-25 10:59:34 -07:00
2020-10-23 16:27:03 -07:00
2020-10-25 10:55:35 -07:00
2020-10-15 18:42:13 -07:00
2020-10-24 10:39:22 -07:00
2020-10-24 20:21:57 +02:00
2020-10-25 14:51:49 -07:00
2020-10-25 14:51:49 -07:00
2020-10-24 10:39:22 -07:00
2020-10-16 12:21:15 -07:00
2020-10-16 12:36:38 -07:00
2020-10-19 14:28:30 -07:00
2020-10-24 10:39:22 -07:00
2020-10-15 14:43:29 -07:00
2020-10-12 13:26:49 -07:00
2020-10-24 10:39:22 -07:00
2020-10-14 15:56:58 -07:00
2020-10-24 10:39:22 -07:00
2020-10-23 16:16:31 -07:00
2020-10-16 11:31:55 -07:00
2020-10-24 10:33:08 -07:00
2020-10-05 12:43:54 +02:00
2020-10-25 13:33:54 +01:00
2020-10-17 11:01:01 -07:00
2020-10-13 12:12:44 -07:00
2020-10-16 17:28:32 +02:00
2020-10-23 10:54:13 -07:00
2020-10-28 09:45:25 -03:00
2020-10-25 10:59:34 -07:00
2020-10-20 09:35:06 -07:00
2020-10-25 14:51:49 -07:00
2020-10-07 12:02:58 +02:00
2020-10-16 09:28:45 -06:00
2020-10-16 12:21:15 -07:00
2020-10-24 10:39:22 -07:00
2020-10-14 15:05:38 -07:00
2020-10-15 14:43:29 -07:00
2020-10-24 10:39:22 -07:00
2020-10-14 15:15:35 -07:00
2020-10-14 15:56:58 -07:00
2020-10-22 12:41:00 -07:00
2020-10-24 10:33:08 -07:00
2020-10-18 09:56:50 -07:00
2020-10-30 09:51:40 -07:00
2020-10-20 10:36:41 -07:00
2020-10-25 11:12:31 -07:00
2020-10-13 18:38:28 -07:00
2020-10-28 09:14:49 -03:00
2020-10-25 20:37:55 -05:00
2020-10-06 12:26:45 +02:00
2020-10-06 07:07:03 +02:00
2020-10-22 13:00:44 -07:00
2020-10-22 12:41:00 -07:00
2020-10-14 15:25:04 -07:00
2020-10-23 16:16:31 -07:00
2020-10-08 18:00:08 +02:00
2020-10-24 10:33:08 -07:00
2020-10-19 17:40:53 +02:00
2020-10-24 10:33:08 -07:00
2020-10-16 11:11:22 -07:00
2020-10-05 16:54:56 +01:00
2020-10-22 12:56:33 -07:00
2020-10-24 10:39:22 -07:00
2020-10-22 12:58:21 -07:00
2020-10-21 11:22:08 -07:00
2020-10-26 16:29:14 -07:00
2020-10-26 15:45:22 -07:00
2020-10-24 10:44:18 -07:00
2020-10-24 10:33:08 -07:00
2020-10-25 11:39:02 -07:00
2020-10-23 16:19:02 -07:00
2020-10-25 14:51:49 -07:00
2020-10-24 10:33:08 -07:00
2020-10-24 10:33:08 -07:00
2020-10-23 11:00:57 -07:00
2020-10-22 13:00:44 -07:00
2020-10-21 10:48:10 -04:00
2020-10-27 14:39:29 -07:00
2020-10-02 11:36:13 +02:00
2020-10-23 11:00:57 -07:00
2020-10-05 14:49:24 +02:00
2020-10-24 10:33:08 -07:00
2020-10-25 10:55:35 -07:00