linux

mirror of https://github.com/raspberrypi/linux.git synced 2025-12-29 13:33:07 +00:00

Files

Tom Rix 53d19f4bb1 video: fbdev: sis: fix null ptr dereference

[ Upstream commit ad6f93e9cd ]

Clang static analysis reports this representative error

init.c:2501:18: warning: Array access (from variable 'queuedata') results
  in a null pointer dereference
      templ |= ((queuedata[i] & 0xc0) << 3);

This is the problem block of code

   if(ModeNo > 0x13) {
      ...
      if(SiS_Pr->ChipType == SIS_730) {
	 queuedata = &FQBQData730[0];
      } else {
	 queuedata = &FQBQData[0];
      }
   } else {

   }

queuedata is not set in the else block

Reviewing the old code, the arrays FQBQData730 and FQBQData were
used directly.

So hoist the setting of queuedata out of the if-else block.

Fixes: 544393fe58 ("[PATCH] sisfb update")
Signed-off-by: Tom Rix <trix@redhat.com>
Cc: Thomas Winischhofer <thomas@winischhofer.net>
Cc: Andrew Morton <akpm@osdl.org>
Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20200805145208.17727-1-trix@redhat.com
Signed-off-by: Sasha Levin <sashal@kernel.org>

2020-10-29 10:07:35 +01:00

300vtbl.h

…

310vtbl.h

…

init301.c

video: fbdev: sis: Remove unnecessary parentheses and commented code

2018-10-08 12:57:36 +02:00

init301.h

video: fbdev: sis: avoid mismatched prototypes

2018-03-12 17:06:52 +01:00

init.c