Colin Ian King 14a296eab6 b43: N-PHY: Fix the update of coef for the PHY revision >= 3case ...

[ Upstream commit 4773acf3d4 ]

The documentation for the PHY update [1] states:

Loop 4 times with index i

    If PHY Revision >= 3
        Copy table[i] to coef[i]
    Otherwise
        Set coef[i] to 0

the copy of the table to coef is currently implemented the wrong way
around, table is being updated from uninitialized values in coeff.
Fix this by swapping the assignment around.

[1] https://bcm-v4.sipsolutions.net/802.11/PHY/N/RestoreCal/

Fixes: 2f258b74d1 ("b43: N-PHY: implement restoring general configuration")
Addresses-Coverity: ("Uninitialized scalar variable")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Acked-by: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>

2021-03-04 11:37:34 +01:00

..

b43.h

…

bus.c

…

bus.h

…

debugfs.c

treewide: Remove uninitialized_var() usage

2020-07-16 12:35:15 -07:00

debugfs.h

…

dma.c

b43: Use fallthrough pseudo-keyword

2020-08-27 16:08:22 +03:00

dma.h

…

Kconfig

treewide: replace '---help---' in Kconfig files with 'help'

2020-06-14 01:57:21 +09:00

leds.c

…

leds.h

…

lo.c

treewide: Remove uninitialized_var() usage

2020-07-16 12:35:15 -07:00

lo.h

…

main.c

b43: Use fallthrough pseudo-keyword

2020-08-27 16:08:22 +03:00

main.h

…

Makefile

…

phy_a.h

…

phy_ac.c

…

phy_ac.h

…

phy_common.c

b43: phy_common: Demote non-conformant kerneldoc header

2020-08-27 15:15:37 +03:00

phy_common.h

…

phy_g.c

b43: Replace HTTP links with HTTPS ones

2020-08-02 18:16:35 +03:00

phy_g.h

…

phy_ht.c

b43: phy_ht: Remove 9 year old TODO

2020-09-01 12:22:38 +03:00

phy_ht.h

…

phy_lcn.c

…

phy_lcn.h

…

phy_lp.c

b43: Replace HTTP links with HTTPS ones

2020-08-02 18:16:35 +03:00

phy_lp.h

…

phy_n.c

b43: N-PHY: Fix the update of coef for the PHY revision >= 3case

2021-03-04 11:37:34 +01:00

phy_n.h

…

pio.c

b43: Use fallthrough pseudo-keyword

2020-08-27 16:08:22 +03:00

pio.h

…

ppr.c

…

ppr.h

…

radio_2055.c

…

radio_2055.h

…

radio_2056.c

b43: Replace HTTP links with HTTPS ones

2020-08-02 18:16:35 +03:00

radio_2056.h

…

radio_2057.c

…

radio_2057.h

…

radio_2059.c

…

radio_2059.h

…

rfkill.c

…

rfkill.h

…

sdio.c

mmc: sdio: Move SDIO IDs from b43-sdio driver to common include file

2020-05-29 12:37:59 +02:00

sdio.h

…

sysfs.c

…

sysfs.h

…

tables_lpphy.c

…

tables_lpphy.h

…

tables_nphy.c

b43: Use fallthrough pseudo-keyword

2020-08-27 16:08:22 +03:00

tables_nphy.h

…

tables_phy_ht.c

…

tables_phy_ht.h

…

tables_phy_lcn.c

…

tables_phy_lcn.h

…

tables.c

…

tables.h

…

wa.c

…

wa.h

…

xmit.c

treewide: Remove uninitialized_var() usage

2020-07-16 12:35:15 -07:00

xmit.h

…