Files
linux/arch/x86/kernel
Ingo Molnar c0a698b744 x86: fix die() to not be preemptible
Andrew "Eagle Eye" Morton noticed that we use raw_local_save_flags()
instead of raw_local_irq_save(flags) in die(). This allows the
preemption of oopsing contexts - which is highly undesirable. It also
causes CONFIG_DEBUG_PREEMPT to complain, as reported by Miles Lane.

this bug was introduced via:

  commit 39743c9ef7
  Author: Andi Kleen <ak@suse.de>
  Date:   Fri Oct 19 20:35:03 2007 +0200

      x86: use raw locks during oopses

-               spin_lock_irqsave(&die.lock, flags);
+               __raw_spin_lock(&die.lock);
+               raw_local_save_flags(flags);

that is not a correct open-coding of spin_lock_irqsave(): both the
ordering is wrong (irqs should be disabled _first_), and the wrong
flags-saving API was used.

Signed-off-by: Ingo Molnar <mingo@elte.hu>
2007-12-21 01:27:19 +01:00
..
2007-10-17 21:19:04 +02:00
2007-12-19 23:20:18 +01:00
2007-10-23 22:37:22 +02:00
2007-10-20 01:13:56 +02:00
2007-10-11 11:17:01 +02:00
2007-10-11 11:17:24 +02:00
2007-10-11 11:17:01 +02:00
2007-10-13 10:01:23 -07:00
2007-10-19 11:53:33 -07:00
2007-10-13 10:01:23 -07:00
2007-10-11 11:17:01 +02:00
2007-10-22 08:13:19 -07:00
2007-10-22 08:13:19 -07:00
2007-10-22 08:13:19 -07:00
2007-10-11 11:17:01 +02:00
2007-10-11 11:17:24 +02:00
2007-12-03 17:17:10 +01:00
2007-10-13 10:01:23 -07:00
2007-10-13 10:01:23 -07:00
2007-10-20 01:13:56 +02:00
2007-10-19 20:35:02 +02:00
2007-10-13 10:01:23 -07:00
2007-10-13 10:01:23 -07:00
2007-10-11 11:17:24 +02:00
2007-12-18 18:05:58 +01:00
2007-12-18 18:05:58 +01:00
2007-10-13 10:01:23 -07:00
2007-10-11 11:17:01 +02:00
2007-10-11 11:17:24 +02:00
2007-10-20 01:13:56 +02:00
2007-10-19 20:35:03 +02:00
2007-10-11 11:17:01 +02:00
2007-10-11 11:17:01 +02:00
2007-10-11 11:17:24 +02:00
2007-10-20 01:13:56 +02:00
2007-12-03 17:17:10 +01:00
2007-12-03 17:17:10 +01:00
2007-10-11 11:17:01 +02:00
2007-10-11 11:17:24 +02:00
2007-10-11 11:17:01 +02:00
2007-10-20 01:13:56 +02:00
2007-10-20 01:25:36 +02:00
2007-12-19 23:20:18 +01:00
2007-10-11 11:17:01 +02:00
2007-10-11 11:17:01 +02:00
2007-10-17 20:16:11 +02:00
2007-10-20 01:13:56 +02:00
2007-10-17 08:42:55 -07:00
2007-10-13 10:01:23 -07:00
2007-10-11 11:17:01 +02:00
2007-10-13 10:01:23 -07:00
2007-10-17 20:16:08 +02:00
2007-10-17 20:16:08 +02:00
2007-10-13 10:01:23 -07:00
2007-10-11 11:17:24 +02:00
2007-10-13 10:01:23 -07:00
2007-10-16 11:51:29 -07:00
2007-10-11 11:17:01 +02:00
2007-10-11 11:17:01 +02:00
2007-10-11 11:17:24 +02:00
2007-10-11 11:17:01 +02:00
2007-10-11 11:17:24 +02:00
2007-10-11 11:17:01 +02:00
2007-10-11 11:17:01 +02:00
2007-10-11 11:17:01 +02:00
2007-10-11 11:17:01 +02:00
2007-10-11 11:17:01 +02:00
2007-10-11 11:17:01 +02:00
2007-10-11 11:17:24 +02:00