linux

mirror of https://github.com/raspberrypi/linux.git synced 2025-12-07 10:29:52 +00:00

Files

Robert Elliott a98f1946ea linvdimm, pmem: Preserve read-only setting for pmem devices

commit 254a4cd50b upstream.

The pmem driver does not honor a forced read-only setting for very long:
	$ blockdev --setro /dev/pmem0
	$ blockdev --getro /dev/pmem0
	1

followed by various commands like these:
	$ blockdev --rereadpt /dev/pmem0
	or
	$ mkfs.ext4 /dev/pmem0

results in this in the kernel serial log:
	 nd_pmem namespace0.0: region0 read-write, marking pmem0 read-write

with the read-only setting lost:
	$ blockdev --getro /dev/pmem0
	0

That's from bus.c nvdimm_revalidate_disk(), which always applies the
setting from nd_region (which is initially based on the ACPI NFIT
NVDIMM state flags not_armed bit).

In contrast, commit 20bd1d026a ("scsi: sd: Keep disk read-only when
re-reading partition") fixed this issue for SCSI devices to preserve
the previous setting if it was set to read-only.

This patch modifies bus.c to preserve any previous read-only setting.
It also eliminates the kernel serial log print except for cases where
read-write is changed to read-only, so it doesn't print read-only to
read-only non-changes.

Cc: <stable@vger.kernel.org>
Fixes: 5813882094 ("libnvdimm, nfit: handle unarmed dimms, mark namespaces read-only")
Signed-off-by: Robert Elliott <elliott@hpe.com>
Signed-off-by: Dan Williams <dan.j.williams@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

2018-07-03 11:24:58 +02:00

blk.c

libnvdimm, {btt, blk}: do integrity setup before add_disk()

2018-03-28 18:24:41 +02:00

btt_devs.c

libnvdimm: rename nd_sector_size_{show,store} to nd_size_select_{show,store}

2017-08-11 17:36:54 -07:00

btt.c

libnvdimm, {btt, blk}: do integrity setup before add_disk()

2018-03-28 18:24:41 +02:00

btt.h

libnvdimm, btt: Fix an incompatibility in the log layout