Toke Høiland-Jørgensen
c2ebc88260
bpf: disallow attaching modify_return tracing functions to other BPF programs
...
[ Upstream commit 1af9270e90 ]
From the checks and commit messages for modify_return, it seems it was
never the intention that it should be possible to attach a tracing program
with expected_attach_type == BPF_MODIFY_RETURN to another BPF program.
However, check_attach_modify_return() will only look at the function name,
so if the target function starts with "security_", the attach will be
allowed even for bpf2bpf attachment.
Fix this oversight by also blocking the modification if a target program is
supplied.
Fixes: 18644cec71 ("bpf: Fix use-after-free in fmod_ret check")
Fixes: 6ba43b761c ("bpf: Attachment verification for BPF_MODIFY_RETURN")
Acked-by: Andrii Nakryiko <andriin@fb.com >
Signed-off-by: Toke Høiland-Jørgensen <toke@redhat.com >
Signed-off-by: Alexei Starovoitov <ast@kernel.org >
Signed-off-by: Sasha Levin <sashal@kernel.org >
2020-10-29 10:07:46 +01:00
..
2020-10-29 10:07:46 +01:00
2020-07-07 13:34:11 -07:00
2020-04-07 10:43:42 -07:00
2020-07-09 20:09:28 -07:00
2020-09-03 11:29:52 +02:00
2020-10-29 10:07:17 +01:00
2020-09-17 13:55:47 +02:00
2020-09-03 11:29:44 +02:00
2020-06-11 20:04:01 +02:00
2020-05-11 00:31:38 +02:00
2020-09-23 12:59:58 +02:00
2020-06-14 01:57:21 +09:00
2020-06-21 20:47:20 -07:00
2020-08-19 08:26:06 +02:00
2020-10-29 10:07:15 +01:00
2020-08-19 08:27:02 +02:00
2020-10-07 08:02:49 +02:00
2020-03-25 11:50:48 +01:00
2020-06-09 09:39:14 -07:00
2020-03-23 18:19:06 +01:00
2020-04-06 08:58:42 -07:00
2020-07-29 12:35:36 -07:00
2020-07-29 10:00:36 -04:00
2020-04-22 15:23:10 -04:00
2020-07-29 10:00:36 -04:00
2020-05-01 12:35:21 +10:00
2020-02-04 03:05:26 +00:00
2020-06-11 15:14:36 +02:00
2020-05-15 11:44:34 -07:00
2020-06-03 13:06:42 -07:00
2019-06-19 17:09:06 +02:00
2020-04-15 11:21:54 +02:00
2020-05-20 14:44:21 -05:00
2019-09-25 17:51:39 -07:00
2020-06-09 09:39:14 -07:00
2020-04-07 10:43:42 -07:00
2020-06-26 01:05:29 +02:00
2019-10-06 09:11:37 -06:00
2020-06-09 09:39:14 -07:00
2020-06-06 23:42:01 +09:00
2020-06-02 10:59:11 -07:00
2020-06-08 11:05:56 -07:00
2019-07-12 11:05:40 -07:00
2020-05-28 10:54:15 +02:00
2019-08-29 15:10:10 +01:00
2020-07-08 15:59:57 -07:00
2020-03-25 10:04:01 -05:00
2019-12-08 14:37:36 +01:00
2019-11-12 11:35:32 +01:00
2020-06-10 19:14:17 -07:00
2020-01-08 16:32:55 +00:00
2019-09-06 23:58:44 +02:00
2020-06-26 00:27:36 -07:00
2020-01-08 16:32:55 +00:00
2020-01-08 16:32:55 +00:00
2020-04-10 15:36:22 -07:00
2020-10-01 17:36:33 +02:00
2020-08-21 13:14:58 +02:00
2020-04-27 02:07:40 -04:00
2020-09-03 11:29:15 +02:00
2019-08-05 18:39:56 -04:00
2019-08-05 18:39:56 -04:00
2020-08-21 13:15:01 +02:00
2020-06-02 10:59:12 -07:00
2020-06-17 00:33:12 +02:00
2020-09-17 13:55:28 +02:00
2020-06-11 15:14:36 +02:00
2019-08-19 21:54:16 -07:00
2020-06-03 16:27:18 -07:00
2020-08-21 13:14:55 +02:00
2020-02-04 03:05:26 +00:00
2020-01-18 13:51:39 +01:00
2020-05-30 10:34:03 -07:00
2020-08-26 11:48:59 +02:00
2020-05-27 11:10:05 +02:00
2019-12-25 10:41:20 +01:00
2020-06-04 16:14:56 +01:00
2020-09-17 13:55:30 +02:00
2020-08-19 08:27:10 +02:00
2020-06-28 17:01:20 +02:00
2020-06-11 15:15:24 +02:00
2019-11-11 10:30:59 +01:00
2020-01-17 10:19:21 +01:00
2019-11-15 14:38:30 +01:00
2020-06-14 11:39:31 -07:00
2019-11-26 13:03:56 -06:00
2020-01-09 16:42:29 -07:00
2020-06-08 11:05:56 -07:00
2020-08-19 08:27:10 +02:00
2019-12-04 15:18:39 +01:00
2020-03-30 18:06:39 -07:00
2019-07-18 11:51:00 -07:00
2019-12-18 18:07:31 +01:00
2020-04-07 21:51:27 +02:00
2020-10-14 11:55:47 +02:00
2020-02-07 15:34:12 +01:00
2020-05-09 13:57:12 +02:00
2020-06-04 19:06:24 -07:00
2020-04-27 02:07:40 -04:00
2020-05-09 13:57:12 +02:00
2020-08-26 11:49:12 +02:00
2020-06-08 11:05:56 -07:00
2020-06-17 10:57:41 -07:00