Matt Johnston 5c47d5bfa7 net: mctp: unshare packets when reassembling ...

[ Upstream commit f5d83cf0ee ]

Ensure that the frag_list used for reassembly isn't shared with other
packets. This avoids incorrect reassembly when packets are cloned, and
prevents a memory leak due to circular references between fragments and
their skb_shared_info.

The upcoming MCTP-over-USB driver uses skb_clone which can trigger the
problem - other MCTP drivers don't share SKBs.

A kunit test is added to reproduce the issue.

Signed-off-by: Matt Johnston <matt@codeconstruct.com.au>
Fixes: 4a992bbd36 ("mctp: Implement message fragmentation & reassembly")
Reviewed-by: Simon Horman <horms@kernel.org>
Link: https://patch.msgid.link/20250306-matt-mctp-usb-v1-1-085502b3dd28@codeconstruct.com.au
Signed-off-by: Paolo Abeni <pabeni@redhat.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>

2025-03-22 12:54:13 -07:00

..

route-test.c

net: mctp: unshare packets when reassembling

2025-03-22 12:54:13 -07:00

utils.c

net: mctp: tests: create test skbs with the correct net and device

2024-02-22 13:32:55 +01:00

utils.h

mctp: Add test utils

2021-10-03 14:35:41 +01:00