linux

mirror of https://github.com/raspberrypi/linux.git synced 2025-12-07 10:29:52 +00:00

Files

Aditya Shankar 89cb8fccea staging: wilc1000: Fix problem with wrong vif index

commit 0e490657c7 upstream.

The vif->idx value is always 0 for two interfaces.

wl->vif_num = 0;

loop {
     ...

     vif->idx = wl->vif_num;
     ...
     wl->vif_num = i;
      ....
     i++;
     ...
}

At present, vif->idx is assigned the value of wl->vif_num
at the beginning of this block and device is initialized
based on this index value.
In the next iteration, wl->vif_num is still 0 as it is only updated
later but gets assigned to vif->idx in the beginning. This causes problems
later when we try to reference a particular interface and also while
configuring the firmware.

This patch moves the assignment to vif->idx from the beginning
of the block to after wl->vif_num is updated with latest value of i.

Fixes: commit 735bb39ca3 ("staging: wilc1000: simplify vif[i]->ndev accesses")
Signed-off-by: Aditya Shankar <aditya.shankar@microchip.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

2017-05-20 14:49:41 +02:00

coreconfigurator.c

Staging: wilc1000: Compress return logic into one line

2016-10-16 10:27:34 +02:00

coreconfigurator.h

Staging: wilc1000: Remove struct typedef

2016-09-13 15:13:16 +02:00

host_interface.c

staging:wilc1000:host_interface.c Added braces {} on else statemement

2017-01-16 18:10:25 +01:00

host_interface.h

staging: wilc1000: Remove unnecessary extern variables.