Eric Dumazet
1959c36142
net/sched: sch_taprio: fix undefined behavior in ktime_mono_to_any
[ Upstream commit 6dc25401cb ]
1) if q->tk_offset == TK_OFFS_MAX, then get_tcp_tstamp() calls
ktime_mono_to_any() with out-of-bound value.
2) if q->tk_offset is changed in taprio_parse_clockid(),
taprio_get_time() might also call ktime_mono_to_any()
with out-of-bound value as sysbot found:
UBSAN: array-index-out-of-bounds in kernel/time/timekeeping.c:908:27
index 3 is out of range for type 'ktime_t *[3]'
CPU: 1 PID: 25668 Comm: kworker/u4:0 Not tainted 5.15.0-syzkaller #0
Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/01/2011
Workqueue: bat_events batadv_iv_send_outstanding_bat_ogm_packet
Call Trace:
<TASK>
__dump_stack lib/dump_stack.c:88 [inline]
dump_stack_lvl+0xcd/0x134 lib/dump_stack.c:106
ubsan_epilogue+0xb/0x5a lib/ubsan.c:151
__ubsan_handle_out_of_bounds.cold+0x62/0x6c lib/ubsan.c:291
ktime_mono_to_any+0x1d4/0x1e0 kernel/time/timekeeping.c:908
get_tcp_tstamp net/sched/sch_taprio.c:322 [inline]
get_packet_txtime net/sched/sch_taprio.c:353 [inline]
taprio_enqueue_one+0x5b0/0x1460 net/sched/sch_taprio.c:420
taprio_enqueue+0x3b1/0x730 net/sched/sch_taprio.c:485
dev_qdisc_enqueue+0x40/0x300 net/core/dev.c:3785
__dev_xmit_skb net/core/dev.c:3869 [inline]
__dev_queue_xmit+0x1f6e/0x3630 net/core/dev.c:4194
batadv_send_skb_packet+0x4a9/0x5f0 net/batman-adv/send.c:108
batadv_iv_ogm_send_to_if net/batman-adv/bat_iv_ogm.c:393 [inline]
batadv_iv_ogm_emit net/batman-adv/bat_iv_ogm.c:421 [inline]
batadv_iv_send_outstanding_bat_ogm_packet+0x6d7/0x8e0 net/batman-adv/bat_iv_ogm.c:1701
process_one_work+0x9b2/0x1690 kernel/workqueue.c:2298
worker_thread+0x658/0x11f0 kernel/workqueue.c:2445
kthread+0x405/0x4f0 kernel/kthread.c:327
ret_from_fork+0x1f/0x30 arch/x86/entry/entry_64.S:295
Fixes: 7ede7b0348 ("taprio: make clock reference conversions easier")
Fixes: 5400206610 ("taprio: Adjust timestamps for TCP packets")
Signed-off-by: Eric Dumazet <edumazet@google.com>
Cc: Vedang Patel <vedang.patel@intel.com>
Reported-by: syzbot <syzkaller@googlegroups.com>
Reviewed-by: Vinicius Costa Gomes <vinicius.gomes@intel.com>
Link: https://lore.kernel.org/r/20211108180815.1822479-1-eric.dumazet@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
2021-11-17 11:04:43 +01:00
..
2021-06-17 11:36:18 -07:00
2021-06-24 19:43:11 +02:00
2020-09-24 19:46:21 -07:00
2020-09-24 19:46:21 -07:00
2021-10-27 09:59:36 +02:00
2020-10-05 18:40:01 -07:00
2020-09-24 19:46:21 -07:00
2020-10-05 18:40:01 -07:00
2020-09-24 19:46:21 -07:00
2020-11-16 08:08:54 -08:00
2019-05-30 11:26:32 -07:00
2019-05-30 11:26:32 -07:00
2019-05-30 11:26:32 -07:00
2021-08-09 10:58:47 +01:00
2020-12-03 11:13:37 -08:00
2020-09-24 19:46:21 -07:00
2020-09-24 19:46:21 -07:00
2021-03-13 14:18:09 -08:00
2021-03-14 15:00:43 -07:00
2020-11-16 08:08:54 -08:00
2020-09-24 19:46:21 -07:00
2021-07-20 07:13:51 -07:00
2020-10-20 21:10:41 -07:00
2021-06-01 16:54:42 -07:00
2021-09-18 13:43:53 +02:00
2020-01-27 10:51:43 +01:00
2021-06-24 19:43:11 +02:00
2019-05-30 11:26:32 -07:00
2020-08-04 13:49:43 -07:00
2021-10-07 07:53:15 +02:00
2020-01-27 10:51:43 +01:00
2020-06-19 12:53:30 -07:00
2020-03-16 01:59:32 -07:00
2019-05-30 11:26:32 -07:00
2019-05-30 11:26:32 -07:00
2021-05-31 22:44:56 -07:00
2021-07-18 09:45:46 -07:00
2020-12-08 16:22:53 -08:00
2020-07-13 17:20:40 -07:00
2020-11-10 17:00:28 -08:00
2020-07-03 14:34:53 -07:00
2020-07-03 14:34:53 -07:00
2020-07-03 14:34:53 -07:00
2021-02-06 11:15:28 -08:00
2019-05-30 11:26:32 -07:00
2019-05-30 11:26:32 -07:00
2021-05-31 22:44:56 -07:00
2020-12-09 15:49:29 -08:00
2020-11-27 14:36:02 -08:00
2021-10-17 10:44:50 +02:00
2021-01-22 20:41:29 -08:00
2020-07-16 16:48:34 -07:00
2021-08-18 10:14:00 +01:00
2021-09-15 10:02:31 +02:00
2020-11-23 17:27:04 -08:00
2021-03-10 15:47:52 -08:00
2020-07-16 16:48:34 -07:00
2021-01-22 20:41:29 -08:00
2021-05-24 13:11:44 -07:00
2020-07-16 16:48:34 -07:00
2021-08-25 11:15:30 +01:00
2021-10-13 09:41:56 +02:00
2021-09-22 12:39:31 +02:00
2021-05-23 17:16:09 -07:00
2020-07-16 16:48:34 -07:00
2021-04-29 15:31:53 -07:00
2021-11-17 11:03:44 +01:00
2021-05-31 22:44:56 -07:00
2021-01-22 20:41:29 -08:00
2020-07-16 16:48:34 -07:00
2021-09-15 10:02:31 +02:00
2020-02-19 17:49:48 -08:00
2021-11-17 11:03:44 +01:00
2021-11-17 11:03:44 +01:00
2020-07-16 16:48:34 -07:00
2020-10-29 11:45:47 -07:00
2020-11-10 17:00:28 -08:00
2020-07-16 16:48:34 -07:00
2020-07-16 16:48:34 -07:00
2021-06-21 14:50:19 -07:00
2021-03-10 15:47:52 -08:00
2021-01-22 20:41:29 -08:00
2021-03-10 15:47:52 -08:00
2020-07-16 16:48:34 -07:00
2021-11-17 11:04:43 +01:00
2020-07-16 16:48:34 -07:00
2021-04-08 14:14:42 -07:00