Bart Van Assche b3e1e2d54d pktcdvd: Fix a recently introduced NULL pointer dereference ...

commit 882d4171a8 upstream.

Call bdev_get_queue(bdev) after bdev->bd_disk has been initialized
instead of just before that pointer has been initialized. This patch
avoids that the following command

pktsetup 1 /dev/sr0

triggers the following kernel crash:

BUG: unable to handle kernel NULL pointer dereference at 0000000000000548
IP: pkt_setup_dev+0x2db/0x670 [pktcdvd]
CPU: 2 PID: 724 Comm: pktsetup Not tainted 4.15.0-rc4-dbg+ #1
Call Trace:
 pkt_ctl_ioctl+0xce/0x1c0 [pktcdvd]
 do_vfs_ioctl+0x8e/0x670
 SyS_ioctl+0x3c/0x70
 entry_SYSCALL_64_fastpath+0x23/0x9a

Reported-by: Maciej S. Szmigiero <mail@maciej.szmigiero.name>
Fixes: commit ca18d6f769 ("block: Make most scsi_req_init() calls implicit")
Signed-off-by: Bart Van Assche <bart.vanassche@wdc.com>
Tested-by: Maciej S. Szmigiero <mail@maciej.szmigiero.name>
Cc: Maciej S. Szmigiero <mail@maciej.szmigiero.name>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

2018-02-16 20:06:58 +01:00

..

aoe

treewide: Remove TIMER_FUNC_TYPE and TIMER_DATA_TYPE casts

2017-11-21 16:35:54 -08:00

drbd

Merge branch 'timers-core-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip

2017-11-13 17:56:58 -08:00

mtip32xx

Merge branch 'for-4.15/block' of git://git.kernel.dk/linux-block

2017-11-14 15:32:19 -08:00

paride

Merge branch 'for-4.15/block' of git://git.kernel.dk/linux-block

2017-11-14 15:32:19 -08:00

rsxx

treewide: setup_timer() -> timer_setup() (2 field)

2017-11-21 15:57:09 -08:00

xen-blkback

Merge branch 'for-4.14/block' of git://git.kernel.dk/linux-block

2017-09-07 11:59:42 -07:00

zram

drivers/block/zram/zram_drv.c: make zram_page_end_io() static

2017-11-15 18:21:05 -08:00

amiflop.c

amifloppy: Convert timers to use timer_setup()

2017-11-14 20:11:57 -07:00

ataflop.c

treewide: Switch DEFINE_TIMER callbacks to struct timer_list *

2017-11-21 15:57:05 -08:00

brd.c

Merge tag 'libnvdimm-for-4.15' of git://git.kernel.org/pub/scm/linux/kernel/git/nvdimm/nvdimm

2017-11-17 09:51:57 -08:00

cryptoloop.c

block: cryptoloop - Fix build warning

2017-09-26 07:41:22 -06:00

DAC960.c

treewide: setup_timer() -> timer_setup()

2017-11-21 15:57:07 -08:00

DAC960.h

treewide: setup_timer() -> timer_setup()

2017-11-21 15:57:07 -08:00

floppy.c

block/floppy: Convert callback to pass timer_list

2017-11-14 20:10:35 -07:00

Kconfig

Merge tag 'libnvdimm-for-4.15' of git://git.kernel.org/pub/scm/linux/kernel/git/nvdimm/nvdimm

2017-11-17 09:51:57 -08:00

loop.c

loop: fix concurrent lo_open/lo_release

2018-01-06 09:32:07 -07:00

loop.h

block/loop: make loop cgroup aware

2017-09-26 07:41:22 -06:00

Makefile

License cleanup: add SPDX GPL-2.0 license identifier to files with no license

2017-11-02 11:10:55 +01:00

nbd.c

Merge branch 'for-4.15/block' of git://git.kernel.dk/linux-block

2017-11-14 15:32:19 -08:00

null_blk.c

null_blk: unalign call_single_data

2017-12-20 13:16:33 -07:00

pktcdvd.c

pktcdvd: Fix a recently introduced NULL pointer dereference

2018-02-16 20:06:58 +01:00

ps3disk.c

block: introduce new block status code type

2017-06-09 09:27:32 -06:00

ps3vram.c

block/ps3vram: Check return of ps3vram_cache_init

2017-08-17 23:03:44 +10:00

rbd_types.h

…

rbd.c

rbd: set max_segments to USHRT_MAX

2018-01-09 17:40:48 +01:00

skd_main.c

treewide: setup_timer() -> timer_setup()

2017-11-21 15:57:07 -08:00

skd_s1120.h

skd: Use __packed only when needed

2017-08-18 08:45:29 -06:00

smart1,2.h

…

sunvdc.c

treewide: setup_timer() -> timer_setup()

2017-11-21 15:57:07 -08:00

swim3.c

treewide: Remove TIMER_FUNC_TYPE and TIMER_DATA_TYPE casts

2017-11-21 16:35:54 -08:00

swim_asm.S

…

swim.c

block: don't set bounce limit in blk_init_queue

2017-06-27 12:13:45 -06:00

sx8.c

block: introduce new block status code type

2017-06-09 09:27:32 -06:00

umem.c

treewide: setup_timer() -> timer_setup()

2017-11-21 15:57:07 -08:00

umem.h

…

virtio_blk.c

virtio_blk: Fix an SG_IO regression

2017-10-27 08:23:21 -06:00

xen-blkfront.c

Merge branch 'for-4.14/block' of git://git.kernel.dk/linux-block

2017-09-07 11:59:42 -07:00

xsysace.c

treewide: setup_timer() -> timer_setup()

2017-11-21 15:57:07 -08:00

z2ram.c

block: introduce new block status code type

2017-06-09 09:27:32 -06:00