Colin Ian King 31c9a4b24d KEYS: trusted: Fix memory leak on object td ...

commit 83a775d5f9 upstream.

Two error return paths are neglecting to free allocated object td,
causing a memory leak. Fix this by returning via the error return
path that securely kfree's td.

Fixes clang scan-build warning:
security/keys/trusted-keys/trusted_tpm1.c:496:10: warning: Potential
memory leak [unix.Malloc]

Cc: stable@vger.kernel.org
Fixes: 5df16caada ("KEYS: trusted: Fix incorrect handling of tpm_get_random()")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
Reviewed-by: Jarkko Sakkinen <jarkko@kernel.org>
Signed-off-by: Jarkko Sakkinen <jarkko@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

2021-05-19 10:12:50 +02:00

..

encrypted-keys

Merge tag 'for-v5.9' of git://git.kernel.org/pub/scm/linux/kernel/git/jmorris/linux-security

2020-08-11 14:30:36 -07:00

trusted-keys

KEYS: trusted: Fix memory leak on object td

2021-05-19 10:12:50 +02:00

big_key.c

mm, treewide: rename kzfree() to kfree_sensitive()

2020-08-07 11:33:22 -07:00

compat_dh.c

treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 152

2019-05-30 11:26:32 -07:00

compat.c

security/keys: remove compat_keyctl_instantiate_key_iov

2020-10-03 00:02:16 -04:00

dh.c

mm, treewide: rename kzfree() to kfree_sensitive()

2020-08-07 11:33:22 -07:00

gc.c

watch_queue: Add a key/keyring notification facility

2020-05-19 15:19:06 +01:00

internal.h

security/keys: remove compat_keyctl_instantiate_key_iov

2020-10-03 00:02:16 -04:00

Kconfig

watch_queue: Drop references to /dev/watch_queue

2021-03-04 11:37:59 +01:00

key.c

certs: Fix blacklist flag type confusion

2021-03-04 11:37:59 +01:00

keyctl_pkey.c

treewide: Replace GPLv2 boilerplate/reference with SPDX - rule 36

2019-05-24 17:27:11 +02:00

keyctl.c

task_work: cleanup notification modes

2020-10-17 15:05:30 -06:00

keyring.c

watch_queue: Add a key/keyring notification facility

2020-05-19 15:19:06 +01:00

Makefile

KEYS: remove CONFIG_KEYS_COMPAT

2019-12-12 23:41:17 +02:00

permission.c

keys: Make the KEY_NEED_* perms an enum rather than a mask

2020-05-19 15:42:22 +01:00

persistent.c

Revert "Merge tag 'keys-acl-20190703' of git://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs"

2019-07-10 18:43:43 -07:00

proc.c

keys: Fix proc_keys_next to increase position index

2020-04-16 10:10:50 -07:00

process_keys.c

treewide: Use fallthrough pseudo-keyword

2020-08-23 17:36:59 -05:00

request_key_auth.c

KEYS: Don't write out to userspace while holding key semaphore

2020-03-29 12:40:41 +01:00

request_key.c

treewide: Use fallthrough pseudo-keyword

2020-08-23 17:36:59 -05:00

sysctl.c

proc/sysctl: add shared variables for range check

2019-07-18 17:08:07 -07:00

user_defined.c

mm, treewide: rename kzfree() to kfree_sensitive()

2020-08-07 11:33:22 -07:00