Pablo Neira Ayuso
e51ff3ffc3
netfilter: nftables: clone set element expression template
commit 4d8f906583 upstream.
memcpy() breaks when using connlimit in set elements. Use
nft_expr_clone() to initialize the connlimit expression list, otherwise
connlimit garbage collector crashes when walking on the list head copy.
[ 493.064656] Workqueue: events_power_efficient nft_rhash_gc [nf_tables]
[ 493.064685] RIP: 0010:find_or_evict+0x5a/0x90 [nf_conncount]
[ 493.064694] Code: 2b 43 40 83 f8 01 77 0d 48 c7 c0 f5 ff ff ff 44 39 63 3c 75 df 83 6d 18 01 48 8b 43 08 48 89 de 48 8b 13 48 8b 3d ee 2f 00 00 <48> 89 42 08 48 89 10 48 b8 00 01 00 00 00 00 ad de 48 89 03 48 83
[ 493.064699] RSP: 0018:ffffc90000417dc0 EFLAGS: 00010297
[ 493.064704] RAX: 0000000000000000 RBX: ffff888134f38410 RCX: 0000000000000000
[ 493.064708] RDX: 0000000000000000 RSI: ffff888134f38410 RDI: ffff888100060cc0
[ 493.064711] RBP: ffff88812ce594a8 R08: ffff888134f38438 R09: 00000000ebb9025c
[ 493.064714] R10: ffffffff8219f838 R11: 0000000000000017 R12: 0000000000000001
[ 493.064718] R13: ffffffff82146740 R14: ffff888134f38410 R15: 0000000000000000
[ 493.064721] FS: 0000000000000000(0000) GS:ffff88840e440000(0000) knlGS:0000000000000000
[ 493.064725] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
[ 493.064729] CR2: 0000000000000008 CR3: 00000001330aa002 CR4: 00000000001706e0
[ 493.064733] Call Trace:
[ 493.064737] nf_conncount_gc_list+0x8f/0x150 [nf_conncount]
[ 493.064746] nft_rhash_gc+0x106/0x390 [nf_tables]
Reported-by: Laura Garcia Liebana <nevola@gmail.com>
Fixes: 4094445229 ("netfilter: nf_tables: add elements with stateful expressions")
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
Signed-off-by: Florian Westphal <fw@strlen.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2021-09-12 08:58:27 +02:00
..
2021-01-19 18:27:23 +01:00
2021-06-10 13:39:15 +02:00
2020-10-12 01:57:34 +02:00
2020-10-15 11:45:19 -07:00
2020-04-09 00:12:48 +09:00
2019-05-21 10:50:45 +02:00
2019-06-19 17:09:55 +02:00
2019-07-16 13:16:59 +02:00
2019-07-16 13:16:59 +02:00
2021-09-03 10:09:21 +02:00
2019-10-26 12:36:42 +02:00
2019-09-13 12:33:06 +02:00
2019-12-17 22:59:31 +01:00
2020-07-16 12:35:15 -07:00
2020-07-22 01:18:05 +02:00
2019-07-16 13:16:59 +02:00
2019-06-19 17:09:52 +02:00
2019-09-13 12:33:06 +02:00
2019-07-16 13:16:59 +02:00
2019-08-27 18:07:03 +02:00
2019-05-30 11:26:32 -07:00
2021-07-25 14:36:19 +02:00
2020-08-28 20:11:38 +02:00
2020-01-08 23:31:22 +01:00
2019-06-19 17:09:55 +02:00
2021-04-10 13:36:08 +02:00
2020-05-27 22:20:34 +02:00
2020-05-27 22:20:34 +02:00
2020-08-20 14:13:49 +02:00
2020-10-20 13:54:53 +02:00
2020-08-29 13:03:06 +02:00
2021-06-10 13:39:13 +02:00
2019-07-16 13:16:59 +02:00
2019-05-31 18:02:45 +02:00
2019-07-16 13:16:59 +02:00
2019-05-30 11:26:32 -07:00
2021-05-07 11:04:31 +02:00
2019-07-16 13:16:59 +02:00
2019-09-13 12:33:06 +02:00
2019-05-24 17:37:51 +02:00
2020-10-22 14:49:36 +02:00
2021-06-03 09:00:37 +02:00
2020-06-25 00:50:31 +02:00
2020-10-12 01:58:10 +02:00
2021-06-03 09:00:37 +02:00
2020-05-27 22:20:34 +02:00
2020-10-14 01:25:14 +02:00
2019-06-19 17:09:55 +02:00
2020-04-27 02:07:40 -04:00
2019-07-16 13:16:59 +02:00
2021-01-19 18:27:33 +01:00
2019-07-16 13:16:59 +02:00
2019-06-22 08:59:24 -04:00
2019-07-16 13:16:59 +02:00
2019-04-11 20:59:34 +02:00
2021-03-17 17:06:12 +01:00
2019-06-22 08:59:24 -04:00
2019-07-16 13:16:59 +02:00
2019-07-16 13:16:59 +02:00
2020-03-29 16:28:29 +02:00
2020-07-24 15:41:54 -07:00
2021-06-23 14:42:43 +02:00
2021-09-12 08:58:27 +02:00
2020-10-04 21:08:33 +02:00
2021-07-14 16:56:24 +02:00
2019-06-19 17:09:55 +02:00
2020-07-29 20:09:18 +02:00
2021-06-10 13:39:19 +02:00
2020-07-22 01:18:05 +02:00
2020-08-28 20:11:58 +02:00
2021-05-19 10:13:08 +02:00
2020-08-28 20:11:58 +02:00
2020-10-30 12:57:39 +01:00
2020-10-04 21:08:33 +02:00
2019-08-26 11:01:00 +02:00
2020-10-12 01:57:34 +02:00
2020-03-06 18:00:43 +01:00
2020-10-30 12:57:39 +01:00
2021-05-14 09:50:40 +02:00
2020-08-10 13:03:36 +02:00
2020-06-25 00:50:31 +02:00
2020-06-25 00:50:31 +02:00
2021-06-10 13:39:18 +02:00
2020-06-25 00:50:31 +02:00
2021-02-03 23:28:44 +01:00
2021-07-14 16:56:22 +02:00
2020-06-25 00:50:31 +02:00
2020-06-25 00:50:31 +02:00
2020-07-22 01:18:05 +02:00
2020-08-29 13:03:06 +02:00
2020-10-22 14:49:36 +02:00
2020-06-25 00:50:31 +02:00
2020-07-15 20:15:19 +02:00
2021-04-21 13:00:56 +02:00
2020-06-25 00:50:31 +02:00
2020-04-05 23:26:36 +02:00
2020-06-25 00:50:31 +02:00
2020-11-27 12:10:47 +01:00
2021-08-04 12:46:42 +02:00
2020-06-25 00:50:31 +02:00
2020-06-25 00:50:31 +02:00
2021-07-14 16:56:22 +02:00
2021-05-14 09:50:40 +02:00
2020-06-25 00:50:31 +02:00
2020-06-25 00:50:31 +02:00
2019-12-09 13:14:03 +01:00
2020-06-25 00:50:31 +02:00
2020-06-25 00:50:31 +02:00
2020-06-30 18:21:02 +02:00
2019-06-19 17:09:55 +02:00
2020-04-05 23:26:36 +02:00
2021-09-12 08:58:27 +02:00
2021-06-03 09:00:28 +02:00
2020-04-09 00:12:48 +09:00
2021-06-03 09:00:28 +02:00
2021-06-03 09:00:28 +02:00
2020-08-21 17:37:36 +02:00
2020-08-29 13:04:44 +02:00
2020-06-25 00:50:31 +02:00
2021-07-14 16:56:22 +02:00
2020-06-25 00:50:31 +02:00
2019-06-19 17:09:55 +02:00
2020-10-30 12:57:39 +01:00
2021-04-16 11:43:21 +02:00
2019-06-19 17:09:55 +02:00
2019-06-19 17:09:55 +02:00
2019-06-19 17:09:55 +02:00
2019-06-19 17:09:55 +02:00
2019-06-19 17:09:55 +02:00
2019-06-19 17:09:55 +02:00
2019-06-19 17:09:55 +02:00
2019-05-21 10:50:45 +02:00
2018-02-14 21:05:38 +01:00
2019-06-19 17:09:55 +02:00
2019-09-13 12:33:06 +02:00
2020-07-29 20:09:18 +02:00
2020-07-29 20:09:18 +02:00
2019-06-19 17:09:55 +02:00
2019-06-19 17:09:55 +02:00
2019-06-19 17:09:55 +02:00
2019-06-19 17:09:55 +02:00
2019-06-19 17:09:55 +02:00
2019-06-19 17:09:55 +02:00
2019-06-22 08:59:24 -04:00
2019-06-19 17:09:55 +02:00
2019-06-19 17:09:55 +02:00
2020-03-15 15:20:16 +01:00
2019-06-19 17:09:55 +02:00
2019-06-19 17:09:55 +02:00
2019-06-22 08:59:24 -04:00
2020-08-28 19:55:51 +02:00
2020-04-05 23:26:37 +02:00
2019-05-30 11:26:32 -07:00
2019-06-25 01:32:59 +02:00
2019-05-21 10:50:45 +02:00
2019-06-19 17:09:55 +02:00
2019-05-30 11:26:38 -07:00
2019-06-19 17:09:55 +02:00
2019-06-19 17:09:55 +02:00
2019-06-19 17:09:55 +02:00
2019-06-19 17:09:55 +02:00
2019-06-19 17:09:55 +02:00
2019-06-19 17:09:55 +02:00
2019-06-19 17:09:55 +02:00
2020-06-25 00:50:31 +02:00
2019-06-19 17:09:55 +02:00
2020-07-29 20:09:18 +02:00
2019-06-19 17:09:55 +02:00
2019-06-19 17:09:55 +02:00
2019-05-21 11:28:45 +02:00
2019-06-25 01:32:59 +02:00
2019-09-13 12:32:48 +02:00
2019-06-19 17:09:55 +02:00
2019-06-19 17:09:55 +02:00
2019-05-21 10:50:45 +02:00
2019-06-19 17:09:55 +02:00
2021-01-12 20:18:26 +01:00
2019-06-19 17:09:55 +02:00
2021-02-17 11:02:25 +01:00
2019-06-19 17:09:55 +02:00
2017-11-02 11:10:55 +01:00
2019-05-21 10:50:45 +02:00
2021-05-19 10:13:06 +02:00
2019-08-13 12:14:26 +02:00
2019-06-19 17:09:55 +02:00
2019-06-19 17:09:55 +02:00
2019-06-19 17:09:55 +02:00
2019-06-19 17:09:55 +02:00
2019-06-19 17:09:55 +02:00
2019-06-22 08:59:24 -04:00
2019-06-22 08:59:24 -04:00
2019-05-21 10:50:45 +02:00
2019-05-21 11:28:40 +02:00
2020-07-29 20:09:18 +02:00
2019-06-19 17:09:55 +02:00
2019-05-21 10:50:45 +02:00
2019-05-21 10:50:45 +02:00