Baptiste Lepers 60bb2cecf4 sunrpc: Fix misplaced barrier in call_decode ...

[ Upstream commit f8f7e0fb22 ]

Fix a misplaced barrier in call_decode. The struct rpc_rqst is modified
as follows by xprt_complete_rqst:

req->rq_private_buf.len = copied;
/* Ensure all writes are done before we update */
/* req->rq_reply_bytes_recvd */
smp_wmb();
req->rq_reply_bytes_recvd = copied;

And currently read as follows by call_decode:

smp_rmb(); // misplaced
if (!req->rq_reply_bytes_recvd)
   goto out;
req->rq_rcv_buf.len = req->rq_private_buf.len;

This patch places the smp_rmb after the if to ensure that
rq_reply_bytes_recvd and rq_private_buf.len are read in order.

Fixes: 9ba828861c ("SUNRPC: Don't try to parse incomplete RPC messages")
Signed-off-by: Baptiste Lepers <baptiste.lepers@gmail.com>
Signed-off-by: Trond Myklebust <trond.myklebust@hammerspace.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>

2021-05-19 10:13:06 +02:00

..

auth_gss

rpc: fix NULL dereference on kmalloc failure

2021-04-07 15:00:04 +02:00

xprtrdma

xprtrdma: rpcrdma_mr_pop() already does list_del_init()

2021-05-19 10:13:04 +02:00

addr.c

net: sunrpc: interpret the return value of kstrtou32 correctly

2021-01-19 18:27:33 +01:00

auth_null.c

SUNRPC: Add rpc_auth::au_ralign field

2019-02-14 11:48:36 -05:00

auth_unix.c

SUNRPC: Use the client user namespace when encoding creds

2019-04-26 16:24:32 -04:00

auth.c

sunrpc: add missing newline when printing parameter 'auth_hashtable_size' by sysfs

2020-06-11 13:33:48 -04:00

backchannel_rqst.c

Merge tag 'nfsd-5.10' of git://linux-nfs.org/~bfields/linux

2020-10-22 09:44:27 -07:00

cache.c

sunrpc: raise kernel RPC channel buffer size

2020-10-20 13:21:30 -04:00

clnt.c

sunrpc: Fix misplaced barrier in call_decode

2021-05-19 10:13:06 +02:00

debugfs.c

net: sunrpc: Fix 'snprintf' return value check in 'do_xprt_debugfs'

2020-12-30 11:53:30 +01:00

Kconfig

SUNRPC: remove RC4-HMAC-MD5 support from KerberosV

2020-09-11 14:39:15 +10:00

Makefile

SUNRPC: remove generic cred code.

2018-12-19 13:52:46 -05:00

netns.h

License cleanup: add SPDX GPL-2.0 license identifier to files with no license

2017-11-02 11:10:55 +01:00

rpc_pipe.c

sunrpc: destroy rpc_inode_cachep after unregister_filesystem

2020-07-17 13:12:44 -04:00

rpcb_clnt.c

SUNRPC: Replace rpcbind dprintk call sites with tracepoints

2020-09-21 10:21:09 -04:00

sched.c

SUNRPC: Set memalloc_nofs_save() for sync tasks

2021-03-17 17:06:33 +01:00

socklib.c

skb_copy_and_csum_bits(): don't bother with the last argument

2020-08-20 15:45:13 -04:00

socklib.h

SUNRPC: Refactor xs_sendpages()

2020-03-16 12:04:33 -04:00

stats.c

proc: convert everything to "struct proc_ops"

2020-02-04 03:05:26 +00:00

sunrpc_syms.c

sunrpc: check that domain table is empty at module unload.

2020-05-28 18:15:00 -04:00

sunrpc.h

Replace HTTP links with HTTPS ones: NFS, SUNRPC, and LOCKD clients

2020-09-21 10:21:10 -04:00

svc_xprt.c

NFSD: Repair misuse of sv_lock in 5.10.16-rt30.

2021-03-25 09:04:08 +01:00

svc.c

sunrpc: fix refcount leak for rpc auth modules

2021-03-25 09:04:08 +01:00

svcauth_unix.c

sunrpc: Remove unused function ip_map_update

2020-05-06 16:00:11 -04:00

svcauth.c

sunrpc: check that domain table is empty at module unload.

2020-05-28 18:15:00 -04:00

svcsock.c

SUNRPC: fix ternary sign expansion bug in tracing

2021-05-19 10:13:04 +02:00

sysctl.c

net/sunrpc: fix useless comparison in proc_do_xprt()

2020-11-08 16:28:25 -05:00

timer.c

treewide: Add SPDX license identifier for missed files

2019-05-21 10:50:45 +02:00

xdr.c

Merge tag 'nfsd-5.10' of git://linux-nfs.org/~bfields/linux

2020-10-22 09:44:27 -07:00

xprt.c

SUNRPC: Handle major timeout in xprt_adjust_timeout()

2021-05-19 10:13:03 +02:00

xprtmultipath.c

SUNRPC: Optimise transport balancing code

2019-07-18 14:43:52 -04:00

xprtsock.c

sunrpc: fix xs_read_xdr_buf for partial pages receive

2020-12-30 11:53:53 +01:00