Colin Ian King 2324985aa7 selftests/resctrl: Fix null pointer dereference on open failed ...

[ Upstream commit c7b607fa93 ]

Currently if opening /dev/null fails to open then file pointer fp
is null and further access to fp via fprintf will cause a null
pointer dereference. Fix this by returning a negative error value
when a null fp is detected.

Detected using cppcheck static analysis:
tools/testing/selftests/resctrl/fill_buf.c:124:6: note: Assuming
that condition '!fp' is not redundant
 if (!fp)
     ^
tools/testing/selftests/resctrl/fill_buf.c:126:10: note: Null
pointer dereference
 fprintf(fp, "Sum: %d ", ret);

Fixes: a2561b12fe ("selftests/resctrl: Add built in benchmark")
Signed-off-by: Colin Ian King <colin.i.king@gmail.com>
Signed-off-by: Shuah Khan <skhan@linuxfoundation.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>

2022-06-09 10:22:51 +02:00

..

fault-injection

…

ktest

bootconfig/tracing/ktest: Update ktest example for boot-time tracing

2021-08-16 11:39:51 -04:00

kunit

kunit: tool: Import missing importlib.abc

2022-02-23 12:03:04 +01:00

nvdimm

tools/testing/nvdimm: Fix missing 'fallthrough' warning

2021-08-11 11:55:54 -07:00

radix-tree

idr test suite: Improve reporting from idr_find_test_1

2021-04-01 07:50:42 -04:00

scatterlist

Merge branch 'akpm' (patches from Andrew)

2021-09-03 10:08:28 -07:00

selftests

selftests/resctrl: Fix null pointer dereference on open failed

2022-06-09 10:22:51 +02:00

vsock

vsock_diag_test: remove free_sock_stat() call in test_no_sockets

2021-10-15 17:21:34 -07:00