mirror of
https://github.com/raspberrypi/linux.git
synced 2025-12-23 02:04:02 +00:00
Currently on_thread_stack() is defined in <asm/processor.h>, depending
upon definitiong from <asm/stacktrace.h> despite this header not being
included. This ends up being fragile, and any user of on_thread_stack()
must include both <asm/processor.h> and <asm/stacktrace.h>.
We organised things this way due to header dependencies back in commit:
0b3e336601 ("arm64: Add support for STACKLEAK gcc plugin")
... but now that we no longer use current_top_of_stack(), and given that
stackleak includes <asm/stacktrace.h> via <linux/stackleak.h>, we no
longer need the definition to live in <asm/processor.h>.
Move on_thread_stack() to <asm/stacktrace.h>, where all its dependencies
are guaranteed to be defined. This requires having arm64's irq.c
explicitly include <asm/stacktrace.h>, and I've taken the opportunity to
sort the includes, which were slightly out of order.
There should be no functional change as a result of this patch.
Signed-off-by: Mark Rutland <mark.rutland@arm.com>
Cc: Catalin Marinas <catalin.marinas@arm.com>
Cc: Kees Cook <keescook@chromium.org>
Cc: Will Deacon <will@kernel.org>
Reviewed-by: Kees Cook <keescook@chromium.org>
Reviewed-by: Mark Brown <broonie@kernel.org>
Link: https://lore.kernel.org/r/20221117120902.3974163-3-mark.rutland@arm.com
Signed-off-by: Will Deacon <will@kernel.org>
110 lines
2.7 KiB
C
110 lines
2.7 KiB
C
/* SPDX-License-Identifier: GPL-2.0-only */
|
|
/*
|
|
* Copyright (C) 2012 ARM Ltd.
|
|
*/
|
|
#ifndef __ASM_STACKTRACE_H
|
|
#define __ASM_STACKTRACE_H
|
|
|
|
#include <linux/percpu.h>
|
|
#include <linux/sched.h>
|
|
#include <linux/sched/task_stack.h>
|
|
#include <linux/llist.h>
|
|
|
|
#include <asm/memory.h>
|
|
#include <asm/pointer_auth.h>
|
|
#include <asm/ptrace.h>
|
|
#include <asm/sdei.h>
|
|
|
|
#include <asm/stacktrace/common.h>
|
|
|
|
extern void dump_backtrace(struct pt_regs *regs, struct task_struct *tsk,
|
|
const char *loglvl);
|
|
|
|
DECLARE_PER_CPU(unsigned long *, irq_stack_ptr);
|
|
|
|
static inline struct stack_info stackinfo_get_irq(void)
|
|
{
|
|
unsigned long low = (unsigned long)raw_cpu_read(irq_stack_ptr);
|
|
unsigned long high = low + IRQ_STACK_SIZE;
|
|
|
|
return (struct stack_info) {
|
|
.low = low,
|
|
.high = high,
|
|
};
|
|
}
|
|
|
|
static inline bool on_irq_stack(unsigned long sp, unsigned long size)
|
|
{
|
|
struct stack_info info = stackinfo_get_irq();
|
|
return stackinfo_on_stack(&info, sp, size);
|
|
}
|
|
|
|
static inline struct stack_info stackinfo_get_task(const struct task_struct *tsk)
|
|
{
|
|
unsigned long low = (unsigned long)task_stack_page(tsk);
|
|
unsigned long high = low + THREAD_SIZE;
|
|
|
|
return (struct stack_info) {
|
|
.low = low,
|
|
.high = high,
|
|
};
|
|
}
|
|
|
|
static inline bool on_task_stack(const struct task_struct *tsk,
|
|
unsigned long sp, unsigned long size)
|
|
{
|
|
struct stack_info info = stackinfo_get_task(tsk);
|
|
return stackinfo_on_stack(&info, sp, size);
|
|
}
|
|
|
|
#define on_thread_stack() (on_task_stack(current, current_stack_pointer, 1))
|
|
|
|
#ifdef CONFIG_VMAP_STACK
|
|
DECLARE_PER_CPU(unsigned long [OVERFLOW_STACK_SIZE/sizeof(long)], overflow_stack);
|
|
|
|
static inline struct stack_info stackinfo_get_overflow(void)
|
|
{
|
|
unsigned long low = (unsigned long)raw_cpu_ptr(overflow_stack);
|
|
unsigned long high = low + OVERFLOW_STACK_SIZE;
|
|
|
|
return (struct stack_info) {
|
|
.low = low,
|
|
.high = high,
|
|
};
|
|
}
|
|
#else
|
|
#define stackinfo_get_overflow() stackinfo_get_unknown()
|
|
#endif
|
|
|
|
#if defined(CONFIG_ARM_SDE_INTERFACE) && defined(CONFIG_VMAP_STACK)
|
|
DECLARE_PER_CPU(unsigned long *, sdei_stack_normal_ptr);
|
|
DECLARE_PER_CPU(unsigned long *, sdei_stack_critical_ptr);
|
|
|
|
static inline struct stack_info stackinfo_get_sdei_normal(void)
|
|
{
|
|
unsigned long low = (unsigned long)raw_cpu_read(sdei_stack_normal_ptr);
|
|
unsigned long high = low + SDEI_STACK_SIZE;
|
|
|
|
return (struct stack_info) {
|
|
.low = low,
|
|
.high = high,
|
|
};
|
|
}
|
|
|
|
static inline struct stack_info stackinfo_get_sdei_critical(void)
|
|
{
|
|
unsigned long low = (unsigned long)raw_cpu_read(sdei_stack_critical_ptr);
|
|
unsigned long high = low + SDEI_STACK_SIZE;
|
|
|
|
return (struct stack_info) {
|
|
.low = low,
|
|
.high = high,
|
|
};
|
|
}
|
|
#else
|
|
#define stackinfo_get_sdei_normal() stackinfo_get_unknown()
|
|
#define stackinfo_get_sdei_critical() stackinfo_get_unknown()
|
|
#endif
|
|
|
|
#endif /* __ASM_STACKTRACE_H */
|