Hugh Dickins 2cdb598f1c memcg: fix endless loop in __mem_cgroup_iter_next() ...

commit ce48225fe3 upstream.

Commit 0eef615665 ("memcg: fix css reference leak and endless loop in
mem_cgroup_iter") got the interaction with the commit a few before it
d8ad305597 ("mm/memcg: iteration skip memcgs not yet fully
initialized") slightly wrong, and we didn't notice at the time.

It's elusive, and harder to get than the original, but for a couple of
days before rc1, I several times saw a endless loop similar to that
supposedly being fixed.

This time it was a tighter loop in __mem_cgroup_iter_next(): because we
can get here when our root has already been offlined, and the ordering
of conditions was such that we then just cycled around forever.

Fixes: 0eef615665 ("memcg: fix css reference leak and endless loop in mem_cgroup_iter").
Signed-off-by: Hugh Dickins <hughd@google.com>
Acked-by: Michal Hocko <mhocko@suse.cz>
Cc: Johannes Weiner <hannes@cmpxchg.org>
Cc: Greg Thelen <gthelen@google.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

2014-03-23 21:43:59 -07:00

..

backing-dev.c

mm/backing-dev.c: check user buffer length before copying data to the related user buffer

2013-09-11 15:58:03 -07:00

balloon_compaction.c

mm: introduce a common interface for balloon pages mobility

2012-12-11 17:22:26 -08:00

bootmem.c

mm/bootmem.c: remove unused local `map'

2013-11-13 12:09:09 +09:00

bounce.c

mm/bounce.c: fix a regression where MS_SNAP_STABLE (stable pages snapshotting) was ignored

2013-09-30 14:31:02 -07:00

cleancache.c

mm: cleancache: clean up cleancache_enabled

2013-04-30 17:04:01 -07:00

compaction.c

mm/compaction: respect ignore_skip_hint in update_pageblock_skip

2013-12-18 19:04:52 -08:00

debug-pagealloc.c

mm, x86: Remove debug_pagealloc_enabled

2011-12-06 09:24:07 +01:00

dmapool.c

dmapool: make DMAPOOL_DEBUG detect corruption of free marker

2012-12-11 17:22:24 -08:00

fadvise.c

teach SYSCALL_DEFINE<n> how to deal with long long/unsigned long long

2013-03-03 22:46:22 -05:00

failslab.c

switch debugfs to umode_t

2012-01-03 22:54:56 -05:00

filemap_xip.c

seqcount: Add lockdep functionality to seqcount/seqlock structures

2013-11-06 12:40:26 +01:00

filemap.c

mm: drop actor argument of do_generic_file_read()

2013-11-15 09:32:13 +09:00

fremap.c

mm: fix use-after-free in sys_remap_file_pages

2014-01-02 14:40:30 -08:00

frontswap.c

frontswap: fix incorrect zeroing and allocation size for frontswap_map

2013-06-12 16:29:46 -07:00

highmem.c

Merge tag 'virtio-next-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/rusty/linux

2012-12-20 08:37:05 -08:00

huge_memory.c

mm: include VM_MIXEDMAP flag in the VM_SPECIAL list to avoid m(un)locking

2014-03-23 21:43:58 -07:00

hugetlb_cgroup.c

cgroup: pass around cgroup_subsys_state instead of cgroup in file methods

2013-08-08 20:11:24 -04:00

hugetlb.c

mm: hugetlbfs: fix hugetlbfs optimization

2013-11-21 16:42:27 -08:00

hwpoison-inject.c

mm/hwpoison: fix the lack of one reference count against poisoned page

2013-09-30 14:31:03 -07:00

init-mm.c

atomic: use <linux/atomic.h>

2011-07-26 16:49:47 -07:00

internal.h

mm/page-writeback.c: do not count anon pages as dirtyable memory

2014-02-13 13:55:29 -08:00

interval_tree.c

mm: add CONFIG_DEBUG_VM_RB build option

2012-10-09 16:22:42 +09:00

Kconfig

mm: add missing dependency in Kconfig

2013-12-18 19:04:52 -08:00

Kconfig.debug

mm: more intensive memory corruption debugging

2012-01-10 16:30:42 -08:00

kmemcheck.c

…

kmemleak-test.c

kmemleak: remove memset by using kzalloc

2011-01-27 18:31:51 +00:00

kmemleak.c

mm: kmemleak: avoid false negatives on vmalloc'ed objects

2013-11-13 12:09:07 +09:00

ksm.c

ksm: remove redundant __GFP_ZERO from kcalloc

2013-11-13 12:09:02 +09:00

list_lru.c

mm: list_lru: fix almost infinite loop causing effective livelock

2013-10-30 12:57:46 -07:00

maccess.c

mm: Map most files to use export.h instead of module.h

2011-10-31 09:20:12 -04:00

madvise.c

mm/hwpoison: fix traversal of hugetlbfs pages to avoid printk flood

2013-09-30 14:31:02 -07:00

Makefile

list: add a new LRU list type

2013-09-10 18:56:30 -04:00

memblock.c

mm/memblock.c: introduce bottom-up allocation mode

2013-11-13 12:09:08 +09:00

memcontrol.c

memcg: fix endless loop in __mem_cgroup_iter_next()

2014-03-23 21:43:59 -07:00

memory_hotplug.c

mem-hotplug: introduce movable_node boot option

2013-11-13 12:09:09 +09:00

memory-failure.c

mm/memory-failure.c: move refcount only in !MF_COUNT_INCREASED

2014-02-22 13:34:41 -08:00

memory.c

mm, thp: fix infinite loop on memcg OOM

2014-03-06 22:06:29 -08:00

mempolicy.c

mm: numa: initialise numa balancing after jump label initialisation

2014-02-13 13:55:37 -08:00

mempool.c

mm/mempool.c: convert kmalloc_node(...GFP_ZERO...) to kzalloc_node(...)

2013-09-11 15:58:14 -07:00

migrate.c

aio/migratepages: make aio migrate pages sane

2013-12-21 17:56:08 -05:00

mincore.c

swap: make each swap partition have one address_space

2013-02-23 17:50:17 -08:00

mlock.c

mm: munlock: fix deadlock in __munlock_pagevec()

2014-01-02 14:40:30 -08:00

mm_init.c

mm: numa: Change page last {nid,pid} into {cpu,pid}

2013-10-09 14:47:45 +02:00

mmap.c

mm: ignore VM_SOFTDIRTY on VMA merging

2014-02-13 13:55:29 -08:00

mmu_context.c

mm: remove old aio use_mm() comment

2013-05-07 18:38:27 -07:00

mmu_notifier.c

treewide: relase -> release

2013-06-28 14:34:33 +02:00

mmzone.c

mm: numa: Change page last {nid,pid} into {cpu,pid}

2013-10-09 14:47:45 +02:00

mprotect.c

mm: fix TLB flush race between migration, and change_protection_range

2013-12-18 19:04:51 -08:00

mremap.c

mm: revert mremap pud_free anti-fix

2013-10-16 21:35:53 -07:00

msync.c

…

nobootmem.c

mm/nobootmem.c: have __free_pages_memory() free in larger chunks.

2013-11-13 12:09:04 +09:00

nommu.c

Merge branch 'akpm' (patches from Andrew Morton)

2013-11-13 15:45:43 +09:00

oom_kill.c

mm, oom: base root bonus on current usage

2014-02-13 13:55:37 -08:00

page_alloc.c

mm: page_alloc: exempt GFP_THISNODE allocations from zone fairness

2014-03-23 21:43:58 -07:00

page_cgroup.c

memcontrol: use N_MEMORY instead N_HIGH_MEMORY

2012-12-12 17:38:32 -08:00

page_io.c

aio: Kill aio_rw_vect_retry()

2013-07-30 11:53:12 -04:00

page_isolation.c

mm: memory-hotplug: enable memory hotplug to handle hugepage

2013-09-11 15:57:48 -07:00

page-writeback.c

mm: __set_page_dirty_nobuffers() uses spin_lock_irqsave() instead of spin_lock_irq()

2014-02-20 11:10:09 -08:00

pagewalk.c

mm/pagewalk.c: fix walk_page_range() access of wrong PTEs

2013-10-30 14:27:03 -07:00

percpu-km.c

percpu: clear memory allocated with the km allocator

2010-10-02 10:28:42 +03:00

percpu-vm.c

mm: fix kernel-doc warnings

2012-06-20 14:39:36 -07:00

percpu.c

percpu: fix bootmem error handling in pcpu_page_first_chunk()

2013-09-23 10:51:45 -04:00

pgtable-generic.c

mm: fix TLB flush race between migration, and change_protection_range

2013-12-18 19:04:51 -08:00

process_vm_access.c

Fix: compat_rw_copy_check_uvector() misuse in aio, readv, writev, and security keys

2013-03-12 11:05:45 -07:00

quicklist.c

mm: delete various needless include <linux/module.h>

2011-10-31 09:20:11 -04:00

readahead.c

readahead: fix sequential read cache miss detection

2013-11-13 12:09:09 +09:00

rmap.c

mm/hugetlb: check for pte NULL pointer in __page_check_address()

2013-12-18 19:04:52 -08:00

shmem.c

security: shmem: implement kernel private shmem inodes

2013-12-02 11:24:19 +00:00

slab_common.c

memcg, kmem: rename cache_from_memcg to cache_from_memcg_idx

2013-11-13 12:09:10 +09:00

slab.c

Merge branch 'slab/next' of git://git.kernel.org/pub/scm/linux/kernel/git/penberg/linux

2013-11-22 08:10:34 -08:00

slab.h

memcg, kmem: rename cache_from_memcg to cache_from_memcg_idx

2013-11-13 12:09:10 +09:00

slob.c

mm/sl[aou]b: Move kmallocXXX functions to common code

2013-09-04 20:51:33 +03:00

slub.c

slub: Fix calculation of cpu slabs

2014-02-13 13:55:30 -08:00

sparse-vmemmap.c

sparse-vmemmap: specify vmemmap population range in bytes

2013-04-29 15:54:35 -07:00

sparse.c

mm/sparsemem: fix a bug in free_map_bootmem when CONFIG_SPARSEMEM_VMEMMAP

2013-11-13 12:09:06 +09:00

swap_state.c

lib/radix-tree.c: make radix_tree_node_alloc() work correctly within interrupt

2013-09-11 15:59:36 -07:00

swap.c

mm: hugetlbfs: fix hugetlbfs optimization

2013-11-21 16:42:27 -08:00

swapfile.c

mm/swap: fix race on swap_info reuse between swapoff and swapon

2014-02-20 11:10:09 -08:00

truncate.c

truncate: drop 'oldsize' truncate_pagecache() parameter

2013-09-12 15:38:02 -07:00

util.c

mm: fix crash when using XFS on loopback

2014-01-15 14:19:42 +07:00

vmalloc.c

mm: kmemleak: avoid false negatives on vmalloc'ed objects

2013-11-13 12:09:07 +09:00

vmpressure.c

Merge branch 'for-3.12' of git://git.kernel.org/pub/scm/linux/kernel/git/tj/cgroup

2013-09-03 18:25:03 -07:00

vmscan.c

mm/page-writeback.c: do not count anon pages as dirtyable memory

2014-02-13 13:55:29 -08:00

vmstat.c

mm: numa: return the number of base pages altered by protection changes

2013-11-13 12:09:11 +09:00

zbud.c

mm/zbud: fix some trivial typos in comments

2013-09-11 15:57:35 -07:00

zswap.c

mm/zswap: refactor the get/put routines

2013-11-13 12:09:11 +09:00