mirror of
https://github.com/raspberrypi/linux.git
synced 2025-12-15 14:32:06 +00:00
49d371ab9d
The .remove() callback for a platform driver returns an int which makes many driver authors wrongly assume it's possible to do error handling by returning an error code. However the value returned is ignored (apart from emitting a warning) and this typically results in resource leaks. To improve here there is a quest to make the remove callback return void. In the first step of this quest all drivers are converted to .remove_new(), which already returns void. Eventually after all drivers are converted, .remove_new() will be renamed to .remove(). Trivially convert this driver from always returning zero in the remove callback to the void returning variant. Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de> Link: https://lore.kernel.org/r/20230927081040.2198742-28-u.kleine-koenig@pengutronix.de Reviewed-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
88 lines
2.5 KiB
C
88 lines
2.5 KiB
C
// SPDX-License-Identifier: GPL-2.0
|
|
/*
|
|
* Siemens SIMATIC IPC driver for CMOS battery monitoring
|
|
*
|
|
* Copyright (c) Siemens AG, 2023
|
|
*
|
|
* Authors:
|
|
* Henning Schild <henning.schild@siemens.com>
|
|
*/
|
|
|
|
#include <linux/gpio/machine.h>
|
|
#include <linux/gpio/consumer.h>
|
|
#include <linux/kernel.h>
|
|
#include <linux/module.h>
|
|
#include <linux/platform_device.h>
|
|
#include <linux/platform_data/x86/simatic-ipc-base.h>
|
|
|
|
#include "simatic-ipc-batt.h"
|
|
|
|
static struct gpiod_lookup_table *batt_lookup_table;
|
|
|
|
static struct gpiod_lookup_table simatic_ipc_batt_gpio_table_227g = {
|
|
.table = {
|
|
GPIO_LOOKUP_IDX("gpio-f7188x-7", 6, NULL, 0, GPIO_ACTIVE_HIGH),
|
|
GPIO_LOOKUP_IDX("gpio-f7188x-7", 5, NULL, 1, GPIO_ACTIVE_HIGH),
|
|
GPIO_LOOKUP_IDX("INTC1020:01", 66, NULL, 2, GPIO_ACTIVE_HIGH),
|
|
{} /* Terminating entry */
|
|
},
|
|
};
|
|
|
|
static struct gpiod_lookup_table simatic_ipc_batt_gpio_table_bx_39a = {
|
|
.table = {
|
|
GPIO_LOOKUP_IDX("gpio-f7188x-6", 4, NULL, 0, GPIO_ACTIVE_HIGH),
|
|
GPIO_LOOKUP_IDX("gpio-f7188x-6", 3, NULL, 1, GPIO_ACTIVE_HIGH),
|
|
{} /* Terminating entry */
|
|
},
|
|
};
|
|
|
|
static struct gpiod_lookup_table simatic_ipc_batt_gpio_table_bx_59a = {
|
|
.table = {
|
|
GPIO_LOOKUP_IDX("gpio-f7188x-7", 6, NULL, 0, GPIO_ACTIVE_HIGH),
|
|
GPIO_LOOKUP_IDX("gpio-f7188x-7", 5, NULL, 1, GPIO_ACTIVE_HIGH),
|
|
GPIO_LOOKUP_IDX("INTC1056:00", 438, NULL, 2, GPIO_ACTIVE_HIGH),
|
|
{} /* Terminating entry */
|
|
}
|
|
};
|
|
|
|
static void simatic_ipc_batt_f7188x_remove(struct platform_device *pdev)
|
|
{
|
|
simatic_ipc_batt_remove(pdev, batt_lookup_table);
|
|
}
|
|
|
|
static int simatic_ipc_batt_f7188x_probe(struct platform_device *pdev)
|
|
{
|
|
const struct simatic_ipc_platform *plat = pdev->dev.platform_data;
|
|
|
|
switch (plat->devmode) {
|
|
case SIMATIC_IPC_DEVICE_227G:
|
|
batt_lookup_table = &simatic_ipc_batt_gpio_table_227g;
|
|
break;
|
|
case SIMATIC_IPC_DEVICE_BX_39A:
|
|
batt_lookup_table = &simatic_ipc_batt_gpio_table_bx_39a;
|
|
break;
|
|
case SIMATIC_IPC_DEVICE_BX_59A:
|
|
batt_lookup_table = &simatic_ipc_batt_gpio_table_bx_59a;
|
|
break;
|
|
default:
|
|
return -ENODEV;
|
|
}
|
|
|
|
return simatic_ipc_batt_probe(pdev, batt_lookup_table);
|
|
}
|
|
|
|
static struct platform_driver simatic_ipc_batt_driver = {
|
|
.probe = simatic_ipc_batt_f7188x_probe,
|
|
.remove_new = simatic_ipc_batt_f7188x_remove,
|
|
.driver = {
|
|
.name = KBUILD_MODNAME,
|
|
},
|
|
};
|
|
|
|
module_platform_driver(simatic_ipc_batt_driver);
|
|
|
|
MODULE_LICENSE("GPL");
|
|
MODULE_ALIAS("platform:" KBUILD_MODNAME);
|
|
MODULE_SOFTDEP("pre: simatic-ipc-batt gpio_f7188x platform:elkhartlake-pinctrl platform:alderlake-pinctrl");
|
|
MODULE_AUTHOR("Henning Schild <henning.schild@siemens.com>");
|