Igor Pylypiv
58768b0563
ata: libata-scsi: Fix CDL control
...
Delete extra checks for the ATA_DFLAG_CDL_ENABLED flag that prevent
SET FEATURES command from being issued to a drive when NCQ commands
are active.
ata_mselect_control_ata_feature() sets / clears the ATA_DFLAG_CDL_ENABLED
flag during the translation of MODE SELECT to SET FEATURES. If SET FEATURES
gets deferred due to outstanding NCQ commands, the original MODE SELECT
command will be re-queued. When the re-queued MODE SELECT goes through
the ata_mselect_control_ata_feature() translation again, SET FEATURES
will not be issued because ATA_DFLAG_CDL_ENABLED has been already set or
cleared by the initial translation of MODE SELECT.
The ATA_DFLAG_CDL_ENABLED checks in ata_mselect_control_ata_feature()
are safe to remove because scsi_cdl_enable() implements a similar logic
that avoids enabling CDL if it has been enabled already.
Fixes: 17e897a456 ("ata: libata-scsi: Improve CDL control")
Cc: stable@vger.kernel.org
Signed-off-by: Igor Pylypiv <ipylypiv@google.com >
Reviewed-by: Niklas Cassel <cassel@kernel.org >
Signed-off-by: Damien Le Moal <dlemoal@kernel.org >
2025-08-14 18:58:12 +09:00
..
2025-07-16 09:31:43 +02:00
2024-10-30 16:07:36 -05:00
2025-01-09 17:52:17 +09:00
2025-01-09 17:52:17 +09:00
2025-07-16 09:31:43 +02:00
2025-07-16 09:31:43 +02:00
2024-10-17 09:55:08 +02:00
2025-07-16 09:31:43 +02:00
2024-10-17 09:55:08 +02:00
2024-10-17 09:55:08 +02:00
2023-08-02 17:37:06 +09:00
2024-10-17 09:55:08 +02:00
2025-07-16 09:31:43 +02:00
2024-10-17 09:55:08 +02:00
2025-01-15 15:21:27 +01:00
2024-10-17 09:55:08 +02:00
2024-10-17 09:55:08 +02:00
2025-07-16 09:31:43 +02:00
2025-07-16 09:31:43 +02:00
2025-03-26 19:49:02 -07:00
2024-12-03 05:10:20 +01:00
2025-07-31 12:56:21 +09:00
2025-06-30 10:25:45 +09:00
2025-02-10 11:54:38 +01:00
2025-07-31 12:56:21 +09:00
2025-06-10 14:08:24 +02:00
2025-08-01 08:43:05 +09:00
2025-08-14 18:42:16 +09:00
2020-03-26 10:28:19 -06:00
2025-07-16 09:31:43 +02:00
2025-07-31 12:56:21 +09:00
2025-08-14 18:58:12 +09:00
2025-07-16 09:31:43 +02:00
2023-01-04 13:36:26 +09:00
2025-07-09 15:48:17 +02:00
2024-07-04 11:52:31 +02:00
2025-03-17 12:16:58 -07:00
2025-07-16 09:31:43 +02:00
2023-02-22 13:35:51 -08:00
2025-07-16 09:31:43 +02:00
2025-07-16 09:31:43 +02:00
2025-07-16 09:31:43 +02:00
2024-10-17 09:55:08 +02:00
2025-07-16 09:31:43 +02:00
2025-07-16 09:31:43 +02:00
2024-12-03 05:10:20 +01:00
2023-08-24 08:09:59 +09:00
2023-03-24 19:19:19 -04:00
2023-03-24 19:19:19 -04:00
2024-07-30 07:10:30 +09:00
2023-03-24 19:19:19 -04:00
2023-03-24 19:19:19 -04:00
2025-06-10 14:26:27 +02:00
2023-03-24 19:19:19 -04:00
2025-07-16 09:31:43 +02:00
2025-07-16 09:31:43 +02:00
2024-10-17 09:55:08 +02:00
2024-10-17 09:55:08 +02:00
2024-10-17 09:55:08 +02:00
2025-07-16 09:31:43 +02:00
2023-03-24 19:19:19 -04:00
2025-07-16 09:31:43 +02:00
2025-07-16 09:31:43 +02:00
2025-07-16 09:31:43 +02:00
2024-10-17 09:55:08 +02:00
2023-11-20 09:22:26 +09:00
2024-07-30 07:09:54 +09:00
2025-07-16 09:31:43 +02:00
2024-10-17 09:55:08 +02:00
2025-07-16 09:31:43 +02:00
2024-05-07 07:23:31 +09:00
2025-08-01 08:43:08 +09:00
2025-07-16 09:31:43 +02:00
2024-10-17 09:55:08 +02:00
2025-07-16 09:31:43 +02:00
2023-03-24 19:19:19 -04:00
2023-03-24 19:19:19 -04:00
2025-07-16 09:31:43 +02:00
2023-07-28 08:52:42 +09:00
2025-07-16 09:31:43 +02:00
2024-10-17 09:55:08 +02:00
2025-07-16 09:31:43 +02:00
2025-07-16 09:31:43 +02:00
2025-07-16 09:31:43 +02:00
2025-07-04 10:36:00 +02:00
2023-03-24 19:19:19 -04:00
2025-08-01 08:43:11 +09:00
2024-12-03 05:10:20 +01:00
2024-10-17 09:55:08 +02:00
2025-04-08 12:36:03 +09:00
2024-10-01 09:22:02 +02:00
2024-10-17 09:55:08 +02:00
2025-07-16 09:31:43 +02:00
2023-03-24 19:19:19 -04:00
2023-03-24 19:19:19 -04:00
2023-03-24 19:19:19 -04:00
2024-07-30 07:10:08 +09:00
2023-03-24 19:19:19 -04:00
2025-07-16 09:31:43 +02:00
2025-07-16 09:31:43 +02:00
2025-07-16 09:31:43 +02:00
2025-07-16 09:31:43 +02:00
2025-07-16 09:31:43 +02:00
2025-07-16 09:31:43 +02:00
2025-07-16 09:31:43 +02:00
2024-12-16 22:36:27 +09:00
2024-12-11 13:18:25 +09:00
2025-07-16 09:31:43 +02:00
2025-07-16 09:31:43 +02:00
2025-07-16 09:31:43 +02:00
2025-07-16 09:31:43 +02:00
2025-07-16 09:31:43 +02:00
2025-07-16 09:31:43 +02:00
2025-07-16 09:31:43 +02:00
2025-07-16 09:31:43 +02:00
2025-07-04 10:36:00 +02:00
2025-01-18 14:38:49 -06:00
2025-07-16 09:31:43 +02:00
2025-07-16 09:31:43 +02:00
2025-07-16 09:31:43 +02:00
2025-07-16 09:31:43 +02:00
2025-01-18 14:38:49 -06:00