Files
linux/net/ipv4
Eric Dumazet a148815a32 tcp: md5: fix potential overestimation of TCP option space
[ Upstream commit 9424e2e7ad ]

Back in 2008, Adam Langley fixed the corner case of packets for flows
having all of the following options : MD5 TS SACK

Since MD5 needs 20 bytes, and TS needs 12 bytes, no sack block
can be cooked from the remaining 8 bytes.

tcp_established_options() correctly sets opts->num_sack_blocks
to zero, but returns 36 instead of 32.

This means TCP cooks packets with 4 extra bytes at the end
of options, containing unitialized bytes.

Fixes: 33ad798c92 ("tcp: options clean up")
Signed-off-by: Eric Dumazet <edumazet@google.com>
Reported-by: syzbot <syzkaller@googlegroups.com>
Acked-by: Neal Cardwell <ncardwell@google.com>
Acked-by: Soheil Hassas Yeganeh <soheil@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
2019-12-21 10:57:15 +01:00
..
2018-05-16 07:24:30 +02:00
2018-04-23 10:21:24 -04:00
2018-07-24 14:10:43 -07:00
2017-10-16 21:24:25 +01:00
2019-04-17 08:38:41 +02:00
2018-02-28 11:43:28 -05:00