mirror of
https://github.com/raspberrypi/linux.git
synced 2025-12-06 01:49:46 +00:00
According to Maciej W. Rozycki <macro@orcam.me.uk>, the mips_pcibios_init() for malta adjusts root bus IO resource start address to prevent interfering with PIIX4 I/O cycle decoding. Adjusting lower bound leaves PIIX4 IO resources outside of the root bus resource and assign_fixed_resource_on_bus() does not link the resources into the resource tree. Prior to commitae81aad5c2("MIPS: PCI: Use pci_enable_resources()") the arch specific pcibios_enable_resources() did not check if the resources were assigned which diverges from what PCI core checks, effectively hiding the PIIX4 IO resources were not properly within the resource tree. After starting to use pcibios_enable_resources() from PCI core, enabling PIIX4 fails: ata_piix 0000:00:0a.1: BAR 0 [io 0x01f0-0x01f7]: not claimed; can't enable device ata_piix 0000:00:0a.1: probe with driver ata_piix failed with error -22 MIPS PCI code already has support for enforcing lower bounds using PCIBIOS_MIN_IO in pcibios_align_resource() without altering the IO window start address itself. Make malta PCI code too to use PCIBIOS_MIN_IO. Fixes:ae81aad5c2("MIPS: PCI: Use pci_enable_resources()") Reported-by: Guenter Roeck <linux@roeck-us.net> Link: https://lore.kernel.org/linux-pci/9085ab12-1559-4462-9b18-f03dcb9a4088@roeck-us.net/ Suggested-by: Maciej W. Rozycki <macro@orcam.me.uk> Link: https://lore.kernel.org/linux-pci/alpine.DEB.2.21.2510132229120.39634@angie.orcam.me.uk/ Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com> Signed-off-by: Bjorn Helgaas <bhelgaas@google.com> Tested-by: Guenter Roeck <linux@roeck-us.net> Tested-by: Maciej W. Rozycki <macro@orcam.me.uk> Acked-by: Thomas Bogendoerfer <tsbogend@alpha.franken.de> Link: https://patch.msgid.link/20251017110903.1973-1-ilpo.jarvinen@linux.intel.com
242 lines
7.3 KiB
C
242 lines
7.3 KiB
C
// SPDX-License-Identifier: GPL-2.0-only
|
|
/*
|
|
* Copyright (C) 1999, 2000, 2004, 2005 MIPS Technologies, Inc.
|
|
* All rights reserved.
|
|
* Authors: Carsten Langgaard <carstenl@mips.com>
|
|
* Maciej W. Rozycki <macro@mips.com>
|
|
*
|
|
* Copyright (C) 2004 by Ralf Baechle (ralf@linux-mips.org)
|
|
*
|
|
* MIPS boards specific PCI support.
|
|
*/
|
|
#include <linux/types.h>
|
|
#include <linux/pci.h>
|
|
#include <linux/kernel.h>
|
|
#include <linux/init.h>
|
|
|
|
#include <asm/gt64120.h>
|
|
#include <asm/mips-cps.h>
|
|
#include <asm/mips-boards/generic.h>
|
|
#include <asm/mips-boards/bonito64.h>
|
|
#include <asm/mips-boards/msc01_pci.h>
|
|
|
|
static struct resource bonito64_mem_resource = {
|
|
.name = "Bonito PCI MEM",
|
|
.flags = IORESOURCE_MEM,
|
|
};
|
|
|
|
static struct resource bonito64_io_resource = {
|
|
.name = "Bonito PCI I/O",
|
|
.start = 0x00000000UL,
|
|
.end = 0x000fffffUL,
|
|
.flags = IORESOURCE_IO,
|
|
};
|
|
|
|
static struct resource gt64120_mem_resource = {
|
|
.name = "GT-64120 PCI MEM",
|
|
.flags = IORESOURCE_MEM,
|
|
};
|
|
|
|
static struct resource gt64120_io_resource = {
|
|
.name = "GT-64120 PCI I/O",
|
|
.flags = IORESOURCE_IO,
|
|
};
|
|
|
|
static struct resource msc_mem_resource = {
|
|
.name = "MSC PCI MEM",
|
|
.flags = IORESOURCE_MEM,
|
|
};
|
|
|
|
static struct resource msc_io_resource = {
|
|
.name = "MSC PCI I/O",
|
|
.flags = IORESOURCE_IO,
|
|
};
|
|
|
|
extern struct pci_ops bonito64_pci_ops;
|
|
extern struct pci_ops gt64xxx_pci0_ops;
|
|
extern struct pci_ops msc_pci_ops;
|
|
|
|
static struct pci_controller bonito64_controller = {
|
|
.pci_ops = &bonito64_pci_ops,
|
|
.io_resource = &bonito64_io_resource,
|
|
.mem_resource = &bonito64_mem_resource,
|
|
.io_offset = 0x00000000UL,
|
|
};
|
|
|
|
static struct pci_controller gt64120_controller = {
|
|
.pci_ops = >64xxx_pci0_ops,
|
|
.io_resource = >64120_io_resource,
|
|
.mem_resource = >64120_mem_resource,
|
|
};
|
|
|
|
static struct pci_controller msc_controller = {
|
|
.pci_ops = &msc_pci_ops,
|
|
.io_resource = &msc_io_resource,
|
|
.mem_resource = &msc_mem_resource,
|
|
};
|
|
|
|
void __init mips_pcibios_init(void)
|
|
{
|
|
struct pci_controller *controller;
|
|
resource_size_t start, end, map, start1, end1, map1, map2, map3, mask;
|
|
|
|
switch (mips_revision_sconid) {
|
|
case MIPS_REVISION_SCON_GT64120:
|
|
/*
|
|
* Due to a bug in the Galileo system controller, we need
|
|
* to setup the PCI BAR for the Galileo internal registers.
|
|
* This should be done in the bios/bootprom and will be
|
|
* fixed in a later revision of YAMON (the MIPS boards
|
|
* boot prom).
|
|
*/
|
|
GT_WRITE(GT_PCI0_CFGADDR_OFS,
|
|
(0 << GT_PCI0_CFGADDR_BUSNUM_SHF) | /* Local bus */
|
|
(0 << GT_PCI0_CFGADDR_DEVNUM_SHF) | /* GT64120 dev */
|
|
(0 << GT_PCI0_CFGADDR_FUNCTNUM_SHF) | /* Function 0*/
|
|
((0x20/4) << GT_PCI0_CFGADDR_REGNUM_SHF) | /* BAR 4*/
|
|
GT_PCI0_CFGADDR_CONFIGEN_BIT);
|
|
|
|
/* Perform the write */
|
|
GT_WRITE(GT_PCI0_CFGDATA_OFS, CPHYSADDR(MIPS_GT_BASE));
|
|
|
|
/* Set up resource ranges from the controller's registers. */
|
|
start = GT_READ(GT_PCI0M0LD_OFS);
|
|
end = GT_READ(GT_PCI0M0HD_OFS);
|
|
map = GT_READ(GT_PCI0M0REMAP_OFS);
|
|
end = (end & GT_PCI_HD_MSK) | (start & ~GT_PCI_HD_MSK);
|
|
start1 = GT_READ(GT_PCI0M1LD_OFS);
|
|
end1 = GT_READ(GT_PCI0M1HD_OFS);
|
|
map1 = GT_READ(GT_PCI0M1REMAP_OFS);
|
|
end1 = (end1 & GT_PCI_HD_MSK) | (start1 & ~GT_PCI_HD_MSK);
|
|
/* Cannot support multiple windows, use the wider. */
|
|
if (end1 - start1 > end - start) {
|
|
start = start1;
|
|
end = end1;
|
|
map = map1;
|
|
}
|
|
mask = ~(start ^ end);
|
|
/* We don't support remapping with a discontiguous mask. */
|
|
BUG_ON((start & GT_PCI_HD_MSK) != (map & GT_PCI_HD_MSK) &&
|
|
mask != ~((mask & -mask) - 1));
|
|
gt64120_mem_resource.start = start;
|
|
gt64120_mem_resource.end = end;
|
|
gt64120_controller.mem_offset = (start & mask) - (map & mask);
|
|
/* Addresses are 36-bit, so do shifts in the destinations. */
|
|
gt64120_mem_resource.start <<= GT_PCI_DCRM_SHF;
|
|
gt64120_mem_resource.end <<= GT_PCI_DCRM_SHF;
|
|
gt64120_mem_resource.end |= (1 << GT_PCI_DCRM_SHF) - 1;
|
|
gt64120_controller.mem_offset <<= GT_PCI_DCRM_SHF;
|
|
|
|
start = GT_READ(GT_PCI0IOLD_OFS);
|
|
end = GT_READ(GT_PCI0IOHD_OFS);
|
|
map = GT_READ(GT_PCI0IOREMAP_OFS);
|
|
end = (end & GT_PCI_HD_MSK) | (start & ~GT_PCI_HD_MSK);
|
|
mask = ~(start ^ end);
|
|
/* We don't support remapping with a discontiguous mask. */
|
|
BUG_ON((start & GT_PCI_HD_MSK) != (map & GT_PCI_HD_MSK) &&
|
|
mask != ~((mask & -mask) - 1));
|
|
gt64120_io_resource.start = map & mask;
|
|
gt64120_io_resource.end = (map & mask) | ~mask;
|
|
gt64120_controller.io_offset = 0;
|
|
/* Addresses are 36-bit, so do shifts in the destinations. */
|
|
gt64120_io_resource.start <<= GT_PCI_DCRM_SHF;
|
|
gt64120_io_resource.end <<= GT_PCI_DCRM_SHF;
|
|
gt64120_io_resource.end |= (1 << GT_PCI_DCRM_SHF) - 1;
|
|
|
|
controller = >64120_controller;
|
|
break;
|
|
|
|
case MIPS_REVISION_SCON_BONITO:
|
|
/* Set up resource ranges from the controller's registers. */
|
|
map = BONITO_PCIMAP;
|
|
map1 = (BONITO_PCIMAP & BONITO_PCIMAP_PCIMAP_LO0) >>
|
|
BONITO_PCIMAP_PCIMAP_LO0_SHIFT;
|
|
map2 = (BONITO_PCIMAP & BONITO_PCIMAP_PCIMAP_LO1) >>
|
|
BONITO_PCIMAP_PCIMAP_LO1_SHIFT;
|
|
map3 = (BONITO_PCIMAP & BONITO_PCIMAP_PCIMAP_LO2) >>
|
|
BONITO_PCIMAP_PCIMAP_LO2_SHIFT;
|
|
/* Combine as many adjacent windows as possible. */
|
|
map = map1;
|
|
start = BONITO_PCILO0_BASE;
|
|
end = 1;
|
|
if (map3 == map2 + 1) {
|
|
map = map2;
|
|
start = BONITO_PCILO1_BASE;
|
|
end++;
|
|
}
|
|
if (map2 == map1 + 1) {
|
|
map = map1;
|
|
start = BONITO_PCILO0_BASE;
|
|
end++;
|
|
}
|
|
bonito64_mem_resource.start = start;
|
|
bonito64_mem_resource.end = start +
|
|
BONITO_PCIMAP_WINBASE(end) - 1;
|
|
bonito64_controller.mem_offset = start -
|
|
BONITO_PCIMAP_WINBASE(map);
|
|
|
|
controller = &bonito64_controller;
|
|
break;
|
|
|
|
case MIPS_REVISION_SCON_SOCIT:
|
|
case MIPS_REVISION_SCON_ROCIT:
|
|
case MIPS_REVISION_SCON_SOCITSC:
|
|
case MIPS_REVISION_SCON_SOCITSCP:
|
|
/* Set up resource ranges from the controller's registers. */
|
|
MSC_READ(MSC01_PCI_SC2PMBASL, start);
|
|
MSC_READ(MSC01_PCI_SC2PMMSKL, mask);
|
|
MSC_READ(MSC01_PCI_SC2PMMAPL, map);
|
|
msc_mem_resource.start = start & mask;
|
|
msc_mem_resource.end = (start & mask) | ~mask;
|
|
msc_controller.mem_offset = (start & mask) - (map & mask);
|
|
if (mips_cps_numiocu(0)) {
|
|
write_gcr_reg0_base(start);
|
|
write_gcr_reg0_mask(mask |
|
|
CM_GCR_REGn_MASK_CMTGT_IOCU0);
|
|
}
|
|
MSC_READ(MSC01_PCI_SC2PIOBASL, start);
|
|
MSC_READ(MSC01_PCI_SC2PIOMSKL, mask);
|
|
MSC_READ(MSC01_PCI_SC2PIOMAPL, map);
|
|
msc_io_resource.start = map & mask;
|
|
msc_io_resource.end = (map & mask) | ~mask;
|
|
msc_controller.io_offset = 0;
|
|
ioport_resource.end = ~mask;
|
|
if (mips_cps_numiocu(0)) {
|
|
write_gcr_reg1_base(start);
|
|
write_gcr_reg1_mask(mask |
|
|
CM_GCR_REGn_MASK_CMTGT_IOCU0);
|
|
}
|
|
/* If ranges overlap I/O takes precedence. */
|
|
start = start & mask;
|
|
end = start | ~mask;
|
|
if ((start >= msc_mem_resource.start &&
|
|
start <= msc_mem_resource.end) ||
|
|
(end >= msc_mem_resource.start &&
|
|
end <= msc_mem_resource.end)) {
|
|
/* Use the larger space. */
|
|
start = max(start, msc_mem_resource.start);
|
|
end = min(end, msc_mem_resource.end);
|
|
if (start - msc_mem_resource.start >=
|
|
msc_mem_resource.end - end)
|
|
msc_mem_resource.end = start - 1;
|
|
else
|
|
msc_mem_resource.start = end + 1;
|
|
}
|
|
|
|
controller = &msc_controller;
|
|
break;
|
|
default:
|
|
return;
|
|
}
|
|
|
|
/* PIIX4 ACPI starts at 0x1000 */
|
|
PCIBIOS_MIN_IO = 0x1000;
|
|
|
|
iomem_resource.end &= 0xfffffffffULL; /* 64 GB */
|
|
ioport_resource.end = controller->io_resource->end;
|
|
|
|
controller->io_map_base = mips_io_port_base;
|
|
|
|
register_pci_controller(controller);
|
|
}
|