Vasily Gorbik
f8c2602733
s390/ftrace: fix ftrace_update_ftrace_func implementation
s390 enforces DYNAMIC_FTRACE if FUNCTION_TRACER is selected.
At the same time implementation of ftrace_caller is not compliant with
HAVE_DYNAMIC_FTRACE since it doesn't provide implementation of
ftrace_update_ftrace_func() and calls ftrace_trace_function() directly.
The subtle difference is that during ftrace code patching ftrace
replaces function tracer via ftrace_update_ftrace_func() and activates
it back afterwards. Unexpected direct calls to ftrace_trace_function()
during ftrace code patching leads to nullptr-dereferences when tracing
is activated for one of functions which are used during code patching.
Those function currently are:
copy_from_kernel_nofault()
copy_from_kernel_nofault_allowed()
preempt_count_sub() [with debug_defconfig]
preempt_count_add() [with debug_defconfig]
Corresponding KASAN report:
BUG: KASAN: nullptr-dereference in function_trace_call+0x316/0x3b0
Read of size 4 at addr 0000000000001e08 by task migration/0/15
CPU: 0 PID: 15 Comm: migration/0 Tainted: G B 5.13.0-41423-g08316af3644d
Hardware name: IBM 3906 M04 704 (LPAR)
Stopper: multi_cpu_stop+0x0/0x3e0 <- stop_machine_cpuslocked+0x1e4/0x218
Call Trace:
[<0000000001f77caa>] show_stack+0x16a/0x1d0
[<0000000001f8de42>] dump_stack+0x15a/0x1b0
[<0000000001f81d56>] print_address_description.constprop.0+0x66/0x2e0
[<000000000082b0ca>] kasan_report+0x152/0x1c0
[<00000000004cfd8e>] function_trace_call+0x316/0x3b0
[<0000000001fb7082>] ftrace_caller+0x7a/0x7e
[<00000000006bb3e6>] copy_from_kernel_nofault_allowed+0x6/0x10
[<00000000006bb42e>] copy_from_kernel_nofault+0x3e/0xd0
[<000000000014605c>] ftrace_make_call+0xb4/0x1f8
[<000000000047a1b4>] ftrace_replace_code+0x134/0x1d8
[<000000000047a6e0>] ftrace_modify_all_code+0x120/0x1d0
[<000000000047a7ec>] __ftrace_modify_code+0x5c/0x78
[<000000000042395c>] multi_cpu_stop+0x224/0x3e0
[<0000000000423212>] cpu_stopper_thread+0x33a/0x5a0
[<0000000000243ff2>] smpboot_thread_fn+0x302/0x708
[<00000000002329ea>] kthread+0x342/0x408
[<00000000001066b2>] __ret_from_fork+0x92/0xf0
[<0000000001fb57fa>] ret_from_fork+0xa/0x30
The buggy address belongs to the page:
page:(____ptrval____) refcount:1 mapcount:0 mapping:0000000000000000 index:0x0 pfn:0x1
flags: 0x1ffff00000001000(reserved|node=0|zone=0|lastcpupid=0x1ffff)
raw: 1ffff00000001000 0000040000000048 0000040000000048 0000000000000000
raw: 0000000000000000 0000000000000000 ffffffff00000001 0000000000000000
page dumped because: kasan: bad access detected
Memory state around the buggy address:
0000000000001d00: f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7
0000000000001d80: f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7
>0000000000001e00: f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7
^
0000000000001e80: f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7
0000000000001f00: f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7 f7
==================================================================
To fix that introduce ftrace_func callback to be called from
ftrace_caller and update it in ftrace_update_ftrace_func().
Fixes: 4cc9bed034 ("[S390] cleanup ftrace backend functions")
Cc: stable@vger.kernel.org
Reviewed-by: Heiko Carstens <hca@linux.ibm.com>
Signed-off-by: Vasily Gorbik <gor@linux.ibm.com>
Signed-off-by: Heiko Carstens <hca@linux.ibm.com>
2021-07-15 12:54:58 +02:00
..
2021-01-19 12:29:26 +01:00
2017-11-02 11:10:55 +01:00
2021-07-08 15:37:28 +02:00
2019-06-15 12:25:05 +02:00
2018-03-28 08:38:27 +02:00
2021-02-09 15:57:06 +01:00
2021-07-08 22:12:17 +02:00
2018-10-09 11:20:50 +02:00
2020-12-10 21:02:08 +01:00
2020-07-20 10:55:45 +02:00
2017-11-02 11:10:55 +01:00
2021-04-15 17:47:42 +02:00
2021-05-26 13:20:49 +02:00
2018-02-05 07:51:41 +01:00
2021-06-18 16:41:21 +02:00
2019-04-26 12:34:05 +02:00
2020-07-27 17:46:24 +09:00
2017-12-05 07:51:09 +01:00
2020-10-25 14:51:49 -07:00
2021-04-05 11:30:57 +02:00
2021-06-07 17:07:00 +02:00
2021-06-18 16:41:21 +02:00
2018-03-26 16:13:11 +02:00
2020-09-15 13:21:46 -07:00
2021-06-07 17:07:01 +02:00
2020-08-26 18:47:21 +02:00
2020-09-14 10:30:07 +02:00
2017-11-02 11:10:55 +01:00
2021-06-28 11:18:28 +02:00
2020-09-17 13:00:46 -04:00
2019-10-04 16:37:33 +02:00
2017-11-02 11:10:55 +01:00
2021-07-05 12:44:23 +02:00
2019-02-22 09:19:52 +01:00
2019-11-30 10:52:46 +01:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2021-01-19 12:29:26 +01:00
2017-11-02 11:10:55 +01:00
2020-09-15 13:21:46 -07:00
2021-07-05 12:44:23 +02:00
2017-11-02 11:10:55 +01:00
2020-08-11 18:16:43 +02:00
2020-12-16 14:55:49 +01:00
2020-06-23 09:16:48 +02:00
2018-01-23 07:36:53 +01:00
2017-11-02 11:10:55 +01:00
2017-12-13 10:51:36 +01:00
2018-02-02 10:47:14 +01:00
2019-05-03 17:17:58 +02:00
2021-07-08 22:12:17 +02:00
2021-07-08 22:12:17 +02:00
2017-11-02 11:10:55 +01:00
2020-07-20 10:55:50 +02:00
2017-11-02 11:10:55 +01:00
2021-06-18 16:41:23 +02:00
2017-11-02 11:10:55 +01:00
2021-07-15 12:54:58 +02:00
2020-11-23 12:01:12 +01:00
2020-09-30 12:09:54 +02:00
2021-02-10 23:34:16 +01:00
2020-06-09 09:39:13 -07:00
2020-03-11 14:18:44 +01:00
2019-06-04 15:03:18 +02:00
2021-03-08 10:46:27 +01:00
2021-05-07 00:26:34 -07:00
2020-10-02 14:40:48 +02:00
2021-02-24 00:31:22 +01:00
2019-04-29 10:47:01 +02:00
2021-06-18 16:41:19 +02:00
2019-02-05 14:29:23 +01:00
2017-11-02 11:10:55 +01:00
2020-01-22 13:05:35 +01:00
2021-06-18 16:41:19 +02:00
2020-12-29 15:36:49 -08:00
2017-11-02 11:10:55 +01:00
2019-04-29 10:47:10 +02:00
2020-01-30 13:07:55 +01:00
2021-06-24 11:47:56 -04:00
2018-03-06 18:40:44 +01:00
2021-07-08 22:12:18 +02:00
2020-11-13 12:15:28 -05:00
2021-06-07 17:07:01 +02:00
2019-08-26 12:51:18 +02:00
2019-08-09 22:52:11 +10:00
2021-06-07 17:06:59 +02:00
2020-04-04 09:45:50 -07:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2021-07-05 12:44:23 +02:00
2018-04-11 17:46:00 +02:00
2019-05-02 13:54:11 +02:00
2020-02-27 16:02:21 +01:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2021-07-04 12:17:38 -07:00
2020-09-14 10:30:07 +02:00
2017-11-13 11:47:01 -08:00
2020-06-29 16:32:09 +02:00
2019-07-11 20:40:02 +02:00
2020-05-14 23:21:37 +02:00
2021-06-28 11:18:28 +02:00
2021-06-28 11:18:28 +02:00
2019-11-30 10:52:44 +01:00
2021-07-01 11:06:03 -07:00
2021-07-04 12:17:38 -07:00
2019-08-21 12:58:53 +02:00
2019-02-07 18:06:18 -08:00
2021-07-08 22:12:18 +02:00
2021-06-18 16:41:19 +02:00
2020-09-14 11:38:35 +02:00
2021-07-08 22:12:17 +02:00
2018-07-06 08:47:51 +02:00
2021-06-11 12:49:15 -07:00
2018-02-02 10:47:15 +01:00
2017-11-02 11:10:55 +01:00
2020-11-18 12:16:02 +01:00
2021-02-09 15:57:04 +01:00
2020-11-20 11:16:35 -08:00
2020-10-26 14:18:01 +01:00
2017-11-02 11:10:55 +01:00
2020-09-14 11:38:34 +02:00
2021-07-05 12:44:23 +02:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2021-06-18 16:41:22 +02:00
2021-03-09 10:16:26 +01:00
2021-07-08 22:12:18 +02:00
2017-11-02 11:10:55 +01:00
2021-03-28 20:23:54 +02:00
2021-04-12 12:46:43 +02:00
2021-07-08 22:12:18 +02:00
2020-09-26 15:51:21 +02:00
2021-06-28 11:18:28 +02:00
2017-12-05 07:51:08 +01:00
2021-01-19 12:29:27 +01:00
2021-01-19 12:29:26 +01:00
2018-02-02 10:47:15 +01:00
2017-11-02 11:10:55 +01:00
2021-02-09 15:57:04 +01:00
2021-06-28 11:18:28 +02:00
2021-01-19 12:29:25 +01:00
2020-09-30 12:09:54 +02:00
2020-08-11 18:16:35 +02:00
2021-06-07 17:07:01 +02:00
2021-06-18 16:41:21 +02:00
2021-06-18 16:41:23 +02:00
2019-07-23 10:45:53 +02:00
2019-11-30 10:52:48 +01:00
2017-11-02 11:10:55 +01:00
2017-11-02 11:10:55 +01:00
2021-07-05 12:44:23 +02:00
2021-07-08 15:37:28 +02:00
2017-12-05 07:51:09 +01:00
2019-12-10 10:12:55 +01:00
2019-04-10 17:47:09 +02:00
2021-01-19 12:29:26 +01:00
2020-09-30 12:09:54 +02:00
2019-02-07 11:57:10 +01:00
2017-11-02 11:10:55 +01:00