Files
linux/include/linux
Mikulas Patocka fd7c092e71 dm: fix truncated status strings
Avoid returning a truncated table or status string instead of setting
the DM_BUFFER_FULL_FLAG when the last target of a table fills the
buffer.

When processing a table or status request, the function retrieve_status
calls ti->type->status. If ti->type->status returns non-zero,
retrieve_status assumes that the buffer overflowed and sets
DM_BUFFER_FULL_FLAG.

However, targets don't return non-zero values from their status method
on overflow. Most targets returns always zero.

If a buffer overflow happens in a target that is not the last in the
table, it gets noticed during the next iteration of the loop in
retrieve_status; but if a buffer overflow happens in the last target, it
goes unnoticed and erroneously truncated data is returned.

In the current code, the targets behave in the following way:
* dm-crypt returns -ENOMEM if there is not enough space to store the
  key, but it returns 0 on all other overflows.
* dm-thin returns errors from the status method if a disk error happened.
  This is incorrect because retrieve_status doesn't check the error
  code, it assumes that all non-zero values mean buffer overflow.
* all the other targets always return 0.

This patch changes the ti->type->status function to return void (because
most targets don't use the return code). Overflow is detected in
retrieve_status: if the status method fills up the remaining space
completely, it is assumed that buffer overflow happened.

Cc: stable@vger.kernel.org
Signed-off-by: Mikulas Patocka <mpatocka@redhat.com>
Signed-off-by: Alasdair G Kergon <agk@redhat.com>
2013-03-01 22:45:44 +00:00
..
2013-01-02 17:36:10 -08:00
2013-01-02 17:36:10 -08:00
2013-01-03 14:34:06 -08:00
2012-10-08 13:50:20 +10:30
2012-12-02 00:05:12 +00:00
2013-02-14 09:21:15 -05:00
2013-01-29 10:48:30 +01:00
2012-11-08 16:58:31 +01:00
2012-12-24 09:36:38 -07:00
2012-09-30 18:02:20 -07:00
2012-11-28 11:54:40 +01:00
2012-10-16 18:49:15 -07:00
2013-02-26 02:46:08 -05:00
2012-11-22 13:43:27 +09:00
2013-01-24 09:04:04 +01:00
2012-11-28 21:49:02 -05:00
2012-11-28 21:49:02 -05:00
2013-02-22 23:31:31 -05:00
2012-11-08 16:58:30 +01:00
2013-01-25 21:03:54 -08:00
2012-11-23 12:23:40 +01:00
2013-02-27 19:10:21 -08:00
2013-02-06 15:59:47 -05:00
2012-12-14 13:05:26 +10:30
2013-01-29 13:59:57 -05:00
2012-11-21 15:09:26 -08:00
2013-01-10 11:44:38 -06:00
2013-01-29 19:32:58 -08:00
2012-11-20 16:15:02 +10:00
2012-11-03 14:50:15 -04:00
2012-10-10 01:15:44 -04:00
2012-12-12 17:38:33 -08:00
2013-01-21 17:18:20 +10:30
2012-12-14 13:06:40 +10:30
2012-12-25 18:45:06 -05:00
2012-12-11 17:22:27 -08:00
2012-10-17 15:53:02 -05:00
2012-10-10 22:41:05 -04:00
2013-01-24 15:37:26 +01:00
2013-01-03 15:57:14 -08:00
2013-01-23 13:44:00 -05:00
2012-11-16 14:33:04 -08:00
2012-10-06 03:05:01 +09:00
2013-02-19 08:43:34 +01:00
2013-02-03 15:09:26 -05:00
2012-12-18 15:02:13 -08:00
2012-12-18 15:02:14 -08:00
2013-02-10 19:41:08 -05:00
2012-12-24 09:36:38 -07:00
2013-02-14 09:21:15 -05:00
2012-10-09 16:22:32 +09:00
2013-01-15 22:43:15 -08:00
2013-02-08 18:28:04 +01:00
2013-01-25 15:06:01 -08:00