mirror of
https://github.com/raspberrypi/linux.git
synced 2025-12-09 11:30:02 +00:00
6ffdf037dd
[ Upstream commit ce2b93fc1d ]
The dsp_local_on selftest expects the scheduler to fail by trying to
schedule an e.g. CPU-affine task to the wrong CPU. However, this isn't
guaranteed to happen in the 1 second window that the test is running.
Besides, it's odd to have this particular exception path tested when there
are no other tests that verify that the interface is working at all - e.g.
the test would pass if dsp_local_on interface is completely broken and fails
on any attempt.
Flip the test so that it verifies that the feature works. While at it, fix a
typo in the info message.
Signed-off-by: Tejun Heo <tj@kernel.org>
Reported-by: Ihor Solodrai <ihor.solodrai@pm.me>
Link: http://lkml.kernel.org/r/Z1n9v7Z6iNJ-wKmq@slm.duckdns.org
Signed-off-by: Tejun Heo <tj@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
60 lines
1.3 KiB
C
60 lines
1.3 KiB
C
/* SPDX-License-Identifier: GPL-2.0 */
|
|
/*
|
|
* Copyright (c) 2024 Meta Platforms, Inc. and affiliates.
|
|
* Copyright (c) 2024 David Vernet <dvernet@meta.com>
|
|
*/
|
|
#include <bpf/bpf.h>
|
|
#include <scx/common.h>
|
|
#include <unistd.h>
|
|
#include "dsp_local_on.bpf.skel.h"
|
|
#include "scx_test.h"
|
|
|
|
static enum scx_test_status setup(void **ctx)
|
|
{
|
|
struct dsp_local_on *skel;
|
|
|
|
skel = dsp_local_on__open();
|
|
SCX_FAIL_IF(!skel, "Failed to open");
|
|
|
|
skel->rodata->nr_cpus = libbpf_num_possible_cpus();
|
|
SCX_FAIL_IF(dsp_local_on__load(skel), "Failed to load skel");
|
|
*ctx = skel;
|
|
|
|
return SCX_TEST_PASS;
|
|
}
|
|
|
|
static enum scx_test_status run(void *ctx)
|
|
{
|
|
struct dsp_local_on *skel = ctx;
|
|
struct bpf_link *link;
|
|
|
|
link = bpf_map__attach_struct_ops(skel->maps.dsp_local_on_ops);
|
|
SCX_FAIL_IF(!link, "Failed to attach struct_ops");
|
|
|
|
/* Just sleeping is fine, plenty of scheduling events happening */
|
|
sleep(1);
|
|
|
|
bpf_link__destroy(link);
|
|
|
|
SCX_EQ(skel->data->uei.kind, EXIT_KIND(SCX_EXIT_UNREG));
|
|
|
|
return SCX_TEST_PASS;
|
|
}
|
|
|
|
static void cleanup(void *ctx)
|
|
{
|
|
struct dsp_local_on *skel = ctx;
|
|
|
|
dsp_local_on__destroy(skel);
|
|
}
|
|
|
|
struct scx_test dsp_local_on = {
|
|
.name = "dsp_local_on",
|
|
.description = "Verify we can directly dispatch tasks to a local DSQs "
|
|
"from ops.dispatch()",
|
|
.setup = setup,
|
|
.run = run,
|
|
.cleanup = cleanup,
|
|
};
|
|
REGISTER_SCX_TEST(&dsp_local_on)
|