Dmitry Vyukov 90040a4803 selftests: Fix errno checking in syscall_user_dispatch test ...

[ Upstream commit b89732c8c8 ]

Successful syscalls don't change errno, so checking errno is wrong
to ensure that a syscall has failed. For example for the following
sequence:

	prctl(PR_SET_SYSCALL_USER_DISPATCH, op, 0x0, 0xff, 0);
	EXPECT_EQ(EINVAL, errno);
	prctl(PR_SET_SYSCALL_USER_DISPATCH, op, 0x0, 0x0, &sel);
	EXPECT_EQ(EINVAL, errno);

only the first syscall may fail and set errno, but the second may succeed
and keep errno intact, and the check will falsely pass.
Or if errno happened to be EINVAL before, even the first check may falsely
pass.

Also use EXPECT/ASSERT consistently. Currently there is an inconsistent mix
without obvious reasons for usage of one or another.

Fixes: 179ef03599 ("selftests: Add kselftest for syscall user dispatch")
Signed-off-by: Dmitry Vyukov <dvyukov@google.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Link: https://lore.kernel.org/all/af6a04dbfef9af8570f5bab43e3ef1416b62699a.1747839857.git.dvyukov@google.com
Signed-off-by: Sasha Levin <sashal@kernel.org>

2025-08-15 12:13:33 +02:00

..

.gitignore

…

config

…

Makefile

selftests: Add benchmark for syscall user dispatch

2020-12-02 15:07:57 +01:00

sud_benchmark.c

entry: Use different define for selector variable in SUD

2021-02-06 00:21:42 +01:00

sud_test.c

selftests: Fix errno checking in syscall_user_dispatch test

2025-08-15 12:13:33 +02:00