raspi/linux
1
0
Fork 1
mirror of https://github.com/raspberrypi/linux.git synced 2025-12-06 01:49:46 +00:00
Code Issues Projects Releases Wiki Activity

bcm2835-sdhost: Ignore CRC7 for MMC CMD1

Browse Source 
It seems that the sdhost interface returns CRC7 errors for CMD1,
which is the MMC-specific SEND_OP_COND. Returning these errors to
the MMC layer causes a downward spiral, but ignoring them seems
to be harmless.
This commit is contained in:
Phil Elwell
2015-07-20 17:32:18 +01:00
committed by popcornmix
parent 26be449bd4
commit 02c4ebf0f3
1 changed files with 24 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

41
drivers/mmc/host/bcm2835-sdhost.c
View File

@@ -959,25 +959,32 @@ static void bcm2835_sdhost_finish_command(struct bcm2835_host *host)
mmc_hostname(host->mmc), sdcmd, sdhsts,
bcm2835_sdhost_read(host, SDEDM));
if (sdhsts & SDHSTS_CMD_TIME_OUT) {
switch (host->cmd->opcode) {
case 5: case 52: case 53:
/* Don't warn about SDIO commands */
break;
default:
pr_err("%s: command timeout\n",
mmc_hostname(host->mmc));
break;
}
host->cmd->error = -ETIMEDOUT;
if ((sdhsts & SDHSTS_CRC7_ERROR) &&
(host->cmd->opcode == 1)) {
if (host->debug)
pr_info("%s: ignoring CRC7 error for CMD1\n",
mmc_hostname(host->mmc));
} else {
pr_err("%s: unexpected command error\n",
mmc_hostname(host->mmc));
bcm2835_sdhost_dumpregs(host);
host->cmd->error = -EIO;
if (sdhsts & SDHSTS_CMD_TIME_OUT) {
switch (host->cmd->opcode) {
case 5: case 52: case 53:
/* Don't warn about SDIO commands */
break;
default:
pr_err("%s: command timeout\n",
mmc_hostname(host->mmc));
break;
}
host->cmd->error = -ETIMEDOUT;
} else {
pr_err("%s: unexpected command error\n",
mmc_hostname(host->mmc));
bcm2835_sdhost_dumpregs(host);
host->cmd->error = -EIO;
}
tasklet_schedule(&host->finish_tasklet);
return;
}
tasklet_schedule(&host->finish_tasklet);
return;
}
if (host->cmd->flags & MMC_RSP_PRESENT) {