mirror of
https://github.com/raspberrypi/linux.git
synced 2025-12-06 01:49:46 +00:00
mtd: rawnand: nuvoton: Fix an error handling path in ma35_nand_chips_init()
[ Upstream commit1eae113dd5] If a ma35_nand_chip_init() call fails, then a reference to 'nand_np' still needs to be released. Use for_each_child_of_node_scoped() to fix the issue. Fixes:5abb5d414d("mtd: rawnand: nuvoton: add new driver for the Nuvoton MA35 SoC") Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com> Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
committed by
Greg Kroah-Hartman
parent
c62608a41b
commit
0cd36f52fe
@@ -935,10 +935,10 @@ static void ma35_chips_cleanup(struct ma35_nand_info *nand)
|
||||
|
||||
static int ma35_nand_chips_init(struct device *dev, struct ma35_nand_info *nand)
|
||||
{
|
||||
struct device_node *np = dev->of_node, *nand_np;
|
||||
struct device_node *np = dev->of_node;
|
||||
int ret;
|
||||
|
||||
for_each_child_of_node(np, nand_np) {
|
||||
for_each_child_of_node_scoped(np, nand_np) {
|
||||
ret = ma35_nand_chip_init(dev, nand, nand_np);
|
||||
if (ret) {
|
||||
ma35_chips_cleanup(nand);
|
||||
|
||||
Reference in New Issue
Block a user