mirror of
https://github.com/raspberrypi/linux.git
synced 2026-01-04 18:27:36 +00:00
USB: sl811: fix memory leak with using debugfs_lookup()
[ Upstream commit e1523c4dbc ]
When calling debugfs_lookup() the result must have dput() called on it,
otherwise the memory will leak over time. To make things simpler, just
call debugfs_lookup_and_remove() instead which handles all of the logic
at once.
Cc: Vincent Mailhol <mailhol.vincent@wanadoo.fr>
Link: https://lore.kernel.org/r/20230202153235.2412790-4-gregkh@linuxfoundation.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
This commit is contained in:
@@ -1501,7 +1501,7 @@ static void create_debug_file(struct sl811 *sl811)
|
||||
|
||||
static void remove_debug_file(struct sl811 *sl811)
|
||||
{
|
||||
debugfs_remove(debugfs_lookup("sl811h", usb_debug_root));
|
||||
debugfs_lookup_and_remove("sl811h", usb_debug_root);
|
||||
}
|
||||
|
||||
/*-------------------------------------------------------------------------*/
|
||||
|
||||
Reference in New Issue
Block a user