mirror of
https://github.com/raspberrypi/linux.git
synced 2025-12-06 01:49:46 +00:00
backlight: lcd: Fix race condition during register
[ Upstream commit cc21942bce ]
Once device_register is called for a device its attributes might be
accessed. As the callbacks of a lcd device's attributes make use of the
lcd_ops, the respective member must be setup before calling
device_register.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
Signed-off-by: Sasha Levin <alexander.levin@verizon.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
committed by
Greg Kroah-Hartman
parent
acc365c028
commit
6aaf9ba9bd
@@ -226,6 +226,8 @@ struct lcd_device *lcd_device_register(const char *name, struct device *parent,
|
||||
dev_set_name(&new_ld->dev, "%s", name);
|
||||
dev_set_drvdata(&new_ld->dev, devdata);
|
||||
|
||||
new_ld->ops = ops;
|
||||
|
||||
rc = device_register(&new_ld->dev);
|
||||
if (rc) {
|
||||
put_device(&new_ld->dev);
|
||||
@@ -238,8 +240,6 @@ struct lcd_device *lcd_device_register(const char *name, struct device *parent,
|
||||
return ERR_PTR(rc);
|
||||
}
|
||||
|
||||
new_ld->ops = ops;
|
||||
|
||||
return new_ld;
|
||||
}
|
||||
EXPORT_SYMBOL(lcd_device_register);
|
||||
|
||||
Reference in New Issue
Block a user