mirror of
https://github.com/raspberrypi/linux.git
synced 2025-12-06 01:49:46 +00:00
overlays: i2c1-bcm2708: Don't overwrite i2c1 pins node
It is bad practise to overwrite an entire node in an overlay. Instead, target the node and overwrite any properties that need changing. See: https://github.com/raspberrypi/linux/pull/2118 Suggested-by: soodvarun78 <soodvarun78@gmail.com> Signed-off-by: Phil Elwell <phil@raspberrypi.org>
This commit is contained in:
@@ -20,18 +20,15 @@
|
||||
};
|
||||
|
||||
fragment@1 {
|
||||
target = <&gpio>;
|
||||
__overlay__ {
|
||||
i2c1_pins: i2c1 {
|
||||
brcm,pins = <2 3>;
|
||||
brcm,function = <4>; /* alt0 */
|
||||
};
|
||||
target = <&i2c1_pins>;
|
||||
pins: __overlay__ {
|
||||
brcm,pins = <2 3>;
|
||||
brcm,function = <4>; /* alt 0 */
|
||||
};
|
||||
};
|
||||
|
||||
__overrides__ {
|
||||
sda1_pin = <&i2c1_pins>,"brcm,pins:0";
|
||||
scl1_pin = <&i2c1_pins>,"brcm,pins:4";
|
||||
pin_func = <&i2c1_pins>,"brcm,function:0";
|
||||
sda1_pin = <&pins>,"brcm,pins:0";
|
||||
scl1_pin = <&pins>,"brcm,pins:4";
|
||||
pin_func = <&pins>,"brcm,function:0";
|
||||
};
|
||||
};
|
||||
|
||||
Reference in New Issue
Block a user